light-services 0.6.3 → 2.0.0.beta1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 86f26dbb1d2ea28fb7cb8c8b9615d93bdc536755f28240a56d562085e37b53e8
-  data.tar.gz: e96c9fc9bf526e93639f6c8e46252dab105423797e3068cbd2c2fcc9d57db642
+  metadata.gz: 9f6aea8958d622cea908db1b8697ab34919a55b8a90ae08dcd1308498e5963ec
+  data.tar.gz: d4a1226609083ba01282c7d1bc273e75c394b2d39a2c17cca53792bc7eff74ab
 SHA512:
-  metadata.gz: c7aab86f783de54ffecf6b9682c4cc8cdf3046049e314e75bb23fcc24f405dc04a76e07c3f9ca5eb2ae06dbeb9f19a5ead2447953535fba1041260caaf8a7fc6
-  data.tar.gz: f156cf767647c47ca47a0058d8f9e41d89bda90daed7eecd69fb209fdcbf0d9c45205374a68a85abe8510e812a479c9b68e7621cca9994ef1becbe83fdb51350
+  metadata.gz: e1dcc97d1d3cf6d48062a2dcb7061ecaccf602224dfbb68111c83a499614d221c17b3b1c0301ca448e58d27bcbd495d5303b5577fb1facdf16140ac591b40c1c
+  data.tar.gz: 0d3d5f2282f56fbe07f786f54c098f9235a5f84906f70aaac1214da61c3fbef847c2af9754228c9b6eb9a682a40f2dd1bb1737755457e67a1a6bb5dc56816ffc

data/.github/config/rubocop_linter_action.yml

@@ -0,0 +1,4 @@
+versions:
+  - rubocop: "0.86"
+  - rubocop-rspec: "1.40"
+  - rubocop-performance: "1.6"

data/.github/workflows/ci.yml

@@ -0,0 +1,63 @@
+name: CI
+on: push
+
+jobs:
+  rubocop:
+    name: Rubocop
+    runs-on: ubuntu-latest
+    steps:
+      - name: Git Checkout
+        uses: actions/checkout@v2
+
+      - name: Rubocop
+        uses: andrewmcodes/rubocop-linter-action@v3.2.0
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+
+  rspec:
+    name: RSpec
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby: [2.5, 2.6, 2.7, head, debug]
+    steps:
+      - name: Git Checkout
+        uses: actions/checkout@v2
+
+      - name: Install dependencies
+        run: sudo apt-get install libsqlite3-dev
+
+      - name: Setup Ruby
+        uses: ruby/setup-ruby@v1.38.0
+        with:
+          ruby-version: ${{ matrix.ruby }}
+          bundler-cache: true
+
+      - name: RSpec
+        run: bundle exec rspec
+
+  codecov:
+    name: Code Coverage
+    runs-on: ubuntu-latest
+    env:
+      CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
+    steps:
+      - name: Git Checkout
+        uses: actions/checkout@v2
+
+      - name: Install dependencies
+        run: sudo apt-get install libsqlite3-dev
+
+      - name: Setup Ruby
+        uses: ruby/setup-ruby@v1.38.0
+        with:
+          ruby-version: head
+          bundler-cache: true
+
+      - name: RSpec
+        run: bundle exec rspec
+
+      - name: Code Coverage
+        uses: codecov/codecov-action@v1
+        with:
+          token: ${{ secrets.CODECOV_TOKEN }}

data/.gitignore

@@ -1,6 +1,5 @@
 /.bundle/
 /.yardoc
-/Gemfile.lock
 /_yardoc/
 /coverage/
 /doc/
@@ -8,6 +7,6 @@
 /spec/reports/
 /tmp/
 /.idea/
-/gemfiles/.bundle/
-/*.gem
-/*.iml
+
+# rspec failure tracking
+.rspec_status

data/.rspec

@@ -1,2 +1,3 @@
 --format documentation
 --color
+--require spec_helper

data/.rubocop.yml

@@ -1,16 +1,30 @@
+require:
+  - rubocop-rspec
+  - rubocop-performance
+
 AllCops:
-  TargetRubyVersion: 2.4
+  NewCops: enable
+
+Layout/MultilineMethodCallIndentation:
+  EnforcedStyle: indented
+
+Metrics/BlockLength:
+  Exclude:
+    - spec/**/*_spec.rb
+
+Security/Eval:
+  Exclude:
+    - spec/light/services/error_spec.rb
 
 Style/Documentation:
   Enabled: false
 
-Style/ClassAndModuleChildren:
-  Exclude:
-    - 'spec/**/*'
+Style/StringLiterals:
+  EnforcedStyle: double_quotes
 
-Metrics/LineLength:
-  Max: 120
+Style/GuardClause:
+  Enabled: false
 
-Metrics/BlockLength:
+Style/ClassAndModuleChildren:
   Exclude:
-    - 'spec/**/*'
+    - spec/data/services/**/*.rb

data/CHANGELOG.md

@@ -0,0 +1 @@
+# Changelog

data/CODE_OF_CONDUCT.md

@@ -1,24 +1,41 @@
-# Contributor Code of Conduct
+# Contributor Covenant Code of Conduct
 
-As contributors and maintainers of this project, and in the interest of
-fostering an open and welcoming community, we pledge to respect all people who
-contribute through reporting issues, posting feature requests, updating
-documentation, submitting pull requests or patches, and other activities.
+## Our Pledge
 
-We are committed to making participation in this project a harassment-free
-experience for everyone, regardless of level of experience, gender, gender
-identity and expression, sexual orientation, disability, personal appearance,
-body size, race, ethnicity, age, religion, or nationality.
+In the interest of fostering an open and welcoming environment, we as
+contributors and maintainers pledge to making participation in our project and
+our community a harassment-free experience for everyone, regardless of age, body
+size, disability, ethnicity, gender identity and expression, level of experience,
+nationality, personal appearance, race, religion, or sexual identity and
+orientation.
+
+## Our Standards
+
+Examples of behavior that contributes to creating a positive environment
+include:
+
+* Using welcoming and inclusive language
+* Being respectful of differing viewpoints and experiences
+* Gracefully accepting constructive criticism
+* Focusing on what is best for the community
+* Showing empathy towards other community members
 
 Examples of unacceptable behavior by participants include:
 
-* The use of sexualized language or imagery
-* Personal attacks
-* Trolling or insulting/derogatory comments
+* The use of sexualized language or imagery and unwelcome sexual attention or
+advances
+* Trolling, insulting/derogatory comments, and personal or political attacks
 * Public or private harassment
-* Publishing other's private information, such as physical or electronic
-  addresses, without explicit permission
-* Other unethical or unprofessional conduct
+* Publishing others' private information, such as a physical or electronic
+  address, without explicit permission
+* Other conduct which could reasonably be considered inappropriate in a
+  professional setting
+
+## Our Responsibilities
+
+Project maintainers are responsible for clarifying the standards of acceptable
+behavior and are expected to take appropriate and fair corrective action in
+response to any instances of unacceptable behavior.
 
 Project maintainers have the right and responsibility to remove, edit, or
 reject comments, commits, code, wiki edits, issues, and other contributions
@@ -26,24 +43,32 @@ that are not aligned to this Code of Conduct, or to ban temporarily or
 permanently any contributor for other behaviors that they deem inappropriate,
 threatening, offensive, or harmful.
 
-By adopting this Code of Conduct, project maintainers commit themselves to
-fairly and consistently applying these principles to every aspect of managing
-this project. Project maintainers who do not follow or enforce the Code of
-Conduct may be permanently removed from the project team.
+## Scope
+
+This Code of Conduct applies both within project spaces and in public spaces
+when an individual is representing the project or its community. Examples of
+representing a project or community include using an official project e-mail
+address, posting via an official social media account, or acting as an appointed
+representative at an online or offline event. Representation of a project may be
+further defined and clarified by project maintainers.
 
-This code of conduct applies both within project spaces and in public spaces
-when an individual is representing the project or its community.
+## Enforcement
 
 Instances of abusive, harassing, or otherwise unacceptable behavior may be
-reported by contacting a project maintainer at emelianenko.web@gmail.com. All
+reported by contacting the project team at emelianenko.web@gmail.com. All
 complaints will be reviewed and investigated and will result in a response that
-is deemed necessary and appropriate to the circumstances. Maintainers are
-obligated to maintain confidentiality with regard to the reporter of an
-incident.
+is deemed necessary and appropriate to the circumstances. The project team is
+obligated to maintain confidentiality with regard to the reporter of an incident.
+Further details of specific enforcement policies may be posted separately.
+
+Project maintainers who do not follow or enforce the Code of Conduct in good
+faith may face temporary or permanent repercussions as determined by other
+members of the project's leadership.
+
+## Attribution
 
-This Code of Conduct is adapted from the [Contributor Covenant][homepage],
-version 1.3.0, available at
-[http://contributor-covenant.org/version/1/3/0/][version]
+This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 1.4,
+available at [https://contributor-covenant.org/version/1/4][version]
 
-[homepage]: http://contributor-covenant.org
-[version]: http://contributor-covenant.org/version/1/3/0/
+[homepage]: https://contributor-covenant.org
+[version]: https://contributor-covenant.org/version/1/4/

data/Gemfile

@@ -1,6 +1,20 @@
 # frozen_string_literal: true
 
-source 'https://rubygems.org'
+source "https://rubygems.org"
 
-# Specify your gem's dependencies in light-services.gemspec
 gemspec
+
+group :test do
+  gem "activerecord", "~> 6.0"
+  gem "database_cleaner-active_record", "~> 1.8"
+  gem "sqlite3", "~> 1.4"
+
+  gem "codecov", "~> 0.1.17"
+  gem "rake", "~> 13.0"
+  gem "rspec", "~> 3.9"
+  gem "simplecov", "~> 0.18"
+
+  gem "rubocop", "~> 0.86",            require: false
+  gem "rubocop-performance", "~> 1.6", require: false
+  gem "rubocop-rspec", "~> 1.40",      require: false
+end

data/Gemfile.lock

@@ -0,0 +1,101 @@
+PATH
+  remote: .
+  specs:
+    light-services (2.0.0.beta1)
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    activemodel (6.0.3.2)
+      activesupport (= 6.0.3.2)
+    activerecord (6.0.3.2)
+      activemodel (= 6.0.3.2)
+      activesupport (= 6.0.3.2)
+    activesupport (6.0.3.2)
+      concurrent-ruby (~> 1.0, >= 1.0.2)
+      i18n (>= 0.7, < 2)
+      minitest (~> 5.1)
+      tzinfo (~> 1.1)
+      zeitwerk (~> 2.2, >= 2.2.2)
+    ast (2.4.1)
+    codecov (0.1.17)
+      json
+      simplecov
+      url
+    concurrent-ruby (1.1.6)
+    database_cleaner (1.8.5)
+    database_cleaner-active_record (1.8.0)
+      activerecord
+      database_cleaner (~> 1.8.0)
+    diff-lcs (1.4.2)
+    docile (1.3.2)
+    i18n (1.8.3)
+      concurrent-ruby (~> 1.0)
+    json (2.3.0)
+    minitest (5.14.1)
+    parallel (1.19.2)
+    parser (2.7.1.4)
+      ast (~> 2.4.1)
+    rainbow (3.0.0)
+    rake (13.0.1)
+    regexp_parser (1.7.1)
+    rexml (3.2.4)
+    rspec (3.9.0)
+      rspec-core (~> 3.9.0)
+      rspec-expectations (~> 3.9.0)
+      rspec-mocks (~> 3.9.0)
+    rspec-core (3.9.2)
+      rspec-support (~> 3.9.3)
+    rspec-expectations (3.9.2)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.9.0)
+    rspec-mocks (3.9.1)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.9.0)
+    rspec-support (3.9.3)
+    rubocop (0.86.0)
+      parallel (~> 1.10)
+      parser (>= 2.7.0.1)
+      rainbow (>= 2.2.2, < 4.0)
+      regexp_parser (>= 1.7)
+      rexml
+      rubocop-ast (>= 0.0.3, < 1.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (>= 1.4.0, < 2.0)
+    rubocop-ast (0.0.3)
+      parser (>= 2.7.0.1)
+    rubocop-performance (1.6.1)
+      rubocop (>= 0.71.0)
+    rubocop-rspec (1.40.0)
+      rubocop (>= 0.68.1)
+    ruby-progressbar (1.10.1)
+    simplecov (0.18.5)
+      docile (~> 1.1)
+      simplecov-html (~> 0.11)
+    simplecov-html (0.12.2)
+    sqlite3 (1.4.2)
+    thread_safe (0.3.6)
+    tzinfo (1.2.7)
+      thread_safe (~> 0.1)
+    unicode-display_width (1.7.0)
+    url (0.3.2)
+    zeitwerk (2.3.1)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  activerecord (~> 6.0)
+  codecov (~> 0.1.17)
+  database_cleaner-active_record (~> 1.8)
+  light-services!
+  rake (~> 13.0)
+  rspec (~> 3.9)
+  rubocop (~> 0.86)
+  rubocop-performance (~> 1.6)
+  rubocop-rspec (~> 1.40)
+  simplecov (~> 0.18)
+  sqlite3 (~> 1.4)
+
+BUNDLED WITH
+   2.1.4

data/LICENSE.txt

@@ -1,6 +1,6 @@
 The MIT License (MIT)
 
-Copyright (c) 2016 Andrew Emelianenko
+Copyright (c) 2020 Andrew Emelianenko
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

data/README.md

@@ -1,150 +1,4 @@
-# Light::Services
-
-[![Build Status](https://travis-ci.org/light-ruby/light-services.svg?branch=master)](https://travis-ci.org/light-ruby/light-services)
-[![Code Climate](https://codeclimate.com/github/light-ruby/light-services/badges/gpa.svg)](https://codeclimate.com/github/light-ruby/light-services)
-[![Test Coverage](https://api.codeclimate.com/v1/badges/ed8713a891f19318bd7c/test_coverage)](https://codeclimate.com/github/light-ruby/light-services/test_coverage)
-
-Implementation of Service Object Pattern for Ruby/Rails. Compatible with Rails 5.1 and 5.0, 4.2, 4.1, 4.0.
-
-Service Object Pattern – What is it? Check it here:
-- [Wikipedia](https://en.wikipedia.org/wiki/Service_layer_pattern)
-- [Essential RubyOnRails patterns — part 1: Service Objects](https://medium.com/selleo/essential-rubyonrails-patterns-part-1-service-objects-1af9f9573ca1)
-
-## Installation
-
-Add this line to your application's Gemfile:
-
-```ruby
-gem 'light-services', '~> 0.6' 
-```
-
-And then execute:
-
-    $ bundle
-
-Or install it yourself as:
-
-    $ gem install light-service
-
-## Usage
-
-#### Examples of usage:
-
-**Change state of the record:**
-```ruby
-class Painting::Publish < ApplicationService
-  # Parameters
-  param :painting, type: Painting
-  param :user,     type: User
-
-  # Callbacks
-  before :authorize
-  after  :send_email_notification
-
-  def run
-    painting.publish!
-  end
-
-  private
-
-  def authorize
-    pundit_authorize!(painting, user, :publish?)
-  end
-
-  def send_email_notification
-    PaintingMailer.publish_email(painting).deliver_now
-  end
-end
-```
-
-**Create a new record:**
-```ruby
-class Owner::Create < ApplicationService
-  # Parameters
-  param :params, type: ActionController::Parameters
-  param :user,   type: User
-
-  # Outputs
-  output :owner
-
-  # Callbacks
-  before :assign_attributes
-  before :authorize
-  before :validate
-
-  def run
-    owner.save!
-  end
-
-  private
-
-  def assign_attributes
-    self.owner = Owner.new(owner_params)
-  end
-
-  def authorize
-    pundit_authorize!(owner, user, :create?)
-  end
-
-  def validate
-    return if owner.valid?
-    errors.from_record(owner)
-  end
-
-  def owner_params
-    params
-      .require(:owner)
-      .permit(:name)
-  end
-end
-```
-
-**Integration with Pundit:**
-```ruby
-class ApplicationService < Light::Services::Base
-  def pundit_authorize!(record, user, action = nil)
-    action = convert_action(action, :show?)
-    policy = Pundit.policy!(user, record)
-
-    return true if policy.public_send(action)
-
-    Rails.logger.info "Pundit: not allowed to #{action} this #{record.inspect}"
-    raise Pundit::NotAuthorizedError, query: action, policy: policy, record: record
-  end
-
-  def pundit_scope!(scope, user, action = nil)
-    action = convert_action(action, :index?)
-    pundit_authorize!(scope, user, action)
-
-    Pundit.policy_scope!(user, scope)
-  end
-  
-  private
-
-  def convert_action(action, default)
-    action = action.to_s
-
-    return default if action.blank?
-    return action if action.ends_with?('?')
-
-    action + '?'
-  end
-end
-
-```
-
-## Development
-
-After checking out the repo, run `bin/setup` to install dependencies. Then, run `rake spec` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.
-
-To install this gem onto your local machine, run `bundle exec rake install`. To release a new version, update the version number in `version.rb`, and then run `bundle exec rake release`, which will create a git tag for the version, push git commits and tags, and push the `.gem` file to [rubygems.org](https://rubygems.org).
-
-## Contributing
-
-Bug reports and pull requests are welcome on GitHub at https://github.com/[USERNAME]/light-service. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [Contributor Covenant](http://contributor-covenant.org) code of conduct.
-
-
-## License
-
-The gem is available as open source under the terms of the [MIT License](http://opensource.org/licenses/MIT).
+# Light Services
+![CI](https://github.com/light-ruby/light-services/workflows/CI/badge.svg)
+[![Codecov](https://codecov.io/gh/light-ruby/light-services/branch/master/graph/badge.svg)](https://codecov.io/gh/light-ruby/light-services)