light-service 0.3.1 → 0.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5dbadd45523f6245d302d195937328fe1819f9b7
-  data.tar.gz: fa3836bd03de541b3d24cc38e9a13800b3c35381
+  metadata.gz: 43b8226d18386ca933714af81639598fdff2332d
+  data.tar.gz: e7112eea09148ee8f06412e7e2f61cea18375d05
 SHA512:
-  metadata.gz: c8356b2a0cd6a0ea403f470352c6c686473340752ac6d35f7bd87893e06167032b51177c4ca4d261da819e4609106034838fbbd0a56d5ec5bddaf8731639959c
-  data.tar.gz: 23696cd73809aaa2ddd2e76c5d2f3d3fb3b2e34640210c830b2404b4132fad2badc816531e54322a3b7d673b1767586e10d0f331ef7d1e0a2bc218ef1c1c3b2a
+  metadata.gz: 6c772140e17955b44a37b923ed4f09a110e5d21da479e2ba44c8a6b0f81b8f647808c722932b56b407bbee781bd57c33981cb36b403f24ee29f746e184410ad1
+  data.tar.gz: 741bf14615577c1d9fe518e5835e3a4a9bde8879810ce9765983db65195afbd5d63e598fe07335bbe47158a9779d9fe23e0f890560dc19bffe5e3bba3ba84784

data/README.md

@@ -202,8 +202,8 @@ Take a look at [this spec](spec/action_expects_and_promises_spec.rb) to see the
 
 ## Error Codes
 
-You can do a more structured error handling by using error codes in the context.
-If something goes wrong in your actions, you can fail the process by setting the context to failure:
+You can add some more structure to your error handling by taking advantage of error codes in the context.
+Normally, when something goes wrong in your actions, you fail the process by setting the context to failure:
 
 ```ruby
 class FooAction
@@ -216,8 +216,8 @@ end
 ```
 
 However, you might need to handle the errors coming from your action pipeline differently.
-Using an error code can help you check what type of expected error occurred from the organizer 
-or action invocation point.
+Using an error code can help you check what type of expected error occurred in the organizer
+or in the actions.
 
 ```ruby
 class FooAction
@@ -273,6 +273,8 @@ For further examples, please visit the project's [Wiki](https://github.com/adomo
 Huge thanks to the [contributors](https://github.com/adomokos/light-service/graphs/contributors)!
 
 ## Release Notes
+### 0.3.2
+* Fixing documentation and using separate arguments instead of a hash when setting the context to failure
 ### 0.3.1
 * Adding [error codes](https://github.com/adomokos/light-service#error-codes) to the context
 

data/lib/light-service/context.rb

@@ -60,13 +60,9 @@ module LightService
       fail!(message)
     end
 
-    def fail!(options=nil)
-      if options.is_a? Hash
-        @message = options[:message]
-        @error_code = options[:error_code]
-      else
-        @message = options
-      end
+    def fail!(message=nil, error_code=nil)
+      @message = message
+      @error_code = error_code
       @outcome = ::LightService::Outcomes::FAILURE
     end
 

data/lib/light-service/version.rb

@@ -1,3 +1,3 @@
 module LightService
-  VERSION = "0.3.1"
+  VERSION = "0.3.2"
 end

data/spec/context_spec.rb

@@ -84,17 +84,19 @@ module LightService
 
     it "can be pushed into a FAILURE state with a message in an options hash" do
       context = Context.make
-      context.fail!(:message => "a sad end")
+      context.fail!("a sad end")
 
       expect(context).to be_failure
+      expect(context.message).to eq("a sad end")
       expect(context.error_code).to be_nil
     end
 
     it "can be pushed into a FAILURE state with an error code in an options hash" do
       context = Context.make
-      context.fail!(:error_code => 10005)
+      context.fail!("a sad end", 10005)
 
       expect(context).to be_failure
+      expect(context.message).to eq("a sad end")
       expect(context.error_code).to eq(10005)
     end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: light-service
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.3.2
 platform: ruby
 authors:
 - Attila Domokos