light-service 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d6e076aae96c52a5762908422611819327dde2bc
-  data.tar.gz: 97f23597368c33f4e5fca9d829b286ae73db14d6
+  metadata.gz: 075a5390fc8de72c59eb0f3be049cff74a286a48
+  data.tar.gz: 7a86920ff7b6e4fe62d9123a3b868741cca216eb
 SHA512:
-  metadata.gz: d6aeba0dd3f98960c6e5b13a878018afb5e7f2c6a50b0254dfcadf13b6045c649df51f29c07fd8b023c4f3d075551a6923d63919f3870c2cebc3ce2bf05067ed
-  data.tar.gz: f9cf3c1bff5df5411bee9240de31192d8a63f42175335905fd5c62d5e1b11d99daf7d824cdd1db8f69348982d17cda18a9a6db77fc3b2d3bbab9f5c73a694a09
+  metadata.gz: 3c35a6ce18183266e3df8aaa361b9d5271c95330507e276c0393bfbfea82614b5890d3ed043a3ce64bcd3912cdbb96ef7fe6b5b10d3785e8760ddeb796bff2c6
+  data.tar.gz: d2083efec69ab5b70ff3befe6f428ce742e687ab6e6f3ac8c32e7447970905e573cd6741c7f35460dd7842e40ab52b90ad1603a03866dcd1cc959367496590c6

data/README.md

@@ -189,9 +189,13 @@ Huge thanks to the [contributors](https://github.com/adomokos/light-service/grap
 
 ## Release Notes
 
+### 0.2.1
+* [Improving](https://github.com/adomokos/light-service/commit/fc7043241396b4a2556e9664c13c6929f8330025) deprecation warning for the renamed methods
+* Making the message an optional argument for `succeed!` and `fail!` methods
+
 ### 0.2.0
-* [Renaming](https://github.com/adomokos/light-service/commit/8d40ff7d393a157a8a558f9e4e021b8731550834) the `set_success!` and `set_failure!` methods to `succeed!` and `fail!`.
-* [Throwing](https://github.com/adomokos/light-service/commit/5ef315b8aeeafc99e38676adad3c11df5d93b0e3) an ArgumentError if the `make` method's argument is not Hash or LightService::Context.
+* [Renaming](https://github.com/adomokos/light-service/commit/8d40ff7d393a157a8a558f9e4e021b8731550834) the `set_success!` and `set_failure!` methods to `succeed!` and `fail!`
+* [Throwing](https://github.com/adomokos/light-service/commit/5ef315b8aeeafc99e38676adad3c11df5d93b0e3) an ArgumentError if the `make` method's argument is not Hash or LightService::Context
 
 ## License
 

data/lib/light-service/context.rb

@@ -46,26 +46,26 @@ module LightService
     end
 
     def set_success!(message)
-      warn 'DEPRECATED: Please use `succeed!` instead'
+      warn '`set_success!` is DEPRECATED: please use `succeed!` instead'
       succeed!(message)
     end
 
-    def succeed!(message)
+    def succeed!(message=nil)
       @message = message
       @outcome = ::LightService::Outcomes::SUCCESS
     end
 
     def set_failure!(message)
-      warn 'DEPRECATED: Please use `fail!` instead'
+      warn '`set_failure!` is DEPRECATED: please use `fail!` instead'
       fail!(message)
     end
 
-    def fail!(message)
+    def fail!(message=nil)
       @message = message
       @outcome = ::LightService::Outcomes::FAILURE
     end
 
-    def skip_all!(message = nil)
+    def skip_all!(message=nil)
       @message = message
       @skip_all = true
     end

data/lib/light-service/version.rb

@@ -1,3 +1,3 @@
 module LightService
-  VERSION = "0.2.0"
+  VERSION = "0.2.1"
 end

data/spec/context_spec.rb

@@ -53,12 +53,26 @@ module LightService
       expect(context).to be_success
     end
 
+    it "can be pushed into a SUCCESS state without a message" do
+      context = Context.make
+      context.succeed!
+      expect(context).to be_success
+      expect(context.message).to be_nil
+    end
+
     it "can be pushed into a FAILURE state" do
       context = Context.make
       context.fail!("a sad end")
       expect(context).to be_failure
     end
 
+    it "can be pushed into a FAILURE state without a message" do
+      context = Context.make
+      context.fail!
+      expect(context).to be_failure
+      expect(context.message).to be_nil
+    end
+
     it "can set a flag to skip all subsequent actions" do
       context = Context.make
       context.skip_all!

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: light-service
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Attila Domokos