lifen 1.5.1 → 1.5.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5c313933ddbf8bc22bfb69240a8447044cb03fd4
-  data.tar.gz: 3ec79fe55b174797095f8bda5a01a8df52e5272f
+  metadata.gz: 6f1aef95bf44e742592d04b253e4b19f6bdb9eb7
+  data.tar.gz: 9ff4e2c43626c1bc379e31de7b65dd97e125aaeb
 SHA512:
-  metadata.gz: b0f42ad92dcdbfba42102b977b2b9437c5c8ba29da1549b75b513e0322d13f56586c2884a68d918d25772b95dc3f05c27cc8af6d4f88f9748d3a4357357dd39c
-  data.tar.gz: 73fadebb9cb5d67dff05d0587f49f3c3d44d04fac5f7410d40919760aedf67fa0c605d15e0a42da34ee33987b73df347d615f001a99be58acefbbc889e0a131a
+  metadata.gz: b3cc34906d28323e88bbf86c336cd278a04ee9565e01631c08fc038f68c57066b4427ba41a6aba0f1c35ca1a462a2f1d47fe1ff613eed02cfdf4760290f2c106
+  data.tar.gz: 694710ae26fc1cc8f59a974c883da5cee4a80e6a0d2cb892f665271a657d187a7592d2a3654ee4acde76c237d70722673bbafcc0e6e54431757bf65e18b25b02

data/CHANGELOG.md

@@ -1,7 +1,12 @@
+1.5.2
+-----
+
+- Threadsafe strategy for the user creation to include the persistence strategy
+
 1.5.1
 -----
 
-- Threadsafe strategy needed to included the persistence strategy
+- Threadsafe strategy for the token refresh to include the persistence strategy
 
 1.5.0
 -----

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    lifen (1.5.1)
+    lifen (1.5.2)
       faraday (>= 0.9)
       inflecto
       virtus (>= 1.0)
@@ -71,4 +71,4 @@ DEPENDENCIES
   webmock (~> 1.24)
 
 BUNDLED WITH
-   1.13.6
+   1.13.7

data/README.md

@@ -54,6 +54,30 @@ other_user.save
 other_user.reload
 ```
 
+### Creating a user in a threadsafe way
+
+Assuming the lifen `uuid` is stored on the `User` model as `lifen_uuid`, you can simply change the `create` method to became threadsafe:
+
+```ruby
+lifen_user.create(
+  persisted_lifen_uuid: ->(internal_user) {
+    user.reload
+
+    current_uuid = user.lifen_uuid
+
+    if current_uuid.blank?
+      nil
+    else
+      current_uuid
+    end
+  },
+  save_to_db: ->(lifen_user) {
+    user.lifen_uuid = lifen_user.uuid
+    user.save!
+  }
+)
+```
+
 ### Managing users' settings
 
 ```ruby

data/lib/lifen/token.rb

@@ -1,7 +1,7 @@
 module Lifen
   class Token
 
-    @@lock = Mutex.new
+    @@refresh_lock = Mutex.new
 
     include Virtus.model(finalize: false)
 
@@ -45,7 +45,7 @@ module Lifen
     end
 
     def refresh_once_if_needed
-      @@lock.synchronize do
+      @@refresh_lock.synchronize do
 
         load_from_db.call(self) if load_from_db.is_a? Proc
 

data/lib/lifen/user.rb

@@ -12,16 +12,35 @@ module Lifen
     attribute :first_name, String
     attribute :profile_picture_url, String
 
+    @@create_lock = Mutex.new
+
     def flows
       Lifen::Flows.new(user: self).all
     end
 
-    def create
+    def create(persisted_lifen_uuid: ->(user) {}, save_to_db: ->(user) {})
+
       params = {emailAddress: email, lastName: last_name, firstName: first_name, profilePicUrl: profile_picture_url}
 
-      json = application_client.post("authentication/api/register/third_party", params)
+      @@create_lock.synchronize do
+
+        exisiting_uuid = persisted_lifen_uuid.call(self)
+
+        if exisiting_uuid.nil?
+
+          json = application_client.post("authentication/api/register/third_party", params)
+
+          self.uuid = json["accountUuid"]
+
+        else
+
+          self.uuid = exisiting_uuid
+
+        end
+
+        save_to_db.call(self)
+      end
 
-      self.uuid = json["accountUuid"]
     end
 
     def self.find(uuid)

data/lib/lifen/version.rb

@@ -1,3 +1,3 @@
 module Lifen
-  VERSION = "1.5.1"
+  VERSION = "1.5.2"
 end

data/spec/token_spec.rb

@@ -94,7 +94,7 @@ describe Lifen::Token do
                           token.expires_at = persisted_user.token_expires_at
                         },
                         save_to_db: ->(token) {
-                          # Loading data from DB
+                          # Saving data to DB
 
                           persisted_user.token_value = token.value
                           persisted_user.token_expires_at = token.expires_at

data/spec/users_spec.rb

@@ -64,6 +64,65 @@ describe Lifen::User do
 
         expect(user.uuid).to_not be_nil
       end
+
+      describe 'thread safe' do
+
+        class PersistedUser < Struct.new(:lifen_uuid) ; end
+
+        let(:storage)                 { double("Storage") }
+
+        let(:marc)                    { Lifen::User.new(email: "existing-user@domain.tld", first_name: "Existing", last_name: "User") }
+        let(:antoine)                 { Lifen::User.new(email: "existing-user@domain.tld", first_name: "Existing", last_name: "Marc") }
+
+        before do
+          allow(storage).to receive(:find_by) do
+            PersistedUser.new(nil)
+          end
+        end
+
+        it 'queues refresh calls' do
+
+          threads = []
+
+          threads << Thread.new do
+            VCR.use_cassette "users/create/valid_attributes" do
+              marc.create(
+                persisted_lifen_uuid: ->(user) {
+                  # Loading data from DB
+                  storage.find_by(email: user.email).lifen_uuid
+                },
+                save_to_db: ->(user) {
+                  # saving data to DB
+
+                  allow(storage).to receive(:find_by) do
+                    PersistedUser.new(user.uuid)
+                  end
+                }
+              )
+            end
+          end
+
+          sleep 0.1 # Making sure the mocked call is received first
+
+          threads << Thread.new do
+
+            # No cassette, should raise an issue if HTTP call is needed
+            antoine.create(
+              persisted_lifen_uuid: ->(user) {
+                # Loading data from DB
+
+                storage.find_by(email: user.email).lifen_uuid
+              }
+            )
+          end
+
+          threads.map { |t| t.join } # waiting for all threads to finish
+        end
+
+      end
+
+
+
     end
 
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lifen
 version: !ruby/object:Gem::Version
-  version: 1.5.1
+  version: 1.5.2
 platform: ruby
 authors:
 - Etienne Depaulis
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-01-12 00:00:00.000000000 Z
+date: 2017-01-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -222,7 +222,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.2
+rubygems_version: 2.6.8
 signing_key: 
 specification_version: 4
 summary: Lifen JSON API ruby client