lifen 1.4.0 → 1.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: dfa27c22c1d17a8d6ac0bae61dc1e1c566bd32e9
-  data.tar.gz: 5986f0073d029ce33c700520824505b9653f2885
+  metadata.gz: 06e6dfcf106062c1fb84355a92286dd8a150adea
+  data.tar.gz: 6ecef6ecc87eeceb42e1a44e693ec061ca7109ac
 SHA512:
-  metadata.gz: 1aa7e611af1d416b2633f5808c1e6ad9454d8a388dc7d2eb93d5e4c779be71b4b5b8c260811de0d1f8dd3a6dfcbea3887f2f4b115c1e021ce329f7928fc4b74c
-  data.tar.gz: 5993c5066b88ce9ca004155b1e879b31da46b76a65334a991a1b388e6d7b2cda606c2b107c5aa8ae3b8af40b1e1a921c2687840cc9c2b8246b3419b689c67e98
+  metadata.gz: a57cb90c9249979d227e2b9a704572609022a280b37f79901dc83382e2331b87c865c5ecd56333bbfa525bdd029e736bfb1f594a01d1af751e8f5a356e79183d
+  data.tar.gz: e7386eb960f36c4fb240c993b4c2251f58bc67ff2cc06d30ceb52576cce4bf0e50914a43b26a0a52709b548defe4876a6e630080e9d0e686615d47401d8441c0

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+1.5.0
+-----
+
+- Added threadsafe strategy when refreshing a token
+
 1.4.0
 -----
 

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    lifen (1.4.0)
+    lifen (1.5.0)
       faraday (>= 0.9)
       inflecto
       virtus (>= 1.0)
@@ -24,7 +24,7 @@ GEM
       thread_safe (~> 0.3, >= 0.3.1)
     diff-lcs (1.2.5)
     equalizer (0.0.11)
-    faraday (0.10.0)
+    faraday (0.10.1)
       multipart-post (>= 1.2, < 3)
     hashdiff (0.3.0)
     ice_nine (0.11.2)

data/README.md

@@ -64,6 +64,21 @@ user.settings.push_notifications = false
 user.settings.save
 ```
 
+### Refreshing a token in a threadsafe way
+
+Depending on the OAuth provider strategy, the token refresh strategy has to be adapted. In our case, if token are stored in a database, you can ask the client to reload the token from your database value before performing a real refresh:
+
+
+```ruby
+token.refresh_once_if_needed do |token|
+  current_user.reload
+
+  token.value = current_user.lifen_token
+  token.expires_at = current_user.lifen_token_expires_at.to_i
+end
+```
+
+
 ### Managing flows
 
 ```ruby

data/lib/lifen/token.rb

@@ -1,5 +1,8 @@
 module Lifen
   class Token
+
+    @@lock = Mutex.new
+
     include Virtus.model(finalize: false)
 
     attribute :user, "Lifen::User"
@@ -39,11 +42,16 @@ module Lifen
     end
 
     def refresh_once_if_needed
-      return if active?
+      @@lock.synchronize do
+
+        yield(self) if block_given?
 
-      refresh
+        return if active?
 
-      raise Error, "Token can't be refreshed" if !active?
+        refresh
+
+        raise Error, "Token can't be refreshed" if !active?
+      end
     end
 
     private

data/lib/lifen/version.rb

@@ -1,3 +1,3 @@
 module Lifen
-  VERSION = "1.4.0"
+  VERSION = "1.5.0"
 end

data/spec/token_spec.rb

@@ -76,4 +76,47 @@ describe Lifen::Token do
 
   end
 
+  describe 'thread safe' do
+
+    let(:user)                    { Lifen::User.new }
+
+    let(:expired_token)           { Lifen::Token.new(user: user, value: "valid_token", expires_at: Time.now.to_i - 60) }
+    let(:other_expired_token)     { Lifen::Token.new(user: user, value: "valid_token", expires_at: Time.now.to_i - 60) }
+
+    before do
+      allow(expired_token).to receive(:refresh) do
+        sleep 1
+        expired_token.expires_at = Time.now.to_i + 60
+      end
+
+      allow(other_expired_token).to receive(:refresh) do
+        sleep 1
+      end
+    end
+
+    it 'queues refresh calls' do
+      expect(expired_token).to receive(:refresh).once
+      expect(other_expired_token).to_not receive(:refresh)
+
+      threads = []
+
+      threads << Thread.new do
+        expired_token.refresh_once_if_needed do |token|
+          token.value = "expired_token"
+          token.expires_at = Time.now.to_i - 60
+        end
+      end
+
+      threads << Thread.new do
+        other_expired_token.refresh_once_if_needed do |token|
+          token.value = "valid_token"
+          token.expires_at = Time.now.to_i + 60
+        end
+      end
+
+      threads.map { |t| t.join } # waiting for all threads to finish
+    end
+
+  end
+
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lifen
 version: !ruby/object:Gem::Version
-  version: 1.4.0
+  version: 1.5.0
 platform: ruby
 authors:
 - Etienne Depaulis
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-12-27 00:00:00.000000000 Z
+date: 2017-01-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler