license-validator 1.4.1 → 1.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d7b2597ec3168a0c77854af16fd64feb8030572e2873f279b5c2a8ce159c8f2c
-  data.tar.gz: 4d6ae05b7f7cfdae3d700f9db92a24b7a5351cf0873362a22e490e0a1ba3ee5e
+  metadata.gz: 21b1222b3a183a38fc79efd31ceb0c0cc8e8156c221f39effb529e40f8f4abb4
+  data.tar.gz: 33581bd7e5b6b0cdf02294585099df33df501e47057fb604195054879b9e3426
 SHA512:
-  metadata.gz: 8235424f2ee7cd9dcdd0149cbea0c53eadee3cb172d4ce4c0f67be8555ad9cfb1f8399ffb034f72f5482b3d69156699ddccfc5273673a3fe70680785fabbec9b
-  data.tar.gz: a665422ab481700ff725b5079bf33046fb4e04a9d835798d37cf660b1aac79526242ce782d4c419284214327b58a7abdde4a6fd2aec455fb5459faed23d14132
+  metadata.gz: 59375de8407d1bbff7b27bc20ccda9c3c5de29946dd8c5d79c24e3bdf5fdcb76a472636ace187e2c549e52c91ab903aa24d1296ac3f3acdd5eda0172fe41c42b
+  data.tar.gz: 65b9afd4e0ea906ccbc05aa2ba418df21bd70774cc07abfe487f8c1599ba5b09971287d27d0a588a166bb6330be8933746d28d4bd19ed58fc226fa3c0a45622c

data/CHANGELOG.adoc

@@ -1,3 +1,10 @@
+== 1.5.0
+
+* Updated MT format
+* Updated NB (CA) format
+* Updated NS (CA) format
+* Updated PE (CA) format
+
 == 1.4.1
 
 * Fix MB license format

data/lib/license-validator.rb

@@ -9,6 +9,8 @@ require_relative 'license_validator/validators'
 require_relative 'license_validator/version'
 
 module LicenseValidator
+  module_function
+
   # Validates the provided driver's DL#
   #
   # @raise [ActiveModel::ValidationError] if driver is invalid
@@ -30,8 +32,6 @@ module LicenseValidator
     return validator.validation_results
   end
 
-  module_function :validate!
-
   private
 
     # Only for development
@@ -60,59 +60,56 @@ module LicenseValidator
       end
     end
 
-    module_function :generate_state_files
-
     # Only for development
     def generate_test_files
       LicenseValidator::States::ABVS.each do |abv|
         test = <<~SPEC
           # frozen_string_literal: true
 
-          state_klass = LicenseValidator::Validations::State#{abv.capitalize}
+          RSpec.describe(LicenseValidator::Validations::State#{abv.capitalize}) do
+            valid_license_nums = %w[123456789 934292912 191919191 894894384 921098585]
+            invalid_license_nums = %w[A11333333 19191919119 1BNS12343 0929292B 02902922A]
+
+            let(:driver) do
+              LicenseValidator::Driver.new({
+                cdl_class: 'A',
+                years_exp: 5,
+                state: state,
+                license_num: license_num,
+                dob: Date.parse('1990-01-01', '%F'),
+                age: 33
+              })
+            end
 
-          module ValidAttributes
-            module State#{abv.capitalize}
-              # @see super
-              def valid_attributes
-                super.map do |valid_attrs|
-                  valid_attrs
-                end
-              end
+            valid_license_nums.each do |valid_num|
+              context "when #\{valid_num}" do
+                let(:license_num) { valid_num }
+
+                it 'does not have an error' do
+                  validator = described_class.new(driver)
+                  validator.validate
 
-              # @see super
-              def invalid_attributes
-                super.map do |invalid_attrs|
-                  invalid_attrs
+                  expect(validator.validation_results.fetch(:errors).blank?).to(be(true))
                 end
               end
+            end
 
-              private
-
-                # @see super
-                def valid_license_nums
-                  %w[AB123456]
-                end
+            invalid_license_nums.each do |invalid_num|
+              context "when #\{invalid_num}" do
+                let(:license_num) { invalid_num }
 
-                # @see super
-                def invalid_license_nums
-                  %w[AB]
-                end
+                it 'does have an error' do
+                  validator = described_class.new(driver)
+                  validator.validate
 
-                # @see super
-                def state
-                  '#{abv}'
+                  expect(validator.validation_results.fetch(:errors).present?).to(be(true))
                 end
+              end
             end
           end
-
-          state_klass.extend(ValidAttributes::State#{abv.capitalize})
-
-          test_klass(state_klass)
         SPEC
 
         File.write("spec/license_validator/validations/state_#{abv.downcase}_spec.rb", test)
       end
     end
-
-    module_function :generate_test_files
 end

data/lib/license_validator/validations/base.rb

@@ -43,6 +43,7 @@ module LicenseValidator
       # Common validations
       def validate
         return if driver.dob.nil?
+        return if driver.age.nil?
 
         age = driver.age
 

data/lib/license_validator/validations/state_mb.rb

@@ -28,8 +28,11 @@ module LicenseValidator
         expected_date_of_birth = (100 - driver.dob.strftime('%y').to_i).to_s.rjust(2, '0')[-2..]
 
         last_name = driver.last_name[0, 5].ljust(5, '*')
+        last_name.gsub!('*', '\\*')
 
+        # rubocop:disable Style/ArrayFirstLast
         first_initial = driver.first_name[0]
+        # rubocop:enable Style/ArrayFirstLast
 
         regex = Regexp.new("\\A#{last_name}#{first_initial}[a-z*]#{expected_date_of_birth}[A-Z0-9]{3}\\z", 'i')
 

data/lib/license_validator/validations/state_mt.rb

@@ -21,21 +21,11 @@ module LicenseValidator
 
         lic_num = driver.license_num
 
-        return if lic_num.match?(/\A[a-z]\d[0-9a-z]\d{2}[a-z]{3}\d\z/i)
-
-        return if lic_num.match?(/\A\d{13}\z/i)
-
-        return if lic_num.match?(/\A[a-z]{3}\d{10}\z/i)
+        return if lic_num.match?(/\A\d{13}[a-z]{3}\d{10}\z/i)
 
         return if lic_num.match?(/\A\d{9}\z/i)
 
-        errors.add(
-          :license_num,
-          [
-            'License number requires 1 alpha, 1 numeric, 1 alphanumeric, 2 numeric, 3 alpha, 1 numeric or 13 numeric',
-            'or 3 alpha, 10 numeric or 9 numeric for MT.'
-          ].join(' ')
-        )
+        errors.add(:license_num, 'License number requires 13 numeric, 3 alpha, 10 numeric or 9 numeric for MT.')
       end
     end
   end

data/lib/license_validator/validations/state_nb.rb

@@ -7,12 +7,12 @@ module LicenseValidator
       def validate
         super
 
-        return if driver.license_num.match?(/\A\d{7}\z/i)
+        return if driver.license_num.match?(/\A\d{1,7}\z/i)
 
         errors.add(
           :license_num,
           [
-            'License number requires 7 numeric',
+            'License number requires 1-7 numeric',
             'for NB'
           ].join(' ')
         )

data/lib/license_validator/validations/state_ns.rb

@@ -7,15 +7,9 @@ module LicenseValidator
       def validate
         super
 
-        return if driver.license_num.match?(/\A[A-Z][A-Z*]{4}\d{9}\z/i)
+        return if driver.license_num.match?(/\A[a-z]{5}\d{9}\z/i)
 
-        errors.add(
-          :license_num,
-          [
-            'License number requires 1 alphabetic, 4 alphabetic or asterisk, and 9 numeric',
-            'for NS'
-          ].join(' ')
-        )
+        errors.add(:license_num, 'License number requires 5 alphabetic, 9 numeric for NS')
       end
     end
   end

data/lib/license_validator/validations/state_pe.rb

@@ -7,15 +7,9 @@ module LicenseValidator
       def validate
         super
 
-        return if driver.license_num.match?(/\A\d{5}\z/i)
+        return if driver.license_num.match?(/\A\d{1,6}\z/i)
 
-        errors.add(
-          :license_num,
-          [
-            'License number requires 5 numeric',
-            'for PE'
-          ].join(' ')
-        )
+        errors.add(:license_num, 'License number requires 1-6 numeric for PE')
       end
     end
   end

data/lib/license_validator/validators.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require 'license_validator/validations/base'
+
 Dir[File.expand_path('validations/*.rb', __dir__)].sort.each do |filename|
   require filename
 end

data/lib/license_validator/version.rb

@@ -1,5 +1,19 @@
 # frozen_string_literal: true
 
 module LicenseValidator
-  VERSION = '1.4.1'
+  module VERSION
+    MAJOR = 1
+    MINOR = 5
+    TINY = 0
+
+    # Set PRE to nil unless it's a pre-release (beta, rc, etc.)
+    PRE = nil
+
+    STRING = [MAJOR, MINOR, TINY, PRE].compact.join('.').freeze
+
+    # @return [String]
+    def self.to_s
+      STRING
+    end
+  end
 end

metadata

@@ -1,29 +1,35 @@
 --- !ruby/object:Gem::Specification
 name: license-validator
 version: !ruby/object:Gem::Version
-  version: 1.4.1
+  version: 1.5.0
 platform: ruby
 authors:
 - Brands Insurance
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2025-06-25 00:00:00.000000000 Z
+date: 2025-07-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: rubocop-rubomatic
+  name: activemodel
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.3.0
-  type: :development
+        version: 6.0.3.6
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '7.1'
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 6.0.3.6
+    - - "<"
       - !ruby/object:Gem::Version
-        version: 1.3.0
+        version: '7.1'
 - !ruby/object:Gem::Dependency
   name: concurrent-ruby
   requirement: !ruby/object:Gem::Requirement
@@ -44,26 +50,6 @@ dependencies:
     - - "<"
       - !ruby/object:Gem::Version
         version: 1.3.4
-- !ruby/object:Gem::Dependency
-  name: activemodel
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 6.0.3.6
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '7.1'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 6.0.3.6
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '7.1'
 description:
 email:
 - documents@brandsinsurance.com
@@ -144,7 +130,6 @@ files:
 - lib/license_validator/validations/state_yt.rb
 - lib/license_validator/validators.rb
 - lib/license_validator/version.rb
-- lib/tasks/generator.rake
 homepage: https://github.com/brandsinsurance/license-validator/
 licenses:
 - MIT

data/lib/tasks/generator.rake

@@ -1,74 +0,0 @@
-namespace :generate do
-  desc "Generate blank state and spec files. Usage: rake generate:state[al]"
-  task :state, [:state] do |t, args|
-    require 'erb'
-
-    state = args[:state]
-    raise "Please supply a state argument" unless state
-
-    state_title = state.capitalize
-    state_upcase = state.upcase
-
-    state_rb = <<~RUBY
-      # frozen_string_literal: true
-
-      module LicenseValidator
-        module Validations
-          class State#{state_title} < LicenseValidator::Validations::Base
-            # @see super
-            def validate
-              super
-
-              errors.add(
-                :license_num,
-                [
-                  '',
-                  'for #{state_upcase}'
-                ].join(' ')
-              )
-            end
-          end
-        end
-      end
-    RUBY
-
-    spec_rb = <<~RUBY
-      # frozen_string_literal: true
-
-      state_klass = LicenseValidator::Validations::State#{state_title}
-
-      module ValidAttributes
-        module State#{state_title}
-          private
-
-            # @see super
-            def valid_license_nums
-              %w[
-
-              ]
-            end
-
-            # @see super
-            def invalid_license_nums
-              %w[
-
-              ]
-            end
-
-            # @see super
-            def state
-              '#{state_upcase}'
-            end
-        end
-      end
-
-      state_klass.extend(ValidAttributes::State#{state_title})
-
-      test_klass(state_klass)
-    RUBY
-
-    File.write("lib/license_validator/validations/state_#{state.downcase}.rb", state_rb)
-    File.write("spec/license_validator/validations/state_#{state.downcase}_spec.rb", spec_rb)
-    puts "Generated files for #{state_upcase}"
-  end
-end