libyear 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6a61e98fbfc381e1f538564dedc9aeb88f42e2de
-  data.tar.gz: 49136eaae5901712cbab43d2cb837bb1e2feb2bd
+  metadata.gz: 10b6af767f2c311397eb8cacc3411ed2faf23a70
+  data.tar.gz: 46b24478fedc3efac195e8916389e64db44b269f
 SHA512:
-  metadata.gz: 5fc9cf229c5b2a4e3a6ec4670657d6687e560227f03a20677caa2983e410d9fd58daf4639aeb66b04ab02592e6bdc9e35c6920106b64870701d3e9198348f639
-  data.tar.gz: dee7f5ee73bd7e70f92e92fd8efcf585dfb13e65aaa099a5bfb7a9af760833e3ad53d3efdff663ca2dadbb89761b1218b23fc41e4ee16eaebf9ceebd08e3fa12
+  metadata.gz: 568702d22168ad898e48ba88896cbf4f2ba8925549f71baff495342253659af432c39c9913d64480c9dab4f115ebd1bd4255972305279150d72df8cfc7589883
+  data.tar.gz: 45a0b87b0ba1c0e3d84e64e6ec1320d090c882f0de4e7ad195b982b99f8044e0aff42fdf02136d21f5882142a18e74f725f2fe8fee0a704080d66abd71fda18f

data/CHANGELOG.md

@@ -1,5 +1,25 @@
 # libyear
 
-## 0.0.1 (2017-02-13)
+This project follows [semver 2.0.0][1] and the recommendations
+of [keepachangelog.com][2].
+
+## 0.1.1 (2017-02-14)
+
+Breaking changes:
+
+- None
+
+Added:
+
+- None
+
+Fixed:
+
+- Better handling of error when bundle outdated fails
+
+## 0.1.0 (2017-02-13)
 
 Initial version. Proof of concept.
+
+[1]: http://semver.org/spec/v2.0.0.html
+[2]: http://keepachangelog.com/

data/lib/libyear/cli.rb

@@ -1,76 +1,21 @@
 require "bundler/cli"
 require "bundler/cli/outdated"
+require "libyear/report"
+require "libyear/query"
 
 module Libyear
   class CLI
-    # Format of `bundle outdated --parseable` (BOP)
-    BOP_FMT = /\A(?<name>[^ ]+) \(newest (?<newest>[^,]+), installed (?<installed>[^,)]+)/
-
     def initialize(argv)
       validate_arguments(argv)
       @gemfile_path = argv.first
     end
 
     def run
-      parseable = `BUNDLE_GEMFILE="#{@gemfile_path}" bundle outdated --parseable`
-      gems = []
-      parseable.lines.each do |line|
-        match = BOP_FMT.match(line)
-        next if match.nil?
-        gems.push(
-          installed: { version: match["installed"] },
-          name: match["name"],
-          newest: { version: match["newest"] }
-        )
-      end
-      gems.each do |gem|
-        gem[:installed][:date] = release_date(gem[:name], gem[:installed][:version])
-        gem[:newest][:date] = release_date(gem[:name], gem[:newest][:version])
-      end
-      report(gems)
+      print Report.new(Query.new(@gemfile_path).execute).to_s
     end
 
     private
 
-    # Known issue: Probably performs a network request every time, unless
-    # there's some kind of caching.
-    def release_date(gem_name, gem_version)
-      dep = ::Bundler::Dependency.new(gem_name, gem_version)
-      tuples, _errors = ::Gem::SpecFetcher.fetcher.search_for_dependency(dep)
-      tup, source = tuples.first # Gem::NameTuple
-      spec = source.fetch_spec(tup) # raises Gem::RemoteFetcher::FetchError
-      spec.date.to_date
-    end
-
-    def report(gems)
-      sum_years = 0.0
-      gems.each do |gem|
-        di = gem[:installed][:date]
-        dn = gem[:newest][:date]
-        if dn <= di
-          # Known issue: Backports and maintenance releases of older minor versions.
-          # Example: json 1.8.6 (2017-01-13) was released *after* 2.0.3 (2017-01-12)
-          years = 0.0
-        else
-          days = (dn - di).to_f
-          years = days / 365.0
-        end
-        sum_years += years
-        puts(
-          format(
-            "%20s%10s%15s%10s%15s%10.1f",
-            gem[:name],
-            gem[:installed][:version],
-            di,
-            gem[:newest][:version],
-            dn,
-            years
-          )
-        )
-      end
-      puts format("System is %.1f libyears behind", sum_years)
-    end
-
     def validate_arguments(argv)
       # todo
     end

data/lib/libyear/query.rb

@@ -0,0 +1,73 @@
+require "English"
+require "open3"
+
+module Libyear
+  # Responsible for getting all the data that goes into the `Report`.
+  class Query
+    # Format of `bundle outdated --parseable` (BOP)
+    BOP_FMT = /\A(?<name>[^ ]+) \(newest (?<newest>[^,]+), installed (?<installed>[^,)]+)/
+
+    def initialize(gemfile_path)
+      @gemfile_path = gemfile_path
+    end
+
+    def execute
+      gems = []
+      bundle_outdated.lines.each do |line|
+        match = BOP_FMT.match(line)
+        next if match.nil?
+        gems.push(
+          installed: { version: match["installed"] },
+          name: match["name"],
+          newest: { version: match["newest"] }
+        )
+      end
+      gems.each do |gem|
+        di = release_date(gem[:name], gem[:installed][:version])
+        dn = release_date(gem[:name], gem[:newest][:version])
+        if dn <= di
+          # Known issue: Backports and maintenance releases of older minor versions.
+          # Example: json 1.8.6 (2017-01-13) was released *after* 2.0.3 (2017-01-12)
+          years = 0.0
+        else
+          days = (dn - di).to_f
+          years = days / 365.0
+        end
+        gem[:installed][:date] = di
+        gem[:newest][:date] = dn
+        gem[:libyears] = years
+      end
+      gems
+    end
+
+    private
+
+    def bundle_outdated
+      stdout, stderr, status = Open3.capture3(
+        %Q(BUNDLE_GEMFILE="#{@gemfile_path}" bundle outdated --parseable)
+      )
+      # Known statuses:
+      # 0 - Nothing is outdated
+      # 256 - Something is outdated
+      # 1792 - Unable to determine if something is outdated
+      unless [0, 256].include?(status.to_i)
+        $stderr.puts "`bundle outdated` failed with status: #{status.to_i}"
+        $stderr.puts "stderr: #{stderr}"
+        $stderr.puts "stdout: #{stdout}"
+        $stderr.puts "Try running `bundle install`."
+        Kernel.exit(1)
+      end
+      stdout
+    end
+
+    # Known issue: Probably performs a network request every time, unless
+    # there's some kind of caching.
+    def release_date(gem_name, gem_version)
+      dep = ::Bundler::Dependency.new(gem_name, gem_version)
+      tuples, _errors = ::Gem::SpecFetcher.fetcher.search_for_dependency(dep)
+      tup, source = tuples.first # Gem::NameTuple
+      spec = source.fetch_spec(tup) # raises Gem::RemoteFetcher::FetchError
+      spec.date.to_date
+    end
+  end
+end

data/lib/libyear/report.rb

@@ -0,0 +1,30 @@
+module Libyear
+  # Responsible presenting data from the `Query`. Should only be concerned
+  # with presentation, nothing else.
+  class Report
+    # `gems` - Array of hashes.
+    def initialize(gems)
+      @gems = gems
+    end
+
+    def to_s
+      sum_years = 0.0
+      @gems.each do |gem|
+        years = gem[:libyears]
+        sum_years += years
+        puts(
+          format(
+            "%20s%10s%15s%10s%15s%10.1f",
+            gem[:name],
+            gem[:installed][:version],
+            gem[:installed][:date],
+            gem[:newest][:version],
+            gem[:newest][:date],
+            years
+          )
+        )
+      end
+      puts format("System is %.1f libyears behind", sum_years)
+    end
+  end
+end

data/lib/libyear/version.rb

@@ -1,3 +1,3 @@
 module Libyear
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: libyear
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Jared Beck
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-02-13 00:00:00.000000000 Z
+date: 2017-02-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -57,6 +57,8 @@ files:
 - bin/setup
 - lib/libyear.rb
 - lib/libyear/cli.rb
+- lib/libyear/query.rb
+- lib/libyear/report.rb
 - lib/libyear/version.rb
 - libyear.gemspec
 homepage: https://libyear.com