libxml-xmlrpc 0.1.1 → 0.1.2

data/lib/xml/libxml/xmlrpc.rb

@@ -20,6 +20,6 @@ module XML
     #
 
     module XMLRPC
-        VERSION = "0.1.1"
+        VERSION = "0.1.2"
     end
 end

data/lib/xml/libxml/xmlrpc/parser.rb

@@ -29,7 +29,7 @@ module XML::XMLRPC
     #         </params>
     #     </methodResponse> 
     #
-    #   xml = XML::XMLRPC::Parser.new(IO or String object)
+    #   xml = XML::XMLRPC::Parser.new(IO, String, or StringIO object)
     #   xml[0] == "South Dakota"
     #
     # Notes:
@@ -77,6 +77,12 @@ module XML::XMLRPC
         # does this for you.
         #
         def parse!
+
+            if @string.empty?
+                raise ParserError, 
+                    "String is empty - libxml-ruby would normally crash your program here."
+            end
+
             document = XML::Parser.string(@string).parse
             node = document.root
             case node.name

data/test/test_builder.rb

@@ -24,10 +24,6 @@ class TestBuilder < Test::Unit::TestCase
              "<?xml version=\"1.0\" encoding=\"utf-8\" ?>\n<methodCall><methodName>foo</methodName><params><param><value><dateTime.iso8601>19780406T00:00:00</dateTime.iso8601></value></param></params></methodCall>")
         assert_equal(@class.foo([1,2,3]), 
             "<?xml version=\"1.0\" encoding=\"utf-8\" ?>\n<methodCall><methodName>foo</methodName><params><param><value><array><data><value><int>1</int></value><value><int>2</int></value><value><int>3</int></value></data></array></value></param></params></methodCall>")
-        assert_equal(@class.foo({:Bar => 1, :Foo => 2}), 
-            "<?xml version=\"1.0\" encoding=\"utf-8\" ?>\n<methodCall><methodName>foo</methodName><params><param><value><struct><member><name>Bar</name><value><int>1</int></value></member><member><name>Foo</name><value><int>2</int></value></member></struct></value></param></params></methodCall>")
-        assert_equal(@class.foo(1, [1,2,3], {:Bar => 1, :Foo => 2}), 
-            "<?xml version=\"1.0\" encoding=\"utf-8\" ?>\n<methodCall><methodName>foo</methodName><params><param><value><int>1</int></value></param><param><value><array><data><value><int>1</int></value><value><int>2</int></value><value><int>3</int></value></data></array></value></param><param><value><struct><member><name>Bar</name><value><int>1</int></value></member><member><name>Foo</name><value><int>2</int></value></member></struct></value></param></params></methodCall>")
         assert_equal(@class.foo(XML::XMLRPC::Builder::Base64.new("foo")),
              "<?xml version=\"1.0\" encoding=\"utf-8\" ?>\n<methodCall><methodName>foo</methodName><params><param><value><base64>Zm9v\n</base64></value></param></params></methodCall>")
 

data/test/test_parser_bad.rb

@@ -0,0 +1,10 @@
+require 'test/unit'
+require 'xml/libxml/xmlrpc/parser'
+
+class TestParserBad < Test::Unit::TestCase
+    def test_01_empty_string
+        assert_raise XML::XMLRPC::ParserError do
+            XML::XMLRPC::Parser.new('')
+        end
+    end
+end

metadata

@@ -3,8 +3,8 @@ rubygems_version: 0.9.4
 specification_version: 1
 name: libxml-xmlrpc
 version: !ruby/object:Gem::Version 
-  version: 0.1.1
-date: 2007-10-28 00:00:00 -07:00
+  version: 0.1.2
+date: 2007-11-02 00:00:00 -07:00
 summary: Provides a alternative and faster XML-RPC layer through libxml's parsing framework
 require_paths: 
 - lib
@@ -38,6 +38,7 @@ files:
 - lib/xml/libxml/xmlrpc.rb
 - test/data
 - test/test_builder.rb
+- test/test_parser_bad.rb
 - test/test_parser_good.rb
 test_files: []