libv8 3.16.14.1 → 3.16.14.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3c94f6bf7d81e063546495f95ad8429e53eb49b9
-  data.tar.gz: 2aab4685381c41918d7399da86456fd2afc82890
+  metadata.gz: a09c42a6b6acd0ce05c59b19ab960857efd13c54
+  data.tar.gz: 1c4cf9ec1a7788d23ed4faddbae4860d6e6bbd06
 SHA512:
-  metadata.gz: be102c9010f2a69e1bc9533d160bc4d907800d63e6f5aa3a03d2d76dc39ad03deb12a0928a5e2ad257c486181cc2d632c98a4491aca345b525e4f3c03870387a
-  data.tar.gz: 2fb7d97915e89f999b56fb2a04ebc84792211f94ceaf7f02cd707705cc2c2b9fa219f3fada612f53dd0bc833d39728c8786e16490d5142c64cdd56e3005a6b05
+  metadata.gz: a1b3e27bd9939686b3efa66d20996b70b2c7f5e1931678adb6e0a387320ac59b2a8ed835a7348f31b92319052a6410bc9c5ca5824086b746c3a399922a532a9b
+  data.tar.gz: 5184f45d4b2f6ac025614371bd43498577d6dfe6e6429c6a22ce6dc54839b35e05ed2fd6a1007e2558a6f8b226587020a5e058e36dac9ee5ec34cc529f6b74ee

data/.gitmodules

@@ -1,3 +1,6 @@
 [submodule "vendor/v8"]
 	path = vendor/v8
 	url = https://github.com/v8/v8.git
+[submodule "vendor/gyp"]
+	path = vendor/gyp
+	url = https://git.chromium.org/git/external/gyp.git

data/.travis.yml

@@ -8,4 +8,5 @@ notifications:
     - cowboyd@thefrontside.net
     - bordjukov@gmail.com
 before_install:
-  - sudo apt-get install subversion
+  - sudo apt-get update
+  - sudo apt-get install git-svn

data/README.md

@@ -38,6 +38,19 @@ own point release after the main v8 version. So libv8 `3.11.8.5` and
 think about it would be that `3.11.8.14` is the 14th release of the
 libv8 rubygem based on v8 version `3.11.8`
 
+### Using a git version
+
+If you want to use the latest unstable version of the gem you can do
+so by specifying the git repo as a gem source. Just add the following
+to your `Gemfile`:
+
+```Ruby
+gem "libv8", git: "git://github.com/cowboyd/libv8.git", submodules: true
+```
+
+You can find more info on using a git repo as a gem source in
+[Bundler's documentation](http://bundler.io/v1.3/git.html).
+
 #### Source and Binary Releases
 
 Starting with libv8 `3.11.8.0`, all even point releases contain

data/Rakefile

@@ -9,20 +9,15 @@ end
 require 'rspec/core/rake_task'
 RSpec::Core::RakeTask.new(:spec)
 
-V8_Version = Libv8::VERSION.gsub(/\.\d+$/,'')
-V8_Source = File.expand_path '../vendor/v8', __FILE__
-
 require File.expand_path '../ext/libv8/make.rb', __FILE__
+require File.expand_path '../ext/libv8/checkout.rb', __FILE__
 include Libv8::Make
+include Libv8::Checkout
 
-desc "setup the vendored v8 source to correspond to the libv8 gem version and prepare deps"
+desc "setup the vendored v8 source to correspond to the libv8 gem version"
 task :checkout do
   sh "git submodule update --init"
-  Dir.chdir(V8_Source) do
-    sh "git fetch"
-    sh "git checkout #{V8_Version} -f"
-    sh "#{make} dependencies"
-  end
+  checkout!
 end
 
 desc "compile v8 via the ruby extension mechanism"
@@ -30,7 +25,6 @@ task :compile do
   sh "ruby ext/libv8/extconf.rb"
 end
 
-
 desc "manually invoke the GYP compile. Useful for seeing debug output"
 task :manual_compile do
   require File.expand_path '../ext/libv8/arch.rb', __FILE__
@@ -67,7 +61,7 @@ task :binary => :compile do
   FileUtils.chmod 'a+r', gemspec.files
   FileUtils.mkdir_p 'pkg'
   package = if Gem::VERSION < '2.0.0'
-    Gem::Builder.new(gempsec).build
+    Gem::Builder.new(gemspec).build
   else
     require 'rubygems/package'
     Gem::Package.build(gemspec)
@@ -80,6 +74,7 @@ task :clean do
   sh "rm -rf pkg"
   sh "git clean -df"
   sh "cd #{V8_Source} && git checkout -f && git clean -dxf"
+  sh "cd #{GYP_Source} && git checkout -f && git clean -dxf"
 end
 
 desc "build a binary on heroku (you must have vulcan configured for this)"

data/ext/libv8/arch.rb

@@ -30,7 +30,7 @@ module Libv8
     end
 
     def arm?
-      RbConfig::MAKEFILE_CONFIG['build_cpu'] == 'arm'
+      RbConfig::MAKEFILE_CONFIG['build_cpu'] =~ /^arm/
     end
 
     def libv8_arch

data/ext/libv8/builder.rb

@@ -2,12 +2,14 @@ require 'mkmf'
 require File.expand_path '../compiler', __FILE__
 require File.expand_path '../arch', __FILE__
 require File.expand_path '../make', __FILE__
+require File.expand_path '../checkout', __FILE__
 
 module Libv8
   class Builder
     include Libv8::Arch
     include Libv8::Compiler
     include Libv8::Make
+    include Libv8::Checkout
 
     def make_flags(*flags)
       profile = enable_config('debug') ? 'debug' : 'release'
@@ -20,19 +22,26 @@ module Libv8
       # Avoid compilation failures on the Raspberry Pi.
       flags << "vfp2=off vfp3=off" if RUBY_PLATFORM.include? "arm"
 
-      # Enable hardfloat support if available.
-      flags << "hardfp=on" if RUBY_PLATFORM.include? "eabihf"
+      # FIXME: Determine when to activate this instead of leaving it on by
+      # default.
+      flags << "hardfp=on" if RUBY_PLATFORM.include? "arm"
 
       # Fix Malformed archive issue caused by GYP creating thin archives by
       # default.
       flags << "ARFLAGS.target=crs"
 
+      # Solaris / Smart OS requires additional -G flag to use with -fPIC
+      flags << "CFLAGS=-G" if RUBY_PLATFORM =~ /solaris/
+
       "#{libv8_arch}.#{profile} #{flags.join ' '}"
     end
 
     def build_libv8!
-      Dir.chdir(File.expand_path '../../../vendor/v8', __FILE__) do
+      Dir.chdir(V8_Source) do
+        checkout!
         setup_python!
+        setup_build_deps!
+        apply_patches!
         print_build_info
         puts `env CXX=#{compiler} LINK=#{compiler} #{make} #{make_flags}`
       end
@@ -53,6 +62,25 @@ module Libv8
       end
     end
 
+    def setup_build_deps!
+      # This uses the Git mirror of the svn repository used by
+      # "make dependencies", instead of calling that make target
+      `rm -rf build/gyp`
+      `ln -fs #{GYP_Source} build/gyp`
+    end
+
+    def apply_patches!
+      File.open(".applied_patches", File::RDWR|File::CREAT) do |f|
+        available_patches = Dir.glob(File.expand_path '../../../patches/*.patch', __FILE__).sort
+        applied_patches = f.readlines.map(&:chomp)
+
+        (available_patches - applied_patches).each do |patch|
+          `patch -p1 -N < #{patch}`
+          f.puts patch
+        end
+      end
+    end
+
     private
 
     def python_version

data/ext/libv8/checkout.rb

@@ -0,0 +1,48 @@
+require File.expand_path '../../../lib/libv8/version.rb', __FILE__
+
+module Libv8
+  module Checkout
+    module_function
+
+    GYP_SVN = 'http://gyp.googlecode.com/svn'
+    V8_Source = File.expand_path '../../../vendor/v8', __FILE__
+    GYP_Source = File.expand_path '../../../vendor/gyp', __FILE__
+
+    def checkout!
+      # When compiling from a source gem, it's not a git repository anymore and
+      # we assume the right code is already checked out.
+      return unless git?(V8_Source)
+
+      Dir.chdir(V8_Source) do
+        `git fetch`
+        `git checkout #{Libv8::VERSION.gsub(/\.\d+$/,'')} -f`
+        `rm -f .applied_patches`
+      end
+
+      return unless git?(GYP_Source)
+
+      check_git_svn!
+
+      Dir.chdir(GYP_Source) do
+        mkf = File.readlines(File.join(V8_Source, 'Makefile'))
+        idx = mkf.index {|l| l =~ /#{GYP_SVN}/} + 1
+        rev = /--revision (\d+)/.match(mkf[idx])[1]
+        `git fetch`
+        # --git-dir is needed for older versions of git and git-svn
+        `git --git-dir=../../.git/modules/vendor/gyp/ svn init #{GYP_SVN} -Ttrunk`
+        `git config --replace-all svn-remote.svn.fetch trunk:refs/remotes/origin/master`
+        `git checkout $(git --git-dir=../../.git/modules/vendor/gyp/ svn find-rev r#{rev} | tail -n 1) -f`
+      end
+    end
+
+    def git?(dir)
+      File.exists?(File.join(dir, '.git'))
+    end
+
+    def check_git_svn!
+      unless system 'git help svn 2>&1 > /dev/null'
+        fail "git-svn not installed!\nPlease install git-svn."
+      end
+    end
+  end
+end

data/ext/libv8/compiler.rb

@@ -4,7 +4,9 @@ module Libv8
 
     def compiler
       unless defined?(@compiler)
-        cc   = check_gcc_compiler "g++"
+        cc   = check_gcc_compiler with_config("cxx")
+        cc ||= check_gcc_compiler ENV["CXX"]
+        cc ||= check_gcc_compiler "g++"
 
         # Check alternative GCC names
         # These are common on BSD's after
@@ -26,6 +28,9 @@ module Libv8
     end
 
     def check_gcc_compiler(name)
+      # in SmartOS, `which` returns success with no arguments. 'with_config' above may return nil
+      return nil if "#{name}".empty?
+
       compiler = `which #{name} 2> /dev/null`
       return nil unless $?.success?
 

data/lib/libv8/version.rb

@@ -1,3 +1,3 @@
 module Libv8
-  VERSION = "3.16.14.1"
+  VERSION = "3.16.14.2"
 end

data/libv8.gemspec

@@ -21,6 +21,9 @@ Gem::Specification.new do |s|
     `git ls-files`.split("\n").reject {|f| f =~ /^out/}.map {|f| "vendor/v8/#{f}"}
   end
   s.files += Dir['vendor/v8/build/**/*']
+  s.files += Dir.chdir("vendor/gyp") do
+    `git ls-files`.split("\n").map {|f| "vendor/gyp/#{f}"}
+  end
 
   s.extensions = ["ext/libv8/extconf.rb"]
   s.require_paths = ["lib", "ext"]

data/patches/disable-building-tests.patch

@@ -0,0 +1,25 @@
+diff --git a/Makefile b/Makefile
+index 0cdae4b..2bf8aa5 100644
+--- a/Makefile
++++ b/Makefile
+@@ -153,7 +153,7 @@ ANDROID_ARCHES = android_ia32 android_arm
+ # List of files that trigger Makefile regeneration:
+ GYPFILES = build/all.gyp build/common.gypi build/standalone.gypi \
+            preparser/preparser.gyp samples/samples.gyp src/d8.gyp \
+-           test/cctest/cctest.gyp tools/gyp/v8.gyp
++           tools/gyp/v8.gyp
+ 
+ # Generates all combinations of ARCHES and MODES, e.g. "ia32.release".
+ BUILDS = $(foreach mode,$(MODES),$(addsuffix .$(mode),$(ARCHES)))
+diff --git a/build/all.gyp b/build/all.gyp
+index 4b2fe52..9885678 100644
+--- a/build/all.gyp
++++ b/build/all.gyp
+@@ -11,7 +11,6 @@
+         '../preparser/preparser.gyp:*',
+         '../samples/samples.gyp:*',
+         '../src/d8.gyp:d8',
+-        '../test/cctest/cctest.gyp:*',
+       ],
+     }
+   ]

data/patches/do-not-imply-vfp3-and-armv7.patch

@@ -0,0 +1,28 @@
+diff --git a/build/common.gypi b/build/common.gypi
+index 3a59639..594abe4 100644
+--- a/build/common.gypi
++++ b/build/common.gypi
+@@ -173,7 +173,6 @@
+           [ 'v8_use_arm_eabi_hardfloat=="true"', {
+             'defines': [
+               'USE_EABI_HARDFLOAT=1',
+-              'CAN_USE_VFP2_INSTRUCTIONS',
+             ],
+             'target_conditions': [
+               ['_toolset=="target"', {
+diff --git a/build/standalone.gypi b/build/standalone.gypi
+index 125c5bf..9900c5b 100644
+--- a/build/standalone.gypi
++++ b/build/standalone.gypi
+@@ -77,9 +77,9 @@
+       }],
+     ],
+     # Default ARM variable settings.
+-    'armv7%': 1,
++    'armv7%': 0,
+     'arm_neon%': 0,
+-    'arm_fpu%': 'vfpv3',
++    'arm_fpu%': 'vfp',
+   },
+   'target_defaults': {
+     'default_configuration': 'Debug',

data/patches/fPIC-for-static.patch

@@ -0,0 +1,13 @@
+diff --git a/build/standalone.gypi b/build/standalone.gypi
+index 125c5bf..71641a3 100644
+--- a/build/standalone.gypi
++++ b/build/standalone.gypi
+@@ -107,7 +107,7 @@
+           [ 'visibility=="hidden" and v8_enable_backtrace==0', {
+             'cflags': [ '-fvisibility=hidden' ],
+           }],
+-          [ 'component=="shared_library"', {
++          [ 'component=="shared_library" or component=="static_library" and v8_target_arch=="x64"', {
+             'cflags': [ '-fPIC', ],
+           }],
+         ],

data/patches/gcc48-wno-unused-local-typedefs.patch

@@ -0,0 +1,28 @@
+diff --git a/build/common.gypi b/build/common.gypi
+index 3a59639..365178a 100644
+--- a/build/common.gypi
++++ b/build/common.gypi
+@@ -376,7 +376,8 @@
+           }],
+           ['OS=="linux" or OS=="freebsd" or OS=="openbsd" or OS=="netbsd"', {
+             'cflags': [ '-Wall', '<(werror)', '-W', '-Wno-unused-parameter',
+-                        '-Wnon-virtual-dtor', '-Woverloaded-virtual' ],
++                        '-Wnon-virtual-dtor', '-Woverloaded-virtual',
++                        '-Wno-unused-local-typedefs' ],
+           }],
+           ['OS=="linux" and v8_enable_backtrace==1', {
+             # Support for backtrace_symbols.
+diff --git a/build/standalone.gypi b/build/standalone.gypi
+index 125c5bf..32eaf85 100644
+--- a/build/standalone.gypi
++++ b/build/standalone.gypi
+@@ -98,7 +98,8 @@
+       'target_defaults': {
+         'cflags': [ '-Wall', '<(werror)', '-W', '-Wno-unused-parameter',
+                     '-Wnon-virtual-dtor', '-pthread', '-fno-rtti',
+-                    '-fno-exceptions', '-pedantic' ],
++                    '-fno-exceptions', '-pedantic',
++                    '-Wno-unused-local-typedefs' ],
+         'ldflags': [ '-pthread', ],
+         'conditions': [
+           [ 'OS=="linux"', {

data/spec/location_spec.rb

@@ -2,7 +2,7 @@ require 'spec_helper'
 
 describe "libv8 locations" do
   before do
-    @context = mock(:CompilationContext)
+    @context = double(:CompilationContext)
   end
   describe "the system location" do
     before do
@@ -15,8 +15,8 @@ describe "libv8 locations" do
         @location.configure @context
       end
       it "adds the include path to the front of the include flags" do
-        @context.should have_received(:dir_config).with 'v8'
-        @context.should have_received(:find_header).with 'v8.h'
+        @context.should have_received(:dir_config).with('v8').at_least(:once)
+        @context.should have_received(:find_header).with('v8.h').at_least(:once)
       end
     end
     describe "when the v8.h header cannot be found" do

data/vendor/gyp/.gitignore

@@ -0,0 +1 @@
+*.pyc

data/vendor/gyp/AUTHORS

@@ -0,0 +1,6 @@
+# Names should be added to this file like so:
+# Name or Organization <email address>
+
+Google Inc.
+Steven Knight <knight@baldmt.com>
+Ryan Norton <rnorton10@gmail.com>

data/vendor/gyp/DEPS

@@ -0,0 +1,26 @@
+# DEPS file for gclient use in buildbot execution of gyp tests.
+#
+# (You don't need to use gclient for normal GYP development work.)
+
+vars = {
+  "chrome_trunk": "http://src.chromium.org/svn/trunk",
+  "googlecode_url": "http://%s.googlecode.com/svn",
+}
+
+deps = {
+  "scons":
+    Var("chrome_trunk") + "/src/third_party/scons@44099",
+}
+
+deps_os = {
+  "win": {
+    "third_party/cygwin":
+      Var("chrome_trunk") + "/deps/third_party/cygwin@66844",
+
+    "third_party/python_26":
+      Var("chrome_trunk") + "/tools/third_party/python_26@89111",
+
+    "src/third_party/pefile":
+      (Var("googlecode_url") % "pefile") + "/trunk@63",
+  },
+}

data/vendor/gyp/LICENSE

@@ -0,0 +1,27 @@
+Copyright (c) 2009 Google Inc. All rights reserved.
+
+Redistribution and use in source and binary forms, with or without
+modification, are permitted provided that the following conditions are
+met:
+
+   * Redistributions of source code must retain the above copyright
+notice, this list of conditions and the following disclaimer.
+   * Redistributions in binary form must reproduce the above
+copyright notice, this list of conditions and the following disclaimer
+in the documentation and/or other materials provided with the
+distribution.
+   * Neither the name of Google Inc. nor the names of its
+contributors may be used to endorse or promote products derived from
+this software without specific prior written permission.
+
+THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+"AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.