libv8 6.3.292.48.1 → 6.7.288.46.0

data/vendor/depot_tools/recipes/recipe_modules/gclient/examples/full.expected/tryserver.json

@@ -6,10 +6,12 @@
       "RECIPE_PACKAGE_REPO[depot_tools]/gclient.py",
       "config",
       "--spec",
-      "cache_dir = '[ROOT]/git_cache'\nsolutions = [{'deps_file': '.DEPS.git', 'managed': True, 'name': 'src', 'url': 'https://chromium.googlesource.com/chromium/src.git'}]"
+      "cache_dir = '[ROOT]/git_cache'\nsolutions = [{'custom_vars': {'string_var': 'string_val', 'true_var': True}, 'deps_file': '.DEPS.git', 'managed': True, 'name': 'src', 'url': 'https://chromium.googlesource.com/chromium/src.git'}]"
     ],
-    "env": {
-      "PATH": "<PATH>:RECIPE_PACKAGE_REPO[depot_tools]"
+    "env_suffixes": {
+      "PATH": [
+        "RECIPE_PACKAGE_REPO[depot_tools]"
+      ]
     },
     "infra_step": true,
     "name": "gclient setup"
@@ -30,13 +32,13 @@
       "--with_branch_heads",
       "--with_tags",
       "--delete_unversioned_trees",
-      "--revision",
-      "src@HEAD",
       "--output-json",
       "/path/to/tmp/json"
     ],
-    "env": {
-      "PATH": "<PATH>:RECIPE_PACKAGE_REPO[depot_tools]"
+    "env_suffixes": {
+      "PATH": [
+        "RECIPE_PACKAGE_REPO[depot_tools]"
+      ]
     },
     "infra_step": true,
     "name": "gclient sync",
@@ -62,8 +64,10 @@
       "user.name",
       "local_bot"
     ],
-    "env": {
-      "PATH": "<PATH>:RECIPE_PACKAGE_REPO[depot_tools]"
+    "env_suffixes": {
+      "PATH": [
+        "RECIPE_PACKAGE_REPO[depot_tools]"
+      ]
     },
     "infra_step": true,
     "name": "gclient recurse (git config user.name)"
@@ -79,8 +83,10 @@
       "user.email",
       "local_bot@example.com"
     ],
-    "env": {
-      "PATH": "<PATH>:RECIPE_PACKAGE_REPO[depot_tools]"
+    "env_suffixes": {
+      "PATH": [
+        "RECIPE_PACKAGE_REPO[depot_tools]"
+      ]
     },
     "infra_step": true,
     "name": "gclient recurse (git config user.email)"
@@ -95,8 +101,10 @@
       "cache_dir = '[CACHE]/git'\nsolutions = [{'deps_file': '.DEPS.git', 'managed': True, 'name': 'Angle', 'url': 'https://chromium.googlesource.com/angle/angle.git'}]"
     ],
     "cwd": "[START_DIR]/src/third_party",
-    "env": {
-      "PATH": "<PATH>:RECIPE_PACKAGE_REPO[depot_tools]"
+    "env_suffixes": {
+      "PATH": [
+        "RECIPE_PACKAGE_REPO[depot_tools]"
+      ]
     },
     "infra_step": true,
     "name": "[spec: Angle] gclient setup"
@@ -118,15 +126,15 @@
       "--with_tags",
       "--delete_unversioned_trees",
       "--revision",
-      "Angle@HEAD",
-      "--revision",
       "src/third_party/angle@refs/heads/lkgr",
       "--output-json",
       "/path/to/tmp/json"
     ],
     "cwd": "[START_DIR]/src/third_party",
-    "env": {
-      "PATH": "<PATH>:RECIPE_PACKAGE_REPO[depot_tools]"
+    "env_suffixes": {
+      "PATH": [
+        "RECIPE_PACKAGE_REPO[depot_tools]"
+      ]
     },
     "infra_step": true,
     "name": "[spec: Angle] gclient sync",
@@ -157,8 +165,10 @@
       "local_bot"
     ],
     "cwd": "[START_DIR]/src/third_party",
-    "env": {
-      "PATH": "<PATH>:RECIPE_PACKAGE_REPO[depot_tools]"
+    "env_suffixes": {
+      "PATH": [
+        "RECIPE_PACKAGE_REPO[depot_tools]"
+      ]
     },
     "infra_step": true,
     "name": "[spec: Angle] gclient recurse (git config user.name)"
@@ -175,8 +185,10 @@
       "local_bot@example.com"
     ],
     "cwd": "[START_DIR]/src/third_party",
-    "env": {
-      "PATH": "<PATH>:RECIPE_PACKAGE_REPO[depot_tools]"
+    "env_suffixes": {
+      "PATH": [
+        "RECIPE_PACKAGE_REPO[depot_tools]"
+      ]
     },
     "infra_step": true,
     "name": "[spec: Angle] gclient recurse (git config user.email)"
@@ -213,8 +225,10 @@
       "runhooks"
     ],
     "cwd": "[START_DIR]/src",
-    "env": {
-      "PATH": "<PATH>:RECIPE_PACKAGE_REPO[depot_tools]"
+    "env_suffixes": {
+      "PATH": [
+        "RECIPE_PACKAGE_REPO[depot_tools]"
+      ]
     },
     "name": "gclient runhooks"
   },

data/vendor/depot_tools/recipes/recipe_modules/gclient/examples/full.py

@@ -13,6 +13,7 @@ DEPS = [
 
 TEST_CONFIGS = [
   'android',
+  'angle',
   'boringssl',
   'build_internal',
   'build_internal_scripts_slave',
@@ -25,6 +26,7 @@ TEST_CONFIGS = [
   'gyp',
   'infra',
   'infradata_master_manager',
+  'infradata_config',
   'internal_deps',
   'luci_gae',
   'luci_go',
@@ -39,6 +41,7 @@ TEST_CONFIGS = [
   'wasm_llvm',
   'webports',
   'with_branch_heads',
+  'with_tags',
 ]
 
 
@@ -51,6 +54,7 @@ def RunSteps(api):
   soln.name = 'src'
   soln.url = 'https://chromium.googlesource.com/chromium/src.git'
   soln.revision = api.properties.get('revision')
+  soln.custom_vars = {'string_var': 'string_val', 'true_var': True}
   src_cfg.parent_got_revision_mapping['parent_got_revision'] = 'got_revision'
   api.gclient.c = src_cfg
   api.gclient.checkout()

data/vendor/depot_tools/recipes/recipe_modules/gerrit/api.py

@@ -7,6 +7,10 @@ from recipe_engine import recipe_api
 class GerritApi(recipe_api.RecipeApi):
   """Module for interact with gerrit endpoints"""
 
+  def __init__(self, *args, **kwargs):
+    super(GerritApi, self).__init__(*args, **kwargs)
+    self._changes_target_branch_cache = {}
+
   def __call__(self, name, cmd, infra_step=True, **kwargs):
     """Wrapper for easy calling of gerrit_utils steps."""
     assert isinstance(cmd, (list, tuple))
@@ -65,10 +69,13 @@ class GerritApi(recipe_api.RecipeApi):
     revision = step_result.json.output.get('revision')
     return revision
 
-  def get_change_destination_branch(self, host, change, **kwargs):
+  def get_change_destination_branch(
+      self, host, change, name=None, step_test_data=None):
     """
     Get the upstream branch for a given CL.
 
+    Result is cached.
+
     Args:
       host: Gerrit host to query.
       change: The change number.
@@ -76,19 +83,25 @@ class GerritApi(recipe_api.RecipeApi):
     Returns:
       the name of the branch
     """
-    assert int(change)
-    kwargs.setdefault('name', 'get_change_destination_branch')
+    assert int(change), change
+    change = int(change)
+    branch = self._changes_target_branch_cache.get((host, change))
+    if branch is not None:
+      return branch
     changes = self.get_changes(
         host,
         [('change', change)],
         limit=1,
-        **kwargs
+        name=name or 'get_change_destination_branch',
+        step_test_data=step_test_data,
     )
     if not changes or 'branch' not in changes[0]:
       self.m.step.active_result.presentation.status = self.m.step.EXCEPTION
       raise self.m.step.InfraFailure(
           'Error quering for branch of CL %s' % change)
-    return changes[0]['branch']
+    branch = changes[0]['branch']
+    self._changes_target_branch_cache[(host, change)] = branch
+    return branch
 
   def get_change_description(self, host, change, patchset):
     """
@@ -102,6 +115,22 @@ class GerritApi(recipe_api.RecipeApi):
     Returns:
       The description corresponding to given CL and patchset.
     """
+    ri = self.get_revision_info(host, change, patchset)
+    return ri['commit']['message']
+
+  def get_revision_info(self, host, change, patchset):
+    """
+    Returns the info for a given patchset of a given change.
+
+    Args:
+      host: Gerrit host to query.
+      change: The change number.
+      patchset: The patchset number.
+
+    Returns:
+      A dict for the target revision as documented here:
+          https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#list-changes
+    """
     assert int(change), change
     assert int(patchset), patchset
     cls = self.get_changes(
@@ -113,14 +142,14 @@ class GerritApi(recipe_api.RecipeApi):
     for ri in cl['revisions'].itervalues():
       # TODO(tandrii): add support for patchset=='current'.
       if str(ri['_number']) == str(patchset):
-        return ri['commit']['message']
+        return ri
 
     raise self.m.step.InfraFailure(
         'Error querying for CL description: host:%r change:%r; patchset:%r' % (
             host, change, patchset))
 
   def get_changes(self, host, query_params, start=None, limit=None,
-                  o_params=None, **kwargs):
+                  o_params=None, step_test_data=None, **kwargs):
     """
     Query changes for the given host.
 
@@ -133,6 +162,7 @@ class GerritApi(recipe_api.RecipeApi):
       limit: Maximum number of results to return.
       o_params: A list of additional output specifiers, as documented here:
           https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#list-changes
+      step_test_data: Optional mock test data for the underlying gerrit client.
     Returns:
       A list of change dicts as documented here:
           https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#list-changes
@@ -150,10 +180,12 @@ class GerritApi(recipe_api.RecipeApi):
       args += ['-p', '%s=%s' % (k, v)]
     for v in (o_params or []):
       args += ['-o', v]
+    if not step_test_data:
+      step_test_data = lambda: self.test_api.get_one_change_response_data()
 
     return self(
         kwargs.pop('name', 'changes'),
         args,
-        step_test_data=lambda: self.test_api.get_one_change_response_data(),
+        step_test_data=step_test_data,
         **kwargs
     ).json.output

data/vendor/depot_tools/recipes/recipe_modules/gerrit/examples/full.expected/basic.json

@@ -213,7 +213,7 @@
       "--limit",
       "1",
       "-p",
-      "change=123"
+      "change=122"
     ],
     "env": {
       "PATH": "<PATH>:RECIPE_PACKAGE_REPO[depot_tools]"
@@ -239,7 +239,7 @@
       "--limit",
       "1",
       "-p",
-      "change=123",
+      "change=122",
       "-o",
       "ALL_REVISIONS",
       "-o",
@@ -276,7 +276,7 @@
   },
   {
     "name": "$result",
-    "reason": "2 out of 2 aggregated steps failed. Failures: Error quering for branch of CL 123, Error querying for CL description: host:'https://chromium-review.googlesource.com' change:123; patchset:3",
+    "reason": "2 out of 2 aggregated steps failed. Failures: Error quering for branch of CL 122, Error querying for CL description: host:'https://chromium-review.googlesource.com' change:122; patchset:3",
     "recipe_result": null,
     "status_code": 1
   }

data/vendor/depot_tools/recipes/recipe_modules/gerrit/examples/full.py

@@ -36,14 +36,17 @@ def RunSteps(api):
   api.gerrit.get_change_description(
       host, change=123, patchset=1)
 
-  api.gerrit.get_change_destination_branch(host, change=123)
+  first = api.gerrit.get_change_destination_branch(host, change=123)
+  # Second call returns cached data.
+  second = api.gerrit.get_change_destination_branch(host, change=123)
+  assert first == second
 
   with api.step.defer_results():
     api.gerrit.get_change_destination_branch(
-        host, change=123, name='missing_cl')
+        host, change=122, name='missing_cl')
 
     api.gerrit.get_change_description(
-        host, change=123, patchset=3)
+        host, change=122, patchset=3)
 
 
 def GenTests(api):

data/vendor/depot_tools/recipes/recipe_modules/gitiles/OWNERS

@@ -1,3 +1,2 @@
-dnj@chromium.org
 smut@google.com
 tandrii@chromium.org

data/vendor/depot_tools/recipes/recipe_modules/tryserver/__init__.py

@@ -14,5 +14,4 @@ DEPS = [
   'recipe_engine/python',
   'recipe_engine/raw_io',
   'recipe_engine/step',
-  'rietveld',
 ]

data/vendor/depot_tools/recipes/recipe_modules/tryserver/api.py

@@ -16,16 +16,8 @@ class TryserverApi(recipe_api.RecipeApi):
 
   @property
   def is_tryserver(self):
-    """Returns true iff we can apply_issue or patch."""
-    return (
-        self.can_apply_issue or self.is_patch_in_git or self.is_gerrit_issue)
-
-  @property
-  def can_apply_issue(self):
-    """Returns true iff the properties exist to apply_issue from rietveld."""
-    return (self.m.properties.get('rietveld')
-            and 'issue' in self.m.properties
-            and 'patchset' in self.m.properties)
+    """Returns true iff we have a change to check out."""
+    return (self.is_patch_in_git or self.is_gerrit_issue)
 
   @property
   def is_gerrit_issue(self):
@@ -43,7 +35,7 @@ class TryserverApi(recipe_api.RecipeApi):
             self.m.properties.get('patch_repo_url') and
             self.m.properties.get('patch_ref'))
 
-  def get_files_affected_by_patch(self, patch_root=None, **kwargs):
+  def get_files_affected_by_patch(self, patch_root, **kwargs):
     """Returns list of paths to files affected by the patch.
 
     Argument:
@@ -51,16 +43,7 @@ class TryserverApi(recipe_api.RecipeApi):
         api.gclient.calculate_patch_root(patch_project)
 
     Returned paths will be relative to to patch_root.
-
-    TODO(tandrii): remove this doc.
-    Unless you use patch_root=None, in which case old behavior is used
-    which returns paths relative to checkout aka solution[0].name.
     """
-    # patch_root must be set! None is for backwards compataibility and will be
-    # removed.
-    if patch_root is None:
-      return self._old_get_files_affected_by_patch()
-
     cwd = self.m.context.cwd or self.m.path['start_dir'].join(patch_root)
     with self.m.context(cwd=cwd):
       step_result = self.m.git(
@@ -79,29 +62,6 @@ class TryserverApi(recipe_api.RecipeApi):
     step_result.presentation.logs['files'] = paths
     return paths
 
-
-  def _old_get_files_affected_by_patch(self):
-    issue_root = self.m.rietveld.calculate_issue_root()
-    cwd = self.m.path['checkout'].join(issue_root) if issue_root else None
-
-    with self.m.context(cwd=cwd):
-      step_result = self.m.git(
-          '-c', 'core.quotePath=false', 'diff', '--cached', '--name-only',
-          name='git diff to analyze patch',
-          stdout=self.m.raw_io.output(),
-          step_test_data=lambda:
-            self.m.raw_io.test_api.stream_output('foo.cc'))
-    paths = step_result.stdout.split()
-    if issue_root:
-      paths = [self.m.path.join(issue_root, path) for path in paths]
-    if self.m.platform.is_win:
-      # Looks like "analyze" wants POSIX slashes even on Windows (since git
-      # uses that format even on Windows).
-      paths = [path.replace('\\', '/') for path in paths]
-
-    step_result.presentation.logs['files'] = paths
-    return paths
-
   def set_subproject_tag(self, subproject_tag):
     """Adds a subproject tag to the build.
 
@@ -188,19 +148,10 @@ class TryserverApi(recipe_api.RecipeApi):
     git-footers documentation for more information.
     """
     if patch_text is None:
-      if self.is_gerrit_issue:
-        patch_text = self.m.gerrit.get_change_description(
-            self.m.properties['patch_gerrit_url'],
-            self.m.properties['patch_issue'],
-            self.m.properties['patch_set'])
-      elif self.can_apply_issue:
-        patch_url = (
-            self.m.properties['rietveld'].rstrip('/') + '/' +
-            str(self.m.properties['issue']))
-        patch_text = self.m.git_cl.get_description(
-            patch_url=patch_url, codereview='rietveld').stdout
-      else:  # pragma: no cover
-        raise recipe_api.StepFailure('Unknown patch storage.')
+      patch_text = self.m.gerrit.get_change_description(
+          self.m.properties['patch_gerrit_url'],
+          self.m.properties['patch_issue'],
+          self.m.properties['patch_set'])
 
     result = self.m.python(
         'parse description', self.package_repo_resource('git_footers.py'),

data/vendor/depot_tools/recipes/recipe_modules/tryserver/examples/full.expected/with_wrong_patch.json

@@ -8,7 +8,6 @@
       "--cached",
       "--name-only"
     ],
-    "cwd": "[START_DIR]",
     "infra_step": true,
     "name": "git diff to analyze patch",
     "stdout": "/path/to/tmp/",

data/vendor/depot_tools/recipes/recipe_modules/tryserver/examples/full.py

@@ -28,7 +28,7 @@ def RunSteps(api):
             'Foo', api.properties['patch_text']))])
     return
 
-  if api.tryserver.can_apply_issue or api.tryserver.is_gerrit_issue:
+  if api.tryserver.is_gerrit_issue:
     api.tryserver.get_footers()
   api.tryserver.get_files_affected_by_patch(
       api.properties.get('test_patch_root'))
@@ -50,30 +50,29 @@ def RunSteps(api):
 def GenTests(api):
   description_step = api.override_step_data(
       'git_cl description', stdout=api.raw_io.output_text('foobar'))
+  # The 'test_patch_root' property used below is just so that these
+  # tests can avoid using the gclient module to calculate the
+  # patch root. Normal users would use gclient.calculate_patch_root().
   yield (api.test('with_git_patch') +
          api.properties(
-              path_config='buildbot',
-              patch_storage='git',
-              patch_project='v8',
-              patch_repo_url='http://patch.url/',
-              patch_ref='johndoe#123.diff'))
+             path_config='buildbot',
+             patch_storage='git',
+             patch_project='v8',
+             patch_repo_url='http://patch.url/',
+             patch_ref='johndoe#123.diff',
+             test_patch_root='v8'))
 
   yield (api.test('with_git_patch_luci') +
          api.properties(
              patch_storage='git',
              patch_project='v8',
              patch_repo_url='http://patch.url/',
-             patch_ref='johndoe#123.diff'))
-
-  yield (api.test('with_rietveld_patch') +
-         api.properties.tryserver() +
-         description_step)
-
-  yield (api.test('with_wrong_patch') + api.platform('win', 32))
+             patch_ref='johndoe#123.diff',
+             test_patch_root='v8'))
 
-  yield (api.test('with_rietveld_patch_new') +
-         api.properties.tryserver(test_patch_root='sub/project') +
-         description_step)
+  yield (api.test('with_wrong_patch') +
+         api.platform('win', 32) +
+         api.properties(test_patch_root=''))
 
   yield (api.test('with_gerrit_patch') +
          api.properties.tryserver(gerrit_project='infra/infra'))