libv8-node 24.12.0.0 → 24.12.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1b236529e0b7a1bc84cf99a96962ada218873a6cd24c8093fda5c8c33c9a6f90
-  data.tar.gz: e558d5b144f431d251409a73c70e98e32be7c59747f560687f30c6d9129a3d27
+  metadata.gz: b8f77f83cc4f349ba82b53450ec4ba2fc7ff64b2023329e0a719a918a3e2aec5
+  data.tar.gz: 7f5fe3f83fa59844bf8f2f5389a650d19519b9a36bb5f9a764e2120c6e2622fd
 SHA512:
-  metadata.gz: f8e856fdf8828f71750f0141409ec8c134b30d1ac5478407aad6048de333e6f84dcf58bc1a47b9a81fb1d4508eb1f2267b87efb14f999ffeb6fc8a916f3f9040
-  data.tar.gz: 8365e6536ee648018e00773b8a194c07b0df395056523f60a90de3e949b82e0c6db3deedd147f72ded6bbf9d73e5dae0127eda36cd165ef78cbd43a84f48103b
+  metadata.gz: b6d7a3baa6d355507c665ef3278523252bfa84fd2b085878d273eeaa237e241a621863b0e8929e38f0f2cae10d36f2bfdd1423d4680a1e5c06775374b36ef0a6
+  data.tar.gz: 3b9d6c161fd5d2867efc13f6edb80c1f81e296d8cd4928f9a41f20b10468f58a14942faf37cb7e2d36d48978b99287700695c350f08db5fbf56f616770153ce9

data/README.md

@@ -32,17 +32,14 @@ Here's an informal list of platforms we push so far, with equally informal tiers
 
 Tier 0 (CI built and tested):
 
-- x86_64-darwin (17 to 20)
+- x86_64-darwin
+- arm64-darwin
 - x86_64-linux
 - x86_64-linux-musl
+- aarch64-linux
 
 Tier 1 (manual build and test):
 
-- arm64-darwin (20)
-
-Tier 2 (manual build and test, has known stability issues):
-
-- aarch64-linux
 - aarch64-linux-musl
 
 As a fallback, the source gem (`ruby` gem platform) should compile on all Node supported platforms (including e.g. ppc64le or solaris), but we may not have tested it. Help is welcome!
@@ -61,9 +58,9 @@ There is an outstanding issue with rubygems and bundler, where it may misselect
 
 ## Versioning
 
-The gem versioning is Node-based, e.g node 15.14.0 gives the gem 15.14.0.0. The last number is an increment for libv8-node fixes. We try as mucha s possible not to include too much changes in such gem fixes, so you can consider these like "patch" in semver.
+The gem versioning is Node-based, e.g node 15.14.0 gives the gem 15.14.0.0. The last number is an increment for libv8-node fixes. We try as much as possible not to include too much changes in such gem fixes, so you can consider these like "patch" in semver.
 
-Compared to the `libv8` gem, there is no odd/even scheme, thanks to the intriduction in bundler of the `force_ruby_platform` flag.
+Compared to the `libv8` gem, there is no odd/even scheme, thanks to the introduction in bundler of the `force_ruby_platform` flag.
 
 ## Requirements
 

data/ext/libv8-node/paths.rb

@@ -22,7 +22,38 @@ module Libv8::Node
     end
 
     def platform
-      Gem::Platform.local.tap { |p| RUBY_PLATFORM =~ /musl/ && p.version.nil? && p.instance_eval { @version = 'musl' } }.to_s.gsub(/-darwin-?\d+/, '-darwin')
+      @platform ||= determine_platform
+    end
+
+    def determine_platform
+      ideal = construct_ideal_platform_name
+      return ideal if platform_directory_exists?(ideal)
+
+      fallback_platform
+    end
+
+    def construct_ideal_platform_name
+      local = Gem::Platform.local
+      parts = [local.cpu, local.os, local.version]
+      parts[2] = 'musl' if musl_platform?
+      parts.compact.reject(&:empty?).join('-').gsub(/-darwin-?\d+/, '-darwin')
+    end
+
+    def musl_platform?
+      RUBY_PLATFORM =~ /musl/
+    end
+
+    def platform_directory_exists?(name)
+      File.directory?(File.join(vendored_source_path, name))
+    end
+
+    def fallback_platform
+      available = available_platform_directories
+      available.size == 1 ? available.first : construct_ideal_platform_name
+    end
+
+    def available_platform_directories
+      Dir.glob(File.join(vendored_source_path, '*')).select { |d| File.directory?(d) }.map { |d| File.basename(d) } - ['include']
     end
 
     def config

data/lib/libv8/node/version.rb

@@ -4,7 +4,7 @@ module Libv8
 end
 
 module Libv8::Node
-  VERSION = '24.12.0.0'
+  VERSION = '24.12.0.1'
   NODE_VERSION = '24.12.0'
   LIBV8_VERSION = '13.6.233.17' # from src/node-.../deps/v8/include/v8-version.h
 end

data/libexec/build-libv8

@@ -45,7 +45,7 @@ fi
 
 if [ "${BUILDTYPE}" = "Release" ] && [ "${GITHUB_ACTIONS}" != "" ]; then
 	case "${target_platform}" in
-		arm64*-darwin*)
+		*-darwin*)
 			# dwarf debug info for v8 is so massive the macos
 			# builder runs out of disk space when it's enabled
 			find out -name '*.mk' -exec sed -i '' -e 's/gdwarf-2/g0/g' {} ';'

data/libexec/fetch-gems

@@ -0,0 +1,64 @@
+#!/bin/bash
+set -e
+
+# libexec/fetch-gems <url-or-run-id>
+# Downloads all artifacts from a GitHub Actions run, extracts the gems,
+# and places them in the pkg/ directory for easy publishing.
+
+URL_OR_ID=$1
+
+if [[ -z "$URL_OR_ID" ]]; then
+  echo "Usage: $0 <github-actions-run-url-or-id>"
+  exit 1
+fi
+
+# Extract run ID from URL or use as is if it's already an ID
+if [[ "$URL_OR_ID" =~ /actions/runs/([0-9]+) ]]; then
+  RUN_ID="${BASH_REMATCH[1]}"
+elif [[ "$URL_OR_ID" =~ ^[0-9]+$ ]]; then
+  RUN_ID="$URL_OR_ID"
+else
+  echo "Error: Could not parse run ID from '$URL_OR_ID'"
+  exit 1
+fi
+
+# Determine repo - default to rubyjs/libv8-node but allow override via GH_REPO env var
+REPO=${GH_REPO:-rubyjs/libv8-node}
+
+echo "Fetching artifacts for run $RUN_ID in $REPO..."
+
+# Create a temporary directory for downloading
+TMP_DIR=$(mktemp -d -t libv8-node-artifacts-XXXXXX)
+trap 'rm -rf "$TMP_DIR"' EXIT
+
+# Download all artifacts
+gh run download "$RUN_ID" --repo "$REPO" -D "$TMP_DIR"
+
+# Ensure pkg directory exists
+mkdir -p pkg
+
+# Move all .gem files to pkg/
+# Artifacts are downloaded into subdirectories named after the artifact
+echo "Extracting gems..."
+found_gems=0
+while IFS= read -r gem_file; do
+  gem_name=$(basename "$gem_file")
+  mv -v "$gem_file" "pkg/$gem_name"
+  found_gems=$((found_gems + 1))
+done < <(find "$TMP_DIR" -name "*.gem")
+
+if [ "$found_gems" -eq 0 ]; then
+  echo "No gems found in artifacts for run $RUN_ID."
+  exit 1
+fi
+
+echo ""
+echo "Successfully downloaded $found_gems gem(s) to pkg/:"
+ls -1 pkg/*.gem
+
+echo ""
+echo "To publish all downloaded gems, run:"
+echo "  for g in pkg/*.gem; do gem push \"\$g\"; done"
+echo ""
+echo "To publish a specific gem:"
+echo "  gem push pkg/<gem-filename>"

data/libexec/metadata

@@ -5,7 +5,7 @@ case "$1" in
         ruby -e 'puts RUBY_PLATFORM'
         ;;
     gem_platform)
-        ruby -e 'puts Gem::Platform.local.tap { |p| RUBY_PLATFORM =~ /musl/ && p.version.nil? and p.instance_eval { @version = "musl" } }.to_s.gsub(/-darwin-?\d+/, "-darwin")'
+        ruby -e 'p = Gem::Platform.local; parts = [p.cpu, p.os, p.version]; parts[2] = "musl" if RUBY_PLATFORM =~ /musl/; puts parts.compact.reject { |s| s.to_s.empty? }.join("-").gsub(/-darwin-?\d+/, "-darwin")'
         ;;
     gem_version|version)
         ruby -I'lib' -r'libv8/node/version' -e 'puts Libv8::Node::VERSION'

data/libexec/platform

@@ -29,6 +29,13 @@ host_platform="${triple}"
 target_platform="${TARGET_PLATFORM:-${1:-}}"
 target_platform="${target_platform:-${host_platform}}"
 
+normalize_platform() {
+    echo "$1" | sed -E 's/(x86_64|aarch64|armv[0-9]+|arm).*-linux-musl.*/\1-linux-musl/' | sed -E 's/(x86_64|aarch64|armv[0-9]+|arm).*-linux-gnu.*/\1-linux/' | sed -E 's/armv[0-9]+l?/arm/'
+}
+
+norm_host=$(normalize_platform "${host_platform}")
+norm_target=$(normalize_platform "${target_platform}")
+
 case "${target_platform}" in
     x86_64*-linux-musl)
         RUBY_TARGET_PLATFORM='x86_64-linux-musl'
@@ -57,7 +64,7 @@ case "${target_platform}" in
         RUBY_TARGET_PLATFORM='arm64-darwin'
         ;;
     *)
-        if [ "${host_platform}" != "${target_platform}" ]; then
+        if [ "${norm_host}" != "${norm_target}" ]; then
             echo 'cross compilation not supported'
             exit 1
         fi
@@ -78,8 +85,8 @@ case "${host_platform}" in
         ;;
 esac
 
-if [ "${host_platform}" != "${target_platform}" ]; then
-    echo "# cross compiling host: ${host_platform} target: ${target_platform}"
+if [ "${norm_host}" != "${norm_target}" ]; then
+    echo "# cross compiling host: ${host_platform} (norm: ${norm_host}) target: ${target_platform} (norm: ${norm_target})"
     case "${target_platform}" in
         aarch64-*linux*)
             CC='aarch64-linux-gnu-gcc'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: libv8-node
 version: !ruby/object:Gem::Version
-  version: 24.12.0.0
+  version: 24.12.0.1
 platform: ruby
 authors:
 - ''
@@ -102,6 +102,7 @@ files:
 - libexec/build-monolith
 - libexec/download-node
 - libexec/extract-node
+- libexec/fetch-gems
 - libexec/inject-libv8
 - libexec/metadata
 - libexec/platform