libv8-node 17.9.1.0 → 17.9.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 77d656afd7388f0880caf7e7dd87f11f52e1433d78251bc830ce079dfd08e13f
-  data.tar.gz: 6f26a9758e57478e432686ef6763df7387d988cdb32c6c3895d2cb7e699f5c54
+  metadata.gz: ca9188ddf638912731789be80c87f997f40381a0be3567adbc3cd55962a69a05
+  data.tar.gz: 76b3e45554806ae36bd0f93ec5660f0a1c000481bf50a9fa6bda9c1bce59af69
 SHA512:
-  metadata.gz: 638aad097efa406f29de95569a28ba12d35c711d374dc011612704658e2552ba058abaa18d5a3730e06cfe5e20b189154c6e83f2628c19a1753c847e583b101f
-  data.tar.gz: c0cc5d4664da75583e892eaeac8b5293943a93a0b4e8374f02e64df1504de1bfe3493a9f6f628a45cbbd1312b5746beb41a42bff046df1d75aef090325e81bfb
+  metadata.gz: 665bee5f4f1588e8dcdaf1f642775a21d08b47236c1ab665d26795ad1e7288c11e5c8fc4273cf24f4d7883c871f8b0fcaeeffb5b275f46c1bb971131cd2a0ab8
+  data.tar.gz: b7e80764d4808a41cc66053ed740155a65e01c5a8d98fb6708c8454bf274772ef16e53d619f4792ea0fa94d571264b35e27709e82c55ee3ee185f96bc2d9c287

data/ext/libv8-node/builder.rb

@@ -1,4 +1,4 @@
-unless $LOAD_PATH.include?(File.expand_path('../../lib', __dir__))
+unless $LOAD_PATH.include?(File.expand_path('../../lib', __dir__)) # rubocop:disable Style/IfUnlessModifier
   $LOAD_PATH.unshift(File.expand_path('../../lib', __dir__))
 end
 require 'libv8/node/version'

data/ext/libv8-node/extconf.rb

@@ -1,6 +1,12 @@
 # frozen_string_literal: true
 
 require 'mkmf'
+
+if RUBY_ENGINE == 'truffleruby'
+  File.write('Makefile', dummy_makefile($srcdir).join('')) # rubocop:disable Style/GlobalVars
+  return
+end
+
 create_makefile('libv8-node')
 
 require File.expand_path('location', __dir__)

data/ext/libv8-node/location.rb

@@ -45,7 +45,7 @@ module Libv8::Node
       def verify_installation!
         include_paths = Libv8::Node::Paths.include_paths
 
-        unless include_paths.detect { |p| Pathname(p).join('v8.h').exist? }
+        unless include_paths.detect { |p| Pathname(p).join('v8.h').exist? } # rubocop:disable Style/IfUnlessModifier
           raise(HeaderNotFound, "Unable to locate 'v8.h' in the libv8 header paths: #{include_paths.inspect}")
         end
 

data/lib/libv8/node/version.rb

@@ -1,7 +1,7 @@
 module Libv8; end
 
 module Libv8::Node
-  VERSION = '17.9.1.0'.freeze
+  VERSION = '17.9.1.1'.freeze
   NODE_VERSION = '17.9.1'.freeze
   LIBV8_VERSION = '9.6.180.15'.freeze # from v8/include/v8-version.h
 end

data/libexec/build-libv8

@@ -17,12 +17,6 @@ BUILDTYPE="${BUILDTYPE:-Release}"
 
 cd "${src}/node-v${version}"
 
-if command -v python3 >/dev/null 2>&1; then
-    PYTHON="${PYTHON:-python3}"
-else
-    PYTHON="${PYTHON:-python2}"
-fi
-
 configure_flags='--openssl-no-asm --without-npm --shared --with-intl=full-icu'
 eval "$("${libexec}/platform")"
 
@@ -33,10 +27,18 @@ ${CC} -v
 ${CXX} -v
 
 # shellcheck disable=SC2086
-"${PYTHON}" configure ${configure_flags}
+./configure ${configure_flags}
 
 make BUILDTYPE="${BUILDTYPE}" config.gypi
 make BUILDTYPE="${BUILDTYPE}" "out/Makefile"
 
+# workaround for node specifying `-msign-return-address=all` in ALL `CFLAGS` for aarch64 builds
+# (if the host isn't also aarch64, this flag causes a compiler error)
+
+# shellcheck disable=SC2154 # these variables are defined by `eval`ing the output of the platform script above
+if [ "$host_platform" != "$target_platform" ] && [ "${target_platform%%-*}" = "aarch64"  ]; then
+	find . -iname "*.host.mk" -exec sed -i '/-msign-return-address/d' {} ';'
+fi
+
 export PATH="${PWD}/out/tools/bin:${PATH}"
 make -j"${NJOBS}" -C out BUILDTYPE="${BUILDTYPE}" V=0

data/libexec/build-monolith

@@ -21,13 +21,14 @@ platform=$(uname)
 rm -f "${LIBV8_MONOLITH}"
 case "${platform}" in
     "SunOS")
-        /usr/xpg4/bin/find . -path "./torque_*/**/*.o" -or -path "./v8*/**/*.o" -or -path "./icu*/**/*.o" | sort | uniq | xargs ar cq "${LIBV8_MONOLITH}"
+        /usr/xpg4/bin/find . '(' '!' -path './icutools/deps/icu-small/source/stubdata/stubdata.o' ')' -path "./torque_*/**/*.o" -or -path "./v8*/**/*.o" -or -path "./icu*/**/*.o" | sort | uniq | xargs ar cq "${LIBV8_MONOLITH}"
         ;;
     "Darwin")
-        /usr/bin/find . -path "./torque_*/**/*.o" -or -path "./v8*/**/*.o" -or -path "./icu*/**/*.o" | sort | uniq | xargs /usr/bin/ar -cq "${LIBV8_MONOLITH}"
+        /usr/bin/find . '(' '!' -path './icutools/deps/icu-small/source/stubdata/stubdata.o' ')' -path "./torque_*/**/*.o" -or -path "./v8*/**/*.o" -or -path "./icu*/**/*.o" | sort | uniq | xargs /usr/bin/ar -cq "${LIBV8_MONOLITH}"
         ;;
     "Linux")
-        find . -path "./torque_*/**/*.o" -or -path "./v8*/**/*.o" -or -path "./icu*/**/*.o" | sort | uniq | xargs ar -cq "${LIBV8_MONOLITH}"
+        find . '(' '!' -path './icutools/deps/icu-small/source/stubdata/stubdata.o' ')' -and '(' -path "./torque_*/**/*.o" -or -path "./v8*/**/*.o" -or -path "./icu*/**/*.o" ')' | sort | uniq | xargs ar -cqSP "${LIBV8_MONOLITH}"
+        ar -sP "${LIBV8_MONOLITH}"
         ;;
     *)
       echo "Unsupported platform: ${platform}"

data/libexec/extract-node

@@ -32,6 +32,7 @@ cd "${src}/node-v${version}"
 #patch -p1 < "${top}"/patch/gyp-libv8_monolith.patch
 patch -p1 < "${top}"/patch/py2-icutrim.patch
 patch -p1 < "${top}"/patch/py2-genv8constants.patch
+patch -p0 < "${top}"/patch/v8-prefinalizer-h-utility.patch
 
 # TODO: the following still fails on py3 so the above one forcing py2 is needed
 # patch -p1 < ../../py3-genv8constants.patch

data/libexec/inject-libv8

@@ -39,8 +39,35 @@ for lib in libv8_monolith.a; do
     mkdir -p "${dir}"
     rm -f "${dir}/${lib}"
 
-    echo "${BASEDIR}/out/${BUILDTYPE}/${lib} -> ${dir}/${lib}"
-    "${STRIP}" -S -x -o "${dir}/${lib}" "${lib}"
+    if [ "$STRIP_NEEDS_EXTRACT" = "y" ]; then
+        # manual extract/strip objects/build archive sequence
+        # because `strip` can't deal with these
+        # (presumably due to that folder issue mentioned below)
+        (
+            tmpdir="$(mktemp -d)"
+            trap 'rm -r "$tmpdir"' EXIT
+            mkdir "$tmpdir/stage"
+            cd "$tmpdir/stage"
+
+            # create folders named in `ar` archive (`ar -x` fails to create these)
+            "$AR" "$ARLISTFLAGS" "$BASEDIR/out/$BUILDTYPE/$lib" | while read -r path; do
+              dirname "$path"
+            done | uniq | xargs mkdir -p
+            "$AR" "$AREXTRACTFLAGS" "$BASEDIR/out/${BUILDTYPE}/$lib"
+
+            # strip all objects
+            "$FIND" -type f -exec "$STRIP" -Sx {} +
+
+            # rebuild the archive
+            "$FIND" -type f -exec "$AR" "$ARCOLLECTFLAGS" "../$lib" {} +
+            $ARBUILDSYMBOLS "../$lib"
+            mv "../$lib" "$dir/$lib"
+        )
+        echo "${BASEDIR}/out/${BUILDTYPE}/${lib} -> ${dir}/${lib}"
+    else
+        echo "${BASEDIR}/out/${BUILDTYPE}/${lib} -> ${dir}/${lib}"
+        "${STRIP}" -S -x -o "${dir}/${lib}" "${lib}"
+    fi
 done
 
 mkdir -p "${top}/ext/libv8-node"

data/libexec/platform

@@ -15,6 +15,14 @@ elif command -v cc >/dev/null 2>&1; then
 fi
 
 STRIP="${STRIP:-strip}"
+AR="${AR:-ar}"
+AREXTRACTFLAGS="${AREXTRACTFLAGS:--x}"
+ARLISTFLAGS="${ARLISTFLAGS:--t}"
+ARCOLLECTFLAGS="${ARCOLLECTFLAGS:-cqS}"
+# this is the command to build the symbol table in an ar archive.
+ARBUILDSYMBOLS="${ARBUILDSYMBOLS:-ranlib}"
+FIND="${FIND:-find}"
+STRIP_NEEDS_EXTRACT="${STRIP_NEEDS_EXTRACT:-n}"
 
 triple=$(${CC} -dumpmachine)
 host_platform="${triple}"
@@ -63,6 +71,11 @@ case "${host_platform}" in
         CXX="${CXX:-/opt/local/gcc7/bin/g++}"
         STRIP="gstrip"
         ;;
+    *linux*)
+        STRIP_NEEDS_EXTRACT="y"
+        ARCOLLECTFLAGS="-cqSP"
+        ARBUILDSYMBOLS="${AR} -sP"
+        ;;
 esac
 
 if [ "${host_platform}" != "${target_platform}" ]; then
@@ -146,6 +159,14 @@ export CC='${CC}'
 export CXX='${CXX}'
 host_platform='${host_platform}'
 target_platform='${target_platform}'
+STRIP='$STRIP'
+AR='$AR'
+AREXTRACTFLAGS='$AREXTRACTFLAGS'
+ARLISTFLAGS='$ARLISTFLAGS'
+ARCOLLECTFLAGS='$ARCOLLECTFLAGS'
+ARBUILDSYMBOLS='$ARBUILDSYMBOLS'
+FIND='$FIND'
+STRIP_NEEDS_EXTRACT='$STRIP_NEEDS_EXTRACT'
 EOF
 
 if [ -n "${CC_host:-}" ]; then cat <<EOF; fi

data/patch/v8-prefinalizer-h-utility.patch

@@ -0,0 +1,10 @@
+--- deps/v8/src/heap/cppgc/prefinalizer-handler.h
++++ deps/v8/src/heap/cppgc/prefinalizer-handler.h
+@@ -6,6 +6,7 @@
+ #define V8_HEAP_CPPGC_PREFINALIZER_HANDLER_H_
+ 
+ #include <vector>
++#include <utility>
+ 
+ #include "include/cppgc/prefinalizer.h"
+ 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: libv8-node
 version: !ruby/object:Gem::Version
-  version: 17.9.1.0
+  version: 17.9.1.1
 platform: ruby
 authors:
 - ''
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-08-29 00:00:00.000000000 Z
+date: 2023-05-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -30,14 +30,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.50.0
+        version: 1.44.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.50.0
+        version: 1.44.0
 description: Node.JS's V8 JavaScript engine for multiplatform goodness
 email:
 - ''
@@ -67,6 +67,7 @@ files:
 - patch/py2-genv8constants.patch
 - patch/py2-icutrim.patch
 - patch/py3-genv8constants.patch
+- patch/v8-prefinalizer-h-utility.patch
 - sums/v16.10.0.sum
 - sums/v16.11.1.sum
 - sums/v16.3.0.sum
@@ -98,7 +99,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.26
+rubygems_version: 3.3.20
 signing_key:
 specification_version: 4
 summary: Node.JS's V8 JavaScript engine