librato-rack 1.1.0 → 1.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 7b2e81e09050e4d9b1f448806ec43c19314de09a
-  data.tar.gz: 4d6a014870df60b95a7fedc4efda0a5a96bf3a50
+SHA256:
+  metadata.gz: 166d12211f03918ae932f69cef410ab25dab8c81559418f7bfbcb60d6ba518b6
+  data.tar.gz: fe3b81c8d79e7583e4f2ab49e6e5c8eaea52ec0190b5d5f5734581bd06c6d85d
 SHA512:
-  metadata.gz: cd329d855d6dcf6036e3f685c9e7ba29276ef731415de1674ac77df9a3dc91e05afd606917f36da2a0d1b1ab38d580af738af94c528d6287115e618a0bf914af
-  data.tar.gz: 42bf488009d6868df5227720d320dd9c6b0bd3ab8de15db4ee28f5e5fed7a2c1efd9781cf1463483cbfe0cb11ded77cf9268057b6df1131986f40549cbf99cbf
+  metadata.gz: 901388b2a16efea6d162189a96102f52e84c4904909f50c53ce024698dee51618bb5266c67b0af740492bee13028fe676849660758e8116cd2e4b0e92e4d2ad5
+  data.tar.gz: 3118d9c1cd7bf4a89a89454120a4149b821466f72c682871ce97d2b83082909fed5e977bc48fa3d6b6bf47d746958f56606311fa85cbd85999fea1c7ca2cad4b

data/lib/librato/rack.rb

@@ -55,9 +55,9 @@ module Librato
 
     RECORD_RACK_METHOD_BODY = <<-'EOS'
       group.group 'method' do |m|
-        http_method.downcase!
-        m.increment http_method
-        m.timing "#{http_method}.time", duration
+        method = http_method.downcase
+        m.increment method
+        m.timing "#{method}.time", duration
       end
     EOS
 

data/lib/librato/rack/version.rb

@@ -1,5 +1,5 @@
 module Librato
   class Rack
-    VERSION = "1.1.0"
+    VERSION = "1.1.1"
   end
 end

data/test/integration/queue_wait_test.rb

@@ -19,10 +19,13 @@ class QueueWaitTest < Minitest::Test
   def test_milliseconds
     get '/milli'
 
+    # give jruby a bit more time since it can be slow
+    delta = defined?(JRUBY_VERSION) ? 6 : 4
+
     # puts "milli: #{aggregate["rack.request.queue.time"].inspect}"
     assert_equal 1, aggregate["rack.request.queue.time"][:count],
       'should track total queue time'
-    assert_in_delta 5, aggregate["rack.request.queue.time"][:sum], 4
+    assert_in_delta 5, aggregate["rack.request.queue.time"][:sum], delta
   end
 
   def test_microseconds
@@ -37,10 +40,13 @@ class QueueWaitTest < Minitest::Test
   def test_queue_start
     get '/queue_start'
 
+    # give jruby a bit more time since it can be slow
+    delta = defined?(JRUBY_VERSION) ? 6 : 4
+
     # puts "micro: #{aggregate["rack.request.queue.time"].inspect}"
     assert_equal 1, aggregate["rack.request.queue.time"][:count],
       'should track total queue time'
-    assert_in_delta 15, aggregate["rack.request.queue.time"][:sum], 4
+    assert_in_delta 15, aggregate["rack.request.queue.time"][:sum], delta
   end
 
   def test_with_t

data/test/integration/request_test.rb

@@ -57,6 +57,13 @@ class RequestTest < Minitest::Test
     assert_equal 1, aggregate['rack.request.method.post.time'][:count]
   end
 
+  def test_request_method_not_mutated
+    get '/', {}, {'REQUEST_METHOD' => "GET".freeze}
+
+    assert_equal 1, counters['rack.request.method.get']
+    assert_equal 1, aggregate['rack.request.method.get.time'][:count]
+  end
+
   def test_track_exceptions
     begin
       get '/exception'

metadata

@@ -1,35 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: librato-rack
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.1.1
 platform: ruby
 authors:
 - Matt Sanders
 autorequire: 
 bindir: bin
 cert_chain:
-- |
-  -----BEGIN CERTIFICATE-----
-  MIIDLjCCAhagAwIBAgIBADANBgkqhkiG9w0BAQUFADA9MQ0wCwYDVQQDDARydWJ5
-  MRcwFQYKCZImiZPyLGQBGRYHbGlicmF0bzETMBEGCgmSJomT8ixkARkWA2NvbTAe
-  Fw0xNzAxMTExODI3MDdaFw0xODAxMTExODI3MDdaMD0xDTALBgNVBAMMBHJ1Ynkx
-  FzAVBgoJkiaJk/IsZAEZFgdsaWJyYXRvMRMwEQYKCZImiZPyLGQBGRYDY29tMIIB
-  IjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA58LirwsWnKL1uuClQ0uwA1XL
-  GpxDuFzSosipiPkzZY3hiHazC8SHDREZQXlm7ITX/o+dueNoB7dt0BR3RPVipH7V
-  7cvbCUaZNjEXR5Lal6PsmUsbMTrddkvj3e7flmJv+kMj+teeJ7MDeJTU5wXXV9pD
-  ThiCDILJMF5CdP8Jru4rSBOP6RmmzYU+0cN5+5pt9xqrycA+Poo2ZuoUMCMsSBvl
-  PimM3PPvoWTuE41GTn/bLoOVoXQmdwZIbwUSVH8rCDjZSlttOst+xrBw4KG0dYUp
-  2UvEe8iCyqEMQ8fEZ7EXuP2WMVICutFbz8Pt4hIMq+OTnDX+mIfma7GvPaKAFwID
-  AQABozkwNzAJBgNVHRMEAjAAMB0GA1UdDgQWBBQBSxu9Jj4VTrXTpLujPwk9Kzwp
-  2jALBgNVHQ8EBAMCBLAwDQYJKoZIhvcNAQEFBQADggEBACvNsw1pGv72xp3LiDlZ
-  0tphNP/85RcYyJMklslG3tIYblyo71xHW1UbK5ArUK6k0BN43MuDn3pqLJQttVmi
-  bUdA3yYi13GeSrrAMlr4nH8Yt/Bn/XpZGliouJUBwh1BjG6dSj1iuR4/9pt9/LtO
-  QTdIc+07qGspypT0Uh/w/BodEcGuAaZZFlkU9vottTe6wWNnM6hfRExiSIsr+oVe
-  s8s83ObshjuSzjOqS56IBtNlPEL+D6ghjZZLP3lS6l9p70Pcpcl+IcE4veqZmmKC
-  sGepgRclC6UbZh+yQ3alXVghM2qsonAwI/rTNmFJN9kQn6nP9+f1Uf/qZFNcjn4L
-  9bg=
-  -----END CERTIFICATE-----
-date: 2017-01-11 00:00:00.000000000 Z
+- certs/librato-public.pem
+date: 2018-08-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: librato-metrics
@@ -77,7 +57,6 @@ description: Rack middleware to report key app statistics and custom instrumenta
   to the Librato Metrics service.
 email:
 - matt@librato.com
-- ruby@librato.com
 executables: []
 extensions: []
 extra_rdoc_files: []
@@ -126,7 +105,7 @@ files:
 - test/unit/rack/worker_test.rb
 homepage: https://github.com/librato/librato-rack
 licenses:
-- BSD-3-Clause
+- BSD 3-clause
 metadata: {}
 post_install_message: 
 rdoc_options: []
@@ -144,31 +123,31 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.8
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: Use Librato Metrics with your rack application
 test_files:
-- test/apps/basic.ru
-- test/apps/custom.ru
-- test/apps/custom_suites.ru
-- test/apps/no_stats.ru
-- test/apps/queue_wait.ru
-- test/integration/custom_test.rb
-- test/integration/no_stats_test.rb
-- test/integration/no_suites_test.rb
-- test/integration/queue_wait_test.rb
-- test/integration/request_test.rb
-- test/integration/suites_test.rb
-- test/remote/tracker_test.rb
-- test/support/environment_helpers.rb
-- test/test_helper.rb
-- test/unit/collector/aggregator_test.rb
+- test/unit/collector_test.rb
 - test/unit/collector/counter_cache_test.rb
 - test/unit/collector/group_test.rb
-- test/unit/collector_test.rb
+- test/unit/collector/aggregator_test.rb
 - test/unit/rack/configuration/suites_test.rb
-- test/unit/rack/configuration_test.rb
 - test/unit/rack/logger_test.rb
 - test/unit/rack/tracker_test.rb
+- test/unit/rack/configuration_test.rb
 - test/unit/rack/worker_test.rb
+- test/integration/no_stats_test.rb
+- test/integration/queue_wait_test.rb
+- test/integration/request_test.rb
+- test/integration/custom_test.rb
+- test/integration/no_suites_test.rb
+- test/integration/suites_test.rb
+- test/support/environment_helpers.rb
+- test/test_helper.rb
+- test/apps/queue_wait.ru
+- test/apps/custom_suites.ru
+- test/apps/custom.ru
+- test/apps/no_stats.ru
+- test/apps/basic.ru
+- test/remote/tracker_test.rb