librato-rack 1.0.1 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 43bcc15e0b037c711de7dc15bc918d476e5efeb4
-  data.tar.gz: 272c3886d3efe9a35018ce94ab5309006b27b11c
+  metadata.gz: 7b2e81e09050e4d9b1f448806ec43c19314de09a
+  data.tar.gz: 4d6a014870df60b95a7fedc4efda0a5a96bf3a50
 SHA512:
-  metadata.gz: f2bcfbf49e5dd485d1e1121731f9bb0fe6b708c6b8ec156faa7356330b2b840546132489660867d35392497d0b71b41b2115b79496adda9e7cdd17be1e061aad
-  data.tar.gz: cec27780849819fc168877a2bf07957fb1363803cc460779ed52b40c5c17307bfb4e674951d62ff428be46315603d010800700d10729947dba1b188fa1c0102b
+  metadata.gz: cd329d855d6dcf6036e3f685c9e7ba29276ef731415de1674ac77df9a3dc91e05afd606917f36da2a0d1b1ab38d580af738af94c528d6287115e618a0bf914af
+  data.tar.gz: 42bf488009d6868df5227720d320dd9c6b0bd3ab8de15db4ee28f5e5fed7a2c1efd9781cf1463483cbfe0cb11ded77cf9268057b6df1131986f40549cbf99cbf

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+### Version 1.1.0
+* Fix deprecation warnings in ruby 2.4 (#57, Ben Radler)
+
 ### Version 1.0.1
 * Fix missing p95 for rack.request.time
 

data/lib/librato/collector/counter_cache.rb

@@ -5,6 +5,7 @@ module Librato
     #
     class CounterCache
       SEPARATOR = '%%'
+      INTEGER_CLASS = 1.class
 
       extend Forwardable
 
@@ -74,7 +75,7 @@ module Librato
       #   increment :foo, :source => user.id
       #
       def increment(counter, options={})
-        if options.is_a?(Fixnum)
+        if options.is_a?(INTEGER_CLASS)
           # suppport legacy style
           options = {by: options}
         end
@@ -110,4 +111,4 @@ module Librato
     end
 
   end
-end
+end

data/lib/librato/rack/version.rb

@@ -1,5 +1,5 @@
 module Librato
   class Rack
-    VERSION = "1.0.1"
+    VERSION = "1.1.0"
   end
 end

data/test/integration/no_stats_test.rb

@@ -20,16 +20,16 @@ class NoStatsTest < Minitest::Test
     get '/'
     assert last_response.ok?
 
-    assert_equal nil, counters["rack.request.total"]
-    assert_equal nil, counters["rack.request.status.200"]
-    assert_equal nil, counters["rack.request.status.2xx"]
+    assert_nil counters["rack.request.total"]
+    assert_nil counters["rack.request.status.200"]
+    assert_nil counters["rack.request.status.2xx"]
   end
 
   def test_no_standard_measures
     get '/'
     assert last_response.ok?
 
-    assert_equal nil, aggregate["rack.request.time"]
+    assert_nil aggregate["rack.request.time"]
   end
 
   def test_dont_track_exceptions
@@ -38,7 +38,7 @@ class NoStatsTest < Minitest::Test
     rescue RuntimeError => e
       raise unless e.message == 'exception raised!'
     end
-    assert_equal nil, counters["rack.request.exceptions"]
+    assert_nil counters["rack.request.exceptions"]
   end
 
   private

data/test/integration/no_suites_test.rb

@@ -30,7 +30,7 @@ class NoSuitesTest < Minitest::Test
   def test_track_queue_time
     get '/'
     assert last_response.ok?
-    assert_equal nil, aggregate["rack.request.queue.time"]
+    assert_nil aggregate["rack.request.queue.time"]
   end
 
   def test_increment_status

data/test/integration/request_test.rb

@@ -37,8 +37,8 @@ class RequestTest < Minitest::Test
     assert_equal 1, aggregate["rack.request.time"][:count],
       'should track total request time'
 
-    # should calculte p95 value
-    refute_equal aggregate.fetch("rack.request.time", percentile: 95), 0.0
+    # should calculate p95 value
+    assert aggregate.fetch("rack.request.time", percentile: 95) > 0.0
 
     # status specific
     assert_equal 1, aggregate["rack.request.status.200.time"][:count]

data/test/integration/suites_test.rb

@@ -25,14 +25,14 @@ class SuitesTest < Minitest::Test
     assert_equal 1, aggregate["rack.request.time"][:count]
 
     # rack.request.method metrics (rack_method suite) should not get logged
-    assert_equal nil, counters['rack.request.method.get']
-    assert_equal nil, aggregate['rack.request.method.get.time']
+    assert_nil counters['rack.request.method.get']
+    assert_nil aggregate['rack.request.method.get.time']
 
     # rack.request.status metrics (rack_status suite) should not get logged
-    assert_equal nil, counters["rack.request.status.200"]
-    assert_equal nil, counters["rack.request.status.2xx"]
-    assert_equal nil, counters["rack.request.status.200.time"]
-    assert_equal nil, counters["rack.request.status.2xx.time"]
+    assert_nil counters["rack.request.status.200"]
+    assert_nil counters["rack.request.status.2xx"]
+    assert_nil counters["rack.request.status.200.time"]
+    assert_nil counters["rack.request.status.2xx.time"]
   end
 
   private

data/test/remote/tracker_test.rb

@@ -58,7 +58,7 @@ class TrackerRemoteTest < Minitest::Test
 
       tracker.flush
       assert_equal 0, collector.counters['knightrider']
-      assert_equal nil, collector.counters['badguys']
+      assert_nil collector.counters['badguys']
     end
 
     def test_flush_should_send_measures_and_timings

data/test/unit/collector/aggregator_test.rb

@@ -75,7 +75,7 @@ module Librato
 
       def test_return_values
         simple = @agg.timing 'simple', 20
-        assert_equal nil, simple
+        assert_nil simple
 
         timing = @agg.timing 'foo' do
           sleep 0.1

data/test/unit/collector/counter_cache_test.rb

@@ -60,8 +60,8 @@ module Librato
         assert_equal 0, cc.fetch(:foo, :source => 'bar')
 
         # sporadic do not
-        assert_equal nil, cc[:baz]
-        assert_equal nil, cc.fetch(:baz, :source => 118)
+        assert_nil cc[:baz]
+        assert_nil cc.fetch(:baz, :source => 118)
 
         # add a different sporadic metric
         cc.increment :bazoom, :sporadic => true
@@ -69,7 +69,7 @@ module Librato
 
         # persist values again
         cc.flush_to(Librato::Metrics::Queue.new)
-        assert_equal nil, cc[:bazoom]
+        assert_nil cc[:bazoom]
       end
 
       def test_flushing

data/test/unit/rack/configuration_test.rb

@@ -55,7 +55,7 @@ module Librato
 
       def test_event_mode
         config = Configuration.new
-        assert_equal nil, config.event_mode
+        assert_nil config.event_mode
 
         config.event_mode = :synchrony
         assert_equal :synchrony, config.event_mode
@@ -67,7 +67,7 @@ module Librato
         # handle invalid
         config2 = Configuration.new
         config2.event_mode = 'fooballoo'
-        assert_equal nil, config2.event_mode
+        assert_nil config2.event_mode
 
         # env detection
         ENV['LIBRATO_EVENT_MODE'] = 'eventmachine'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: librato-rack
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.1.0
 platform: ruby
 authors:
 - Matt Sanders
@@ -10,26 +10,26 @@ bindir: bin
 cert_chain:
 - |
   -----BEGIN CERTIFICATE-----
-  MIIDLjCCAhagAwIBAgIBADANBgkqhkiG9w0BAQUFADA9MQ0wCwYDVQQDDARtYXR0
+  MIIDLjCCAhagAwIBAgIBADANBgkqhkiG9w0BAQUFADA9MQ0wCwYDVQQDDARydWJ5
   MRcwFQYKCZImiZPyLGQBGRYHbGlicmF0bzETMBEGCgmSJomT8ixkARkWA2NvbTAe
-  Fw0xNTEwMTIyMjA0MzVaFw0xNjEwMTEyMjA0MzVaMD0xDTALBgNVBAMMBG1hdHQx
+  Fw0xNzAxMTExODI3MDdaFw0xODAxMTExODI3MDdaMD0xDTALBgNVBAMMBHJ1Ynkx
   FzAVBgoJkiaJk/IsZAEZFgdsaWJyYXRvMRMwEQYKCZImiZPyLGQBGRYDY29tMIIB
-  IjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAvfN8RlAsUs+K5kK46SkhpYey
-  54m5bXlGZeqIguOygpG+2FJrUJMCnkQ9RmyK0WUjdmANevW01caQQSx5WatQZso0
-  GfJyJfKn4dGecz9LOEPpblw++qapLXr4vbuOlNXsum2gdUFc4/YV9l3csxClMVEq
-  +ZUmrHjd2koOvzjK+GDRf3iIozCsgY0oeserZ0li/0qRA5ZJeFwWzs9FO9SXPvID
-  Mk07WNaXSRT38llcPGX4L8K+DL7whQwxaFj6IZbobUEtRjzV9v/iP7PiJipijbKB
-  EiefgUuolRR38NxQE+f4M/lEqwEpkY/feYMYF6Q4hXVruG3fswjrDGWyiG5nEQID
-  AQABozkwNzAJBgNVHRMEAjAAMB0GA1UdDgQWBBR8+l0ZSTbj/TT6YVbFFpdGpg7q
-  UDALBgNVHQ8EBAMCBLAwDQYJKoZIhvcNAQEFBQADggEBAKuUiuG2PHv6paQjXjaZ
-  LQOsFunScHyhDhPFh/CcCUDbmXVDOJ3WIyDVQuUgK7I3jPEDaSFezSPBpjwZvgMK
-  0/in7pXLRKjI8CzsY8Y4u122DN9tBxLur+E/kv5fpUbf8FGUSuRT5X3wh6ZBTzsZ
-  EaMe3LpPFUeMShH/H/FEYrexRvaMHo/52Bg0zP0ySSAQDotm+qgMdru2XRDjE5Ms
-  9BheAnoygGHpoKWtExpsklCppL1q2Xlzw2lhoCMLCSSj9T/YyRTL3UQYoK5pPA76
-  hvjx0WJP8pzZMJPKJBRZQXJO5ifEPyKjZyMi5XMHmrtDclHLj3sx4RAvEZjGWkRP
-  JSQ=
+  IjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA58LirwsWnKL1uuClQ0uwA1XL
+  GpxDuFzSosipiPkzZY3hiHazC8SHDREZQXlm7ITX/o+dueNoB7dt0BR3RPVipH7V
+  7cvbCUaZNjEXR5Lal6PsmUsbMTrddkvj3e7flmJv+kMj+teeJ7MDeJTU5wXXV9pD
+  ThiCDILJMF5CdP8Jru4rSBOP6RmmzYU+0cN5+5pt9xqrycA+Poo2ZuoUMCMsSBvl
+  PimM3PPvoWTuE41GTn/bLoOVoXQmdwZIbwUSVH8rCDjZSlttOst+xrBw4KG0dYUp
+  2UvEe8iCyqEMQ8fEZ7EXuP2WMVICutFbz8Pt4hIMq+OTnDX+mIfma7GvPaKAFwID
+  AQABozkwNzAJBgNVHRMEAjAAMB0GA1UdDgQWBBQBSxu9Jj4VTrXTpLujPwk9Kzwp
+  2jALBgNVHQ8EBAMCBLAwDQYJKoZIhvcNAQEFBQADggEBACvNsw1pGv72xp3LiDlZ
+  0tphNP/85RcYyJMklslG3tIYblyo71xHW1UbK5ArUK6k0BN43MuDn3pqLJQttVmi
+  bUdA3yYi13GeSrrAMlr4nH8Yt/Bn/XpZGliouJUBwh1BjG6dSj1iuR4/9pt9/LtO
+  QTdIc+07qGspypT0Uh/w/BodEcGuAaZZFlkU9vottTe6wWNnM6hfRExiSIsr+oVe
+  s8s83ObshjuSzjOqS56IBtNlPEL+D6ghjZZLP3lS6l9p70Pcpcl+IcE4veqZmmKC
+  sGepgRclC6UbZh+yQ3alXVghM2qsonAwI/rTNmFJN9kQn6nP9+f1Uf/qZFNcjn4L
+  9bg=
   -----END CERTIFICATE-----
-date: 2016-08-12 00:00:00.000000000 Z
+date: 2017-01-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: librato-metrics
@@ -77,6 +77,7 @@ description: Rack middleware to report key app statistics and custom instrumenta
   to the Librato Metrics service.
 email:
 - matt@librato.com
+- ruby@librato.com
 executables: []
 extensions: []
 extra_rdoc_files: []
@@ -125,7 +126,7 @@ files:
 - test/unit/rack/worker_test.rb
 homepage: https://github.com/librato/librato-rack
 licenses:
-- BSD 3-clause
+- BSD-3-Clause
 metadata: {}
 post_install_message: 
 rdoc_options: []
@@ -143,7 +144,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5.1
+rubygems_version: 2.6.8
 signing_key: 
 specification_version: 4
 summary: Use Librato Metrics with your rack application