librato-rack 0.4.2 → 0.4.3

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+### Version 0.4.3
+* Update queue wait support to tolerate float-style timestamps
+
 ### Version 0.4.2
 * Move gem sign code to rake task, fixes bug bundling in some environments
 

data/lib/librato/rack.rb

@@ -103,13 +103,13 @@ module Librato
     def record_header_metrics(env)
       queue_start = env['HTTP_X_REQUEST_START'] || env['HTTP_X_QUEUE_START']
       if queue_start
-        queue_start = queue_start.to_s.gsub('t=', '').to_i
-        case queue_start.to_s.length
+        queue_start = queue_start.to_s.sub('t=', '').sub('.', '')
+        case queue_start.length
         when 16 # microseconds
-          wait = ((Time.now.to_f * 1000000).to_i - queue_start) / 1000.0
+          wait = ((Time.now.to_f * 1000000).to_i - queue_start.to_i) / 1000.0
           tracker.timing 'rack.request.queue.time', wait
         when 13 # milliseconds
-          wait = (Time.now.to_f * 1000).to_i - queue_start
+          wait = (Time.now.to_f * 1000).to_i - queue_start.to_i
           tracker.timing 'rack.request.queue.time', wait
         end
       end

data/lib/librato/rack/version.rb

@@ -1,5 +1,5 @@
 module Librato
   class Rack
-    VERSION = "0.4.2"
+    VERSION = "0.4.3"
   end
 end

data/test/apps/queue_wait.ru

@@ -23,6 +23,9 @@ class QueueWait
     when '/with_t'
       env['HTTP_X_REQUEST_START'] = "t=#{(Time.now.to_f * 1000000).to_i}".to_s
       sleep 0.02
+    when '/with_period'
+      env['HTTP_X_REQUEST_START'] = "%10.3f" % Time.now
+      sleep 0.025
     end
     @app.call(env)
   end

data/test/integration/queue_wait_test.rb

@@ -52,6 +52,16 @@ class QueueWaitTest < Minitest::Test
     assert_in_delta 20, aggregate["rack.request.queue.time"][:sum], 4
   end
 
+  def test_with_period
+    get '/with_period'
+
+    # give jruby a bit more time since it can be slow
+    delta = defined?(JRUBY_VERSION) ? 10 : 4
+    assert_equal 1, aggregate["rack.request.queue.time"][:count],
+      'should track total queue time'
+    assert_in_delta 25, aggregate["rack.request.queue.time"][:sum], delta
+  end
+
   private
 
   def aggregate

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: librato-rack
 version: !ruby/object:Gem::Version
-  version: 0.4.2
+  version: 0.4.3
   prerelease: 
 platform: ruby
 authors:
@@ -37,7 +37,7 @@ cert_chain:
   bktaNmhlblFBRjFDSDk2WmNxY0pIMTc5UzJ0SWlLRE04a2VlUklVT1BDM1dU
   MGZhb2svMgpnQTJvemRyODUxYy9uQT09Ci0tLS0tRU5EIENFUlRJRklDQVRF
   LS0tLS0K
-date: 2013-08-26 00:00:00.000000000 Z
+date: 2013-09-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: librato-metrics
@@ -131,7 +131,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -1690742337957638692
+      hash: 2186855998038082473
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -140,7 +140,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -1690742337957638692
+      hash: 2186855998038082473
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.23

metadata.gz.sig

@@ -1,3 +1 @@
-�L����x]�j���Z�y��� z�2x�g���C��z���8���j���C��y�g����
-���q2E���)��:Og�� �e0R|��I���x�KΎ��NDAnN��@skb ���?��*�'�I6ᯇ�i���?���˗Sa���`�I3�̝�
-�xه���H^�
��{3�qn�̦�<��ܺ�u@gd��iO\��S�OWt2�roWmYӎ�d{J�~T���;�кIzR^� pq�]��
+<�Z��M���Z�8B��I��d�p*�f�[��'��!�l