lhs 7.2.1 → 7.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 438db5368d4104d56de30c647d820ed788cecdcf
-  data.tar.gz: c1fa77d04b224f5abb3761ef0999559d4afde596
+  metadata.gz: 362edc3fc0fc431ab0a20d6579d13098ad00f06a
+  data.tar.gz: 9505d7594bbdc3a073796407c257a979df0b8bcb
 SHA512:
-  metadata.gz: ea1065bb1fca7054692d37d2ce43e0f12f4cd27536cf4f9f386d579460541856afdfce3b811b87efbe821c24b23eff3f8c2b5e3016ed493a58ade79464a0b6f6
-  data.tar.gz: 254cea22f98f880082a51f83987ee0cf419d20475d4c51aacd796ef9982f6183f61645d0bc04b133419c212167697d3f241bfee58dbda840711ebff5e63561a7
+  metadata.gz: 9c14a4998fcbeabf8a2e0f843e72e3afea543bcfe2489b8ce37587f9ced6b7bc98f2bf9dc7fcc07da82d283d87e4600ac313bc573c6a82518cc5e5785fd26c0b
+  data.tar.gz: 5ddebec7d8435c702ed31d157d83027a332c73fad654ec40cf281b7aca098f84f3a5af8c10ae2160a46920f50336c87310fd0ec205236bb3c4b2589789d8d805

data/lib/lhs/concerns/item/save.rb

@@ -8,8 +8,7 @@ class LHS::Item < LHS::Proxy
 
     def save(options = nil)
       save!(options)
-    rescue LHC::Error => e
-      self.errors = LHS::Errors.new(e.response)
+    rescue LHC::Error
       false
     end
 
@@ -33,6 +32,9 @@ class LHS::Item < LHS::Proxy
       data = record_for_persistance.request(options)
       _data.merge_raw!(data)
       true
+    rescue LHC::Error => e
+      self.errors = LHS::Errors.new(e.response)
+      raise e
     end
 
     private

data/lib/lhs/version.rb

@@ -1,3 +1,3 @@
 module LHS
-  VERSION = "7.2.1"
+  VERSION = "7.2.2"
 end

data/spec/item/errors_spec.rb

@@ -59,11 +59,11 @@ describe LHS::Item do
   end
 
   context 'save failed' do
+    let(:record) { Record.build(name: 'Steve') }
+
     it 'parses fields correctly when creation failed' do
       stub_request(:post, "#{datastore}/feedbacks")
         .to_return(status: 400, body: error_format_fields.to_json)
-      record = Record.build
-      record.name = 'Steve'
       result = record.save
       expect(result).to eq false
       expect(record.errors).to be
@@ -78,8 +78,6 @@ describe LHS::Item do
     it 'parses field errors correctly when creation failed' do
       stub_request(:post, "#{datastore}/feedbacks")
         .to_return(status: 400, body: error_format_field_errors.to_json)
-      record = Record.build
-      record.name = 'Steve'
       result = record.save
       expect(result).to eq false
       expect(record.errors).to be
@@ -89,6 +87,19 @@ describe LHS::Item do
       expect(record.errors[:gender]).to eq ['UNSUPPORTED_PROPERTY_VALUE', 'INCOMPLETE_PROPERTY_VALUE']
       expect(record.errors[:"contract.entry_id"]).to eq ['INCOMPLETE_PROPERTY_VALUE']
     end
+
+    it 'parses field errors correctly when exception in raised' do
+      stub_request(:post, "#{datastore}/feedbacks")
+        .to_return(status: 400, body: error_format_fields.to_json)
+      expect { record.save! }.to raise_error(LHC::BadRequest)
+      expect(record.errors).to be
+      expect(record.errors.any?).to eq true
+      expect(record.name).to eq 'Steve'
+      expect(record.errors.include?(:ratings)).to eq true
+      expect(record.errors.include?(:recommended)).to eq true
+      expect(record.errors[:ratings]).to eq ['REQUIRED_PROPERTY_VALUE', 'UNSUPPORTED_PROPERTY_VALUE']
+      expect(record.errors[:recommended]).to eq ['REQUIRED_PROPERTY_VALUE']
+    end
   end
 
   context 'raw error data' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lhs
 version: !ruby/object:Gem::Version
-  version: 7.2.1
+  version: 7.2.2
 platform: ruby
 authors:
 - https://github.com/local-ch/lhs/graphs/contributors
@@ -376,7 +376,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements:
 - Ruby >= 2.0.0
 rubyforge_project: 
-rubygems_version: 2.6.8
+rubygems_version: 2.5.2
 signing_key: 
 specification_version: 4
 summary: Rails gem providing an easy, active-record-like interface for http json services