lhs 7.2.0 → 7.2.1

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA1:
3
- metadata.gz: 2de08930a39d1136d185c43d33b8353abe09847d
4
- data.tar.gz: 0ff2a9b46b4d66aece4ec6c7eeb33b5124511a5f
3
+ metadata.gz: 438db5368d4104d56de30c647d820ed788cecdcf
4
+ data.tar.gz: c1fa77d04b224f5abb3761ef0999559d4afde596
5
5
  SHA512:
6
- metadata.gz: 047e5066a227d3631690a4f61d90c21fe9ca8424ee0361713a552700ca54f890fbb7f4de58654de3b12ac8f819e6fe1a673c4588a89d9aee61221fb9c89e414f
7
- data.tar.gz: 8ca3222a86205b07a1e853073f365729137c941642c4b500f359c4a9b70dd68d3d4e8463deec067fb46c51ce988136cd8675e5f82fb79b9cf2b26d26cfff0ae8
6
+ metadata.gz: ea1065bb1fca7054692d37d2ce43e0f12f4cd27536cf4f9f386d579460541856afdfce3b811b87efbe821c24b23eff3f8c2b5e3016ed493a58ade79464a0b6f6
7
+ data.tar.gz: 254cea22f98f880082a51f83987ee0cf419d20475d4c51aacd796ef9982f6183f61645d0bc04b133419c212167697d3f241bfee58dbda840711ebff5e63561a7
@@ -5,11 +5,13 @@ class LHS::Errors
5
5
  attr_reader :messages, :message, :raw
6
6
 
7
7
  def initialize(response = nil)
8
+ @raw = response.body if response
8
9
  @messages = messages_from_response(response)
9
10
  @message = message_from_response(response)
10
- @raw = response.body if response
11
11
  rescue JSON::ParserError
12
- add_error(messages, 'body', 'parse error')
12
+ @messages = messages || {}
13
+ @message = 'parse error'
14
+ add_error(@messages, 'body', 'parse error')
13
15
  end
14
16
 
15
17
  def include?(attribute)
@@ -1,3 +1,3 @@
1
1
  module LHS
2
- VERSION = "7.2.0"
2
+ VERSION = "7.2.1"
3
3
  end
@@ -46,6 +46,10 @@ describe LHS::Item do
46
46
  }
47
47
  end
48
48
 
49
+ let(:unparsable_error_body) do
50
+ '<html></html>'
51
+ end
52
+
49
53
  before(:each) do
50
54
  LHC.config.placeholder(:datastore, datastore)
51
55
  class Record < LHS::Record
@@ -129,4 +133,17 @@ describe LHS::Item do
129
133
  expect(record.errors['body']).to eq ['parse error']
130
134
  end
131
135
  end
136
+
137
+ context 'unparsable error body' do
138
+ it 'still tells us that there is an error' do
139
+ stub_request(:post, "#{datastore}/feedbacks").to_return(status: 400, body: unparsable_error_body)
140
+ record = Record.build
141
+ record.name = 'Steve'
142
+ result = record.save
143
+ expect(result).to eq false
144
+ expect(record.errors).to be
145
+ expect(record.errors.any?).to eq true
146
+ expect(record.errors['body']).to eq ['parse error']
147
+ end
148
+ end
132
149
  end
metadata CHANGED
@@ -1,7 +1,7 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: lhs
3
3
  version: !ruby/object:Gem::Version
4
- version: 7.2.0
4
+ version: 7.2.1
5
5
  platform: ruby
6
6
  authors:
7
7
  - https://github.com/local-ch/lhs/graphs/contributors
@@ -376,7 +376,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
376
376
  requirements:
377
377
  - Ruby >= 2.0.0
378
378
  rubyforge_project:
379
- rubygems_version: 2.5.2
379
+ rubygems_version: 2.6.8
380
380
  signing_key:
381
381
  specification_version: 4
382
382
  summary: Rails gem providing an easy, active-record-like interface for http json services