lhs 6.6.1 → 6.6.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: aa5cf18487994a26df91043ecaa517405b402252
-  data.tar.gz: ebeb9db697bd0f9473f47b4c7799cce6ec3924b4
+  metadata.gz: 28bbd84604d97fb4b2832870a1af4e19c8a4dd7b
+  data.tar.gz: cee59479f3b13012abaca1454f2bb5a09c884768
 SHA512:
-  metadata.gz: b1e5469075aaf9ed16e0c00bfa3177c4bed573a50bedb29bc2741c77fa94147d021d77e433c0c40d63d6e7b999fe727d4147c05c6cd168cb6b683c49e286bf58
-  data.tar.gz: 255bffac0457942147dce4bccdb6484c455a93ed4c9bfe4a4d6d73d9067d03bb496f300d5af35f22912c7b74827c0a9703b6e3fef182f3f3c8570e0555a3beaf
+  metadata.gz: 2d42b4b4fe655bb825b3877e19f13f6f431207daa6cadd4484de828516de2b4b546314a363ec0c08b0896e6dc4d437fd3966c8898143f128077f92d906f4da26
+  data.tar.gz: f85c70878edb8a4d13d7915e261c71bcf1c3601679615cb9972e1279898fd9aaa315014893a8493b94ee81e7157c0d30a93a898fe5d01adc906cd5568bceb11f

data/README.md

@@ -297,31 +297,44 @@ Sometimes it is the case that you want to have your custom getters and setters a
 The initializer will now use custom setter if one is defined:
 
 ```ruby
-class Record < LHS::Record
-  def ratings=(ratings)
-    _raw[:ratings] = ratings.map { |k, v| { name: k, value: v } }
+
+module RatingsConversions
+  def ratings=(values)
+    super(
+      values.map { |k, v| { name: k, value: v } }
+    )
   end
 end
 
-record = Record.new(ratings: { quality: 3 }) # <Record{:ratings=>[{:name=>:quality, :value=>3}]}>
-record.ratings # #<LHS::Data:0x007fc8fa6d4050 ... @_raw=[{:name=>:quality, :value=>3}]>
+class Record < LHS::Record
+  prepend RatingsConversions
+end
+
+record = Record.new(ratings: { quality: 3 })
+record.ratings # [{ :name=>:quality, :value=>3 }]
 
 ```
 
 If you have an accompanying getter the whole data manipulation would be internal only.
 
 ```ruby
-class Record < LHS::Record
-  def ratings=(ratings)
-    _raw[:ratings] = ratings.map { |k, v| { name: k, value: v } }
+module RatingsConversions
+  def ratings=(values)
+    super(
+      values.map { |k, v| { name: k, value: v } }
+    )
   end
 
   def ratings
-    Hash[_raw[:ratings].map { |r| [r[:name], r[:value]] }]
+    super.map { |r| [r[:name], r[:value]] }]
   end
 end
 
-record = Record.new(ratings: { quality: 3 }) # <Record{:ratings=>[{:name=>:quality, :value=>3}]}>
+class Record < LHS::Record
+  prepend RatingsConversions
+end
+
+record = Record.new(ratings: { quality: 3 }) # [{ :name=>:quality, :value=>3 }]
 record.ratings # {:quality=>3}
 
 ```

data/lib/lhs/item.rb

@@ -33,7 +33,7 @@ class LHS::Item < LHS::Proxy
     value = _data._raw[name.to_s]
     if value.nil? && _data._raw.present?
       value = _data._raw[name.to_sym]
-      value ||= _data._raw[name.to_s.classify.to_sym]
+      value = _data._raw[name.to_s.classify.to_sym] if value.nil?
     end
     if value.is_a?(Hash)
       handle_hash(value)

data/lib/lhs/version.rb

@@ -1,3 +1,3 @@
 module LHS
-  VERSION = "6.6.1"
+  VERSION = "6.6.2"
 end

data/spec/collection/delegate_spec.rb

@@ -1,13 +1,13 @@
 require 'rails_helper'
 
 describe LHS::Collection do
-  let(:data) {
+  let(:data) do
     ['ROLE_USER', 'ROLE_LOCALCH_ACCOUNT']
-  }
+  end
 
-  let(:collection){
+  let(:collection) do
     LHS::Collection.new(LHS::Data.new(data))
-  }
+  end
 
   context 'delegates methods to raw' do
     %w(present? blank? empty?).each do |method|

data/spec/collection/enumerable_spec.rb

@@ -1,13 +1,13 @@
 require 'rails_helper'
 
 describe LHS::Collection do
-  let(:data) {
+  let(:data) do
     [1, 2, 3]
-  }
+  end
 
-  let(:collection){
+  let(:collection) do
     LHS::Collection.new(LHS::Data.new(data))
-  }
+  end
 
   context 'enumerable' do
     it 'works with map' do

data/spec/collection/respond_to_spec.rb

@@ -1,13 +1,13 @@
 require 'rails_helper'
 
 describe LHS::Collection do
-  let(:data) {
+  let(:data) do
     ['ROLE_USER', 'ROLE_LOCALCH_ACCOUNT']
-  }
+  end
 
-  let(:collection){
+  let(:collection) do
     LHS::Data.new(LHS::Data.new(data))
-  }
+  end
 
   context '#respond_to?' do
     # In this case raw collection is an Array implementing first

data/spec/data/collection_spec.rb

@@ -17,13 +17,13 @@ describe LHS::Data do
 
   context 'collections' do
     it 'forwards calls to the collection' do
-      expect(data.count).to be_kind_of Fixnum
+      expect(data.count).to be_kind_of Integer
       expect(data[0]).to be_kind_of LHS::Data
       expect(data.sample).to be_kind_of LHS::Data
     end
 
     it 'provides a total method to get the number of total records' do
-      expect(data.total).to be_kind_of Fixnum
+      expect(data.total).to be_kind_of Integer
     end
   end
 

data/spec/item/respond_to_spec.rb

@@ -1,9 +1,9 @@
 require 'rails_helper'
 
 describe LHS::Item do
-  let(:item){
+  let(:item) do
     LHS::Item.new(id: 1234)
-  }
+  end
 
   context '#respond_to?' do
     it 'is true for setters' do

data/spec/item/setter_spec.rb

@@ -32,5 +32,11 @@ describe LHS::Item do
       expect((item.name = nil)).to eq nil
       expect(item.name).to eq nil
     end
+
+    it 'sets things to false' do
+      item.recommended = true
+      expect((item.recommended = false)).to eq false
+      expect(item.recommended).to eq false
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lhs
 version: !ruby/object:Gem::Version
-  version: 6.6.1
+  version: 6.6.2
 platform: ruby
 authors:
 - https://github.com/local-ch/lhs/graphs/contributors
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-09-16 00:00:00.000000000 Z
+date: 2016-09-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lhc
@@ -356,7 +356,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements:
 - Ruby >= 2.0.0
 rubyforge_project: 
-rubygems_version: 2.4.8
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Rails gem providing an easy, active-record-like interface for http json services