lhs 6.5.0 → 6.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 79a4e6c3e274aa01035b67be3b5eeff82c68ddbd
-  data.tar.gz: 9c9362c9aeed7f7e2ed352eb22701b0bce023a22
+  metadata.gz: 03af8ee3ccf17c8a75304d5c3f3ce6e395ef51dc
+  data.tar.gz: 60292bdfe213362cc375f32ac399bc26945d28d2
 SHA512:
-  metadata.gz: 7cebde70543152187087c61cdfd89eb996ea93421393e3abd6062e63da99ba30a4f4ebc4abbd32474ed7f2ea9a3e7afc19c486881af22600d639b0184f8e17a3
-  data.tar.gz: b066b19b120054d863ab7c18f134796c70f7ba0ae84ec1d7a60280188ea2aefd2e48f91326a3c9f847c938a806c1da1e8dec6c0625503e7160da4d9166cb32dd
+  metadata.gz: 47a6488f9d1a9dcd99b90e4cc5ef81bc16fdeb1559cf589ecd36fdacdf0d00c173d20f62743bc28b7e114ed64463a694e0709532a4c08d7fca01f8ae41124774
+  data.tar.gz: 88559585cc42b9f679038c2b8cf9005ce2d7ae3ffe2ab9997028d77105d37153f78647952555a0dfd7b4cb476c4a29a74d49da07b800c746e41974a7c19d38ad

data/README.md

@@ -534,6 +534,13 @@ class User < LHS::Record
 end
 ```
 
+## Custom validation errors
+
+In case you want to add custom validation errors to an instance of LHS::Record:
+
+```ruby
+user.errors.add(:name, 'The name you provided is not valid.')
+```
 
 ## Pagination
 

data/lib/lhs/errors.rb

@@ -4,10 +4,10 @@ class LHS::Errors
 
   attr_reader :messages, :message, :raw
 
-  def initialize(response)
+  def initialize(response = nil)
     @messages = messages_from_response(response)
     @message = message_from_response(response)
-    @raw = response.body
+    @raw = response.body if response
   rescue JSON::ParserError # rubocop:disable Lint/HandleExceptions
   end
 
@@ -17,6 +17,11 @@ class LHS::Errors
   alias has_key? include?
   alias key? include?
 
+  def add(attribute, message = :invalid, _options = {})
+    self[attribute]
+    messages[attribute] << message
+  end
+
   def get(key)
     messages[key]
   end
@@ -81,13 +86,14 @@ class LHS::Errors
     messages
   end
 
-  def messages_from_response(response)
-    return {} if !response.body.is_a?(String) || response.body.length.zero?
+  def messages_from_response(response = nil)
+    return {} if !response || !response.body.is_a?(String) || response.body.length.zero?
     json = JSON.parse(response.body)
     parse_messages(json)
   end
 
-  def message_from_response(response)
+  def message_from_response(response = nil)
+    return unless response
     json = JSON.parse(response.body)
     json['message']
   end

data/lib/lhs/item.rb

@@ -16,6 +16,11 @@ class LHS::Item < LHS::Proxy
 
   delegate :_raw, to: :_data
 
+  def initialize(data)
+    self.errors = LHS::Errors.new
+    super(data)
+  end
+
   def item?
     true
   end

data/lib/lhs/version.rb

@@ -1,3 +1,3 @@
 module LHS
-  VERSION = "6.5.0"
+  VERSION = "6.6.0"
 end

data/spec/item/add_error_spec.rb

@@ -0,0 +1,19 @@
+require 'rails_helper'
+
+describe LHS::Item do
+  before(:each) do
+    class Record < LHS::Record
+    end
+  end
+
+  subject { Record.new }
+
+  context 'add error' do
+    it 'allows to add validation errors to the instance itself' do
+      subject.errors.add(:name, 'This date is invalid')
+      expect(
+        subject.errors.first
+      ).to eq [:name, 'This date is invalid']
+    end
+  end
+end

data/spec/record/create_spec.rb

@@ -26,7 +26,8 @@ describe LHS::Record do
       record = Feedback.create(object)
       expect(record).to be_kind_of Feedback
       expect(record.recommended).to eq true
-      expect(record.errors).to eq nil
+      expect(record.errors.messages).to eq({})
+      expect(record.errors.message).to eq nil
     end
 
     it 'uses proper endpoint when creating data' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lhs
 version: !ruby/object:Gem::Version
-  version: 6.5.0
+  version: 6.6.0
 platform: ruby
 authors:
 - https://github.com/local-ch/lhs/graphs/contributors
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-09-12 00:00:00.000000000 Z
+date: 2016-09-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lhc
@@ -273,6 +273,7 @@ files:
 - spec/dummy/public/favicon.ico
 - spec/endpoint/for_url_spec.rb
 - spec/item/accessors_spec.rb
+- spec/item/add_error_spec.rb
 - spec/item/delegate_spec.rb
 - spec/item/destroy_spec.rb
 - spec/item/errors_spec.rb
@@ -420,6 +421,7 @@ test_files:
 - spec/dummy/public/favicon.ico
 - spec/endpoint/for_url_spec.rb
 - spec/item/accessors_spec.rb
+- spec/item/add_error_spec.rb
 - spec/item/delegate_spec.rb
 - spec/item/destroy_spec.rb
 - spec/item/errors_spec.rb