lhs 6.3.0 → 6.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3e5f67d6a0394eaf9742357631505c14ecf0d308
-  data.tar.gz: 725d43ea3e43f8374e210b5d29a0e54fde5d4a11
+  metadata.gz: e9f38d7e7d79b9099b282d29cdd8c126d9ec2a97
+  data.tar.gz: b01e749df675ef68f1a13923a7d73b2317a58614
 SHA512:
-  metadata.gz: 5344e79fe480861ae6fe214f9c5fd7f19fb6bfaa754a99dc9afecb2de9efb636b1f80f3b76c7a6e0a23c1efa20e7264a884d8253a7c5c020c23e2b838cb637e8
-  data.tar.gz: b060a234369822f4dd32b945d576cf089e9e56352bd3ced2ee26aeb62c604f48e9febb72fb226c34ed723039ad012efe469ddabe71319264824b95a074726913
+  metadata.gz: ac30a7cd582675b6ba8d7b02748563b64ee6c572858102dcccd9be8db7e70213575dc5a35ded169449d738c78d6a79636df1eb35b0ffe48f068814038c59be93
+  data.tar.gz: 8eb224deb70fa275b5ea13722854ee1d4a971f9ffa509c468aafd74dbf7684edc2a0d37551ff876733d87137b82386cd50c41b18cb9797f07217495b43ca5b68

data/lib/lhs/record.rb

@@ -25,7 +25,7 @@ class LHS::Record
     data = LHS::Data.new({}, nil, self.class) unless data
     data = LHS::Data.new(data, nil, self.class) unless data.is_a?(LHS::Data)
     define_singleton_method(:_data) { data }
-    consider_custom_setters
+    apply_custom_setters!
   end
 
   def as_json(options = nil)
@@ -48,20 +48,13 @@ class LHS::Record
 
   private
 
-  def consider_custom_setters
-    return if !instance_data.is_a?(Hash)
-    instance_data.each do |k, v|
-      if public_methods.include?("#{k}=".to_sym)
-        send("#{k}=", v)
-      end
-    end
-  end
-
-  def instance_data
-    if _data._proxy.is_a?(LHS::Collection) && _data._raw.is_a?(Hash)
-      _data._raw.fetch(:items, [])
-    else
-      _data._raw
+  def apply_custom_setters!
+    return if !_data.item? || !_data._raw.respond_to?(:keys)
+    raw = _data._raw
+    custom_setters = raw.keys.find_all { |key| public_methods.include?("#{key}=".to_sym) }
+    custom_setters.each do |setter|
+      value = raw.delete(setter)
+      send("#{setter}=", value)
     end
   end
 end

data/lib/lhs/version.rb

@@ -1,3 +1,3 @@
 module LHS
-  VERSION = "6.3.0"
+  VERSION = "6.3.1"
 end

data/spec/record/create_spec.rb

@@ -73,7 +73,7 @@ describe LHS::Record do
           .to_return(status: 400, body: creation_error.to_json)
         expect(lambda {
           Feedback.create!(object.merge(campaign_id: '12345'))
-        }).to raise_error
+        }).to raise_error(LHC::Error)
       end
     end
 

data/spec/record/endpoint_misconfiguration_spec.rb

@@ -10,7 +10,8 @@ describe LHS::Record do
             endpoint ':datastore/v2/reviews'
           end
         }
-      ).to raise_error
+      ).to raise_error(/Clashing endpoints/)
+
       expect(
         lambda {
           class Record < LHS::Record
@@ -18,7 +19,7 @@ describe LHS::Record do
             endpoint ':datastore/v2/:campaign_id/reviews'
           end
         }
-      ).to raise_error
+      ).to raise_error(/Clashing endpoints/)
     end
   end
 end

data/spec/record/inspect_spec.rb

@@ -6,21 +6,40 @@ describe LHS::Record do
       endpoint 'http://datastore/records/:id'
     end
     stub_request(:get, "http://datastore/records/1")
-      .to_return(body: {
-        name: 'Steve',
-        kind: {
-          animal: {
-            type: 'Monkey'
-          }
-        }
-      }.to_json)
+      .to_return(body: attrbitutes.to_json)
   end
 
   let(:record) { Record.find(1) }
+  let(:attrbitutes) do
+    {
+      name: 'Steve',
+      kind: {
+        animal: {
+          type: 'Monkey'
+        }
+      }
+    }
+  end
+
+  let(:output) { "Record##{record.object_id}\n:name => \"Steve\"\n:kind => {:animal=>{:type=>\"Monkey\"}}" }
 
   context 'inspect' do
     it 'prints the record on the terminal: each attrbitute on a new line' do
-      expect(record.inspect).to eq "Record##{record.object_id}\n:name => \"Steve\"\n:kind => {:animal=>{:type=>\"Monkey\"}}"
+      expect(record.inspect).to eq(output)
+    end
+
+    context 'with custom setters that do no touch raw data' do
+      before do
+        class Record
+          attr_accessor :listing
+        end
+      end
+
+      let(:record) { Record.new(attrbitutes.merge(listing: double('listing'))) }
+
+      it 'does not print what is not in raw' do
+        expect(record.inspect).to eq(output)
+      end
     end
   end
 end

data/spec/record/new_spec.rb

@@ -65,6 +65,26 @@ describe LHS::Record do
         expect(feedback.ratings.first.name).to eq :z
       end
 
+      context 'that do not affect raw data' do
+        before(:each) do
+          class Rating
+            attr_accessor :listing
+          end
+        end
+
+        let(:listing) { double('listing') }
+
+        it 'are used by initializer' do
+          feedback = Rating.new(listing: listing)
+          expect(feedback.listing).to eq(listing)
+        end
+
+        it 'do not set raw data' do
+          feedback = Rating.new(listing: listing)
+          expect(feedback._raw[:listing]).to be_nil
+        end
+      end
+
       context 'and custom getters' do
         before(:each) do
           class Rating

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lhs
 version: !ruby/object:Gem::Version
-  version: 6.3.0
+  version: 6.3.1
 platform: ruby
 authors:
 - https://github.com/local-ch/lhs/graphs/contributors
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-04 00:00:00.000000000 Z
+date: 2016-08-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lhc
@@ -351,7 +351,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements:
 - Ruby >= 2.0.0
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.6.5
 signing_key: 
 specification_version: 4
 summary: Rails gem providing an easy, active-record-like interface for http json services