lhs 5.4.0 → 5.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 80529532ef8aaafcbe7822abac42c0082f2b2b32
-  data.tar.gz: f3b872fa678981d24ccfdcc24af642a397cffac4
+  metadata.gz: 24363abbc61959e5dfb50fcaa161fdaa317472e6
+  data.tar.gz: 5f39eab662c51ce10d43ef3fe2acb2b03b9de7e4
 SHA512:
-  metadata.gz: bbfea24429cac66bfc5684d31411ed975456d52be8110df299dcd762b2771205e4827b9fcb183305e9444cd0f3e3165fc8b3cf055c5352504f485fbb45cd890a
-  data.tar.gz: 47678b919459a2a896995a01588d1c29876982324872d889dbef21297ff57dc76674561fae8d1f98062ab6dc6e93058c9e9cd608b1cb373c89db4a23b1c3a3c0
+  metadata.gz: 804ebde5bc541230d27e6dfacb0ea6bade3898635f2203317ffa73516e5008d0d75db8800620f9dc540fc2b9063d22ee7b27628e42b540208e8ecdebcb157cb6
+  data.tar.gz: 468a884356c6c09757bc9d7defc8fcbfd3a78353d59a77430da317a4fae1850dad16caeeac4c777df5d5ce2272fcfc9686059acdcfa59e9fde3e879e8e719006

data/README.md

@@ -126,9 +126,6 @@ The example would fetch records with the following parameters: `{color: blue, vi
 
 If no record is found an error is raised.
 
-## Proxy
-Instead of mapping data when it arrives from the service, the proxy makes data accessible when you access it, not when you fetch it. The proxy is used to access data and it is divided in `Collection` and `Item`.
-
 `find` can also be used to find a single uniqe record with parameters:
 
 ```ruby
@@ -304,8 +301,8 @@ The implementation is heavily influenced by [http://guides.rubyonrails.org/activ
   claims = Claims.includes(:localch_account).where(place_id: 'huU90mB_6vAfUdVz_uDoyA')
   claims.first.localch_account.email # 'test@email.com'
 ```
-* [see the JSON without include](examples/claim_no_include.json)
-* [see the JSON with include](examples/claim_with_include.json)
+* [see the JSON without include](docs/examples/claim_no_include.json)
+* [see the JSON with include](docs/examples/claim_with_include.json)
 
 ### Two-Level `includes`
 

data/lib/lhs/concerns/record/chainable.rb

@@ -63,13 +63,15 @@ class LHS::Record
     class Chain
 
       # Instance exec is required for scope chains
-      delegated_methods = Object.instance_methods - [:instance_exec]
+      delegated_methods = Object.instance_methods - [:instance_exec, :clone]
       delegate(*delegated_methods, to: :resolve)
 
+      attr_accessor :_links
+
       def initialize(record_class, link, record = nil)
         @record_class = record_class
         @record = record
-        @chain = [link].compact
+        self._links = [link].compact
       end
 
       def create(data = {})
@@ -180,20 +182,21 @@ class LHS::Record
       private
 
       def push(link)
-        @chain += [link].compact
-        self
+        clone = self.clone
+        clone._links = _links + [link].compact
+        clone
       end
 
       def chain_parameters
-        merge_links @chain.select { |link| link.is_a? Parameter }
+        merge_links _links.select { |link| link.is_a? Parameter }
       end
 
       def chain_options
-        merge_links @chain.select { |link| link.is_a? Option }
+        merge_links _links.select { |link| link.is_a? Option }
       end
 
       def chain_pagination
-        resolve_pagination @chain.select { |link| link.is_a? Pagination }
+        resolve_pagination _links.select { |link| link.is_a? Pagination }
       end
 
       def resolve_pagination(links)

data/lib/lhs/version.rb

@@ -1,3 +1,3 @@
 module LHS
-  VERSION = "5.4.0"
+  VERSION = "5.4.1"
 end

data/spec/record/immutable_chains_spec.rb

@@ -0,0 +1,20 @@
+require 'rails_helper'
+
+describe LHS::Record do
+  before(:each) do
+    class Record < LHS::Record
+      endpoint 'http://local.ch/v2/records'
+    end
+  end
+
+  it 'always returns a new chain and does not mutate the original' do
+    blue_request = stub_request(:get, "http://local.ch/v2/records?color=blue").to_return(body: [].to_json)
+    blue_records = Record.where(color: 'blue')
+    blue_active_request = stub_request(:get, "http://local.ch/v2/records?color=blue&active=true").to_return(body: [].to_json)
+    active_blue_records = blue_records.where(active: true)
+    blue_records.first
+    active_blue_records.first
+    assert_requested(blue_request)
+    assert_requested(blue_active_request)
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lhs
 version: !ruby/object:Gem::Version
-  version: 5.4.0
+  version: 5.4.1
 platform: ruby
 authors:
 - https://github.com/local-ch/lhs/graphs/contributors
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-05-24 00:00:00.000000000 Z
+date: 2016-05-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lhc
@@ -297,6 +297,7 @@ files:
 - spec/record/find_in_batches_spec.rb
 - spec/record/find_spec.rb
 - spec/record/first_spec.rb
+- spec/record/immutable_chains_spec.rb
 - spec/record/includes_spec.rb
 - spec/record/loading_twice_spec.rb
 - spec/record/mapping_spec.rb
@@ -435,6 +436,7 @@ test_files:
 - spec/record/find_in_batches_spec.rb
 - spec/record/find_spec.rb
 - spec/record/first_spec.rb
+- spec/record/immutable_chains_spec.rb
 - spec/record/includes_spec.rb
 - spec/record/loading_twice_spec.rb
 - spec/record/mapping_spec.rb