lhs 3.1.0 → 3.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4b4d8da57cb83a4edce0d5a3ced7289528fc3aeb
-  data.tar.gz: cd8ca6b468931ce8a677ee0ec686a04c05798d75
+  metadata.gz: f4f70cff889440ba4d2bca3c7b4d9480a763a2af
+  data.tar.gz: b8d18ad5a5a3951b24d96e9de37073fbd199267a
 SHA512:
-  metadata.gz: 4f4f26c5cc042bf73e69c0ff021e5ce5b32d4fabf5afe8b692b5a6ececad255759aa86eda2d78a21031f0bca8481769bce809ebf45535c8eab478b8fdbea37e0
-  data.tar.gz: 9672198becdb370e7775f8a922e613ee1ee7f28936f13672b936619e582c0cec3127bec258250e2dd14fa24db439e25d02af25b2a662d34cffd81e7faf1e2f58
+  metadata.gz: eebcb68bb74d56f301e44928874e72fc9e02c6754a21bd4a92bdec2200d26de45e49199bfc29366e2b3e8063ee28108eaf1cb3d9df1040e6c5f5a7027c09f323
+  data.tar.gz: 1a402c99a72282ecac133bb3de3627851cbe9ee79378ab8dbac9792fdaa4aff429064d653b7e011cbe1e0c3e6ccf850c035ccb76bcbcd17e62f776c599e743f1

data/lib/lhs/concerns/record/includes.rb

@@ -16,7 +16,7 @@ class LHS::Record
 
       def includes(*args)
         name = "#{self}#{args.object_id}"
-        constant = Object.const_set(name, self)
+        constant = Object.const_set(name.demodulize, self)
         class_clone = constant
         class_clone.endpoints = endpoints
         class_clone.mapping = mapping

data/lib/lhs/version.rb

@@ -1,3 +1,3 @@
 module LHS
-  VERSION = "3.1.0"
+  VERSION = "3.1.1"
 end

data/spec/collection/collection_items_spec.rb

@@ -0,0 +1,38 @@
+require 'rails_helper'
+
+describe LHS::Collection do
+  let(:datastore) { 'http://local.ch/v2' }
+  let(:items) { [{ name: 'Steve' }] }
+  let(:collection) { Account.where }
+
+  before(:each) do
+    LHC.config.placeholder('datastore', datastore)
+    class Account < LHS::Record
+      endpoint ':datastore/accounts'
+    end
+    stub_request(:get, "http://local.ch/v2/accounts")
+      .to_return(body: response_data.to_json)
+  end
+
+  context 'plain array' do
+    let(:response_data) do
+      items
+    end
+
+    it 'initalises a collection' do
+      expect(collection.first.name).to eq 'Steve'
+    end
+  end
+
+  context 'items key' do
+    let(:response_data) do
+      {
+        items: items
+      }
+    end
+
+    it 'initalises a collection when reponse contains a key items containing an array of items' do
+      expect(collection.first.name).to eq 'Steve'
+    end
+  end
+end

data/spec/record/includes_spec.rb

@@ -189,4 +189,24 @@ describe LHS::Record do
       expect(feedback.campaign.href).to be
     end
   end
+
+  context 'modules' do
+    before(:each) do
+      module Services
+        class LocalEntry < LHS::Record
+          endpoint ':datastore/local-entries'
+        end
+
+        class Feedback < LHS::Record
+          endpoint ':datastore/feedbacks'
+        end
+      end
+      stub_request(:get, "http://local.ch/v2/feedbacks?id=123")
+        .to_return(body: [].to_json)
+    end
+
+    it 'works with modules' do
+      Services::Feedback.includes(campaign: :entry).find(123)
+    end
+  end
 end

data/spec/record/pagination_spec.rb

@@ -26,7 +26,7 @@ describe LHS::Record do
         endpoint ':datastore/feedbacks'
       end
       stub_request(:get, 'http://local.ch/v2/feedbacks?entry_id=1')
-        .and_return(body: body_json)
+        .to_return(body: body_json)
     end
 
     it 'responds to limit_value' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lhs
 version: !ruby/object:Gem::Version
-  version: 3.1.0
+  version: 3.1.1
 platform: ruby
 authors:
 - https://github.com/local-ch/lhs/graphs/contributors
@@ -177,6 +177,7 @@ files:
 - lib/lhs/version.rb
 - script/ci/build.sh
 - spec/.DS_Store
+- spec/collection/collection_items_spec.rb
 - spec/collection/delegate_spec.rb
 - spec/collection/enumerable_spec.rb
 - spec/collection/meta_data_spec.rb
@@ -297,6 +298,7 @@ specification_version: 4
 summary: Rails gem providing an easy, active-record-like interface to use http backend
   services
 test_files:
+- spec/collection/collection_items_spec.rb
 - spec/collection/delegate_spec.rb
 - spec/collection/enumerable_spec.rb
 - spec/collection/meta_data_spec.rb