lhs 26.1.0 → 26.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: abbbaed93b7775580684622aaf8a8dcf7d70825e2105b5ed06f2745f37342d55
-  data.tar.gz: 5770ea1e8b270c46e9839b49098515ef36eb396a9ed4fe96af6ce0bfa81d5139
+  metadata.gz: 22e5b204d979d2ed46eb93ce3ff08b6eb0aea9576f2509c7ff0c83f3c3835f75
+  data.tar.gz: 8ce212c4ad06e810bf0911f0a9fdc4e86afe434c00cfca2d3cdaaf4b5e4e1ba9
 SHA512:
-  metadata.gz: '018e106cccf4b3d509472294e6764a1fa8f4c2a966d73884a5291f4c64aa7517fb43891e47a2b7726ec4a80142658987e77514154df08bfca63a80e457657456'
-  data.tar.gz: 20ce99451144a5c6de593a325a8b99fb962889c48c27dd682ba70814d196bd26fe73851b4ba9c5137e677186b6bce444f901648a3585a27659afd845874e2e60
+  metadata.gz: 377c21cf804980cd3eb2ceaaac9a1bff0a68dce97fc6c92cdf15370808bb1b161cac99b20ffb94eda901ed11ed17fefac3eda74eca54c1249c837baf8ef8e1e8
+  data.tar.gz: 8a9f39abe3ee1f969d0397099d219fde3eb80278299d0ea9d44938726310b7b1025220e1a715793c787661c44219b62b17aa759cefc2bcc07fbea75b94a99447

data/README.md

@@ -171,7 +171,7 @@ record.review # "Lunch was great
 
 ### Endpoints
 
-> Endpoint, the entry point to a service, a process, or a queue or topic destination in service-oriented architecture
+> Endpoint, the entry point to a service, a process, a queue or a topic in a service-oriented architecture
 
 Start a record with configuring one or multiple endpoints.
 
@@ -251,7 +251,7 @@ end
 
 #### Endpoint Priorities
 
-LHS uses endpoint configurations to determine what endpoint to use when data is requested, in a similiar way, routes are identified in Rails to map requests to controllers.
+LHS uses endpoint configurations to determine what endpoint to use when data is requested, in a similar way, routes are identified in Rails to map requests to controllers.
 
 If they are ambiguous, LHS will always use the first one found:
 
@@ -275,7 +275,7 @@ Record.fetch
 GET https://service.example.com/records
 ```
 
-**Be aware that, if you configure ambigious endpoints accross multiple classes, the order of things is not deteministic. Ambigious endpoints accross multiple classes need to be avoided.**
+**Be aware that, if you configure ambiguous endpoints across multiple classes, the order of things is not deterministic. Ambiguous endpoints across multiple classes need to be avoided.**
 
 ### Provider
 
@@ -479,7 +479,7 @@ The different behavior of `count` and `length` is based on ActiveRecord's behavi
 
 `count` The total number of items available remotly via the provided endpoint/api, communicated via pagination meta data.
 
-`length` The number of items already loaded from the endpoint/api and kept in memmory right now. In case of a paginated endpoint this can differ to what `count` returns, as it depends on how many pages have been loaded already.
+`length` The number of items already loaded from the endpoint/api and kept in memory right now. In case of a paginated endpoint this can differ to what `count` returns, as it depends on how many pages have been loaded already.
 
 ### Find single records
 
@@ -593,7 +593,7 @@ How to configure endpoints for automatic collection detection?
 
 LHS detects automatically if the responded data is a single business object or a set of business objects (collection).
 
-Conventionally, when the responds contains an `items` key `{ items: [] }` it's treated as a collection, but also if the responds contains a plain raw array: `[{ href: '' }]` it's also treated as a collection.
+Conventionally, when the respons contains an `items` key `{ items: [] }` it's treated as a collection, but also if the respons contains a plain raw array: `[{ href: '' }]` it's also treated as a collection.
 
 If you need to configure the attribute of the response providing the collection, configure `items_key` as explained here: [Determine collections from the response body](#determine-collections-from-the-response-body)
 
@@ -782,7 +782,7 @@ end
 
 #### Unwrap nested items from the response body
 
-If the actual item data is mixed with meta data in the response body, LHS allows you to configure a record in a way to automatically unwrap items from within nested response data.
+If the actual item data is mixed with metadata in the response body, LHS allows you to configure a record in a way to automatically unwrap items from within nested response data.
 
 `item_key` is used to unwrap the actual object from within the response body.
 
@@ -1058,7 +1058,7 @@ records = Record.where(color: 'blue').fetch
 
 #### Add request options to a query chain: options
 
-You can apply options to the request chain. Those options will be forwarded to the request perfomed by the chain/query:
+You can apply options to the request chain. Those options will be forwarded to the request performed by the chain/query:
 
 ```ruby
 # app/controllers/some_controller.rb
@@ -1178,7 +1178,7 @@ Record.page(3).per(20).where(color: 'blue')
 GET https://service.example.com/records?offset=40&limit=20&color=blue
 ```
 
-The applied pagination strategy depends on whats configured for the particular record: See [Record pagination](#record-pagination)
+The applied pagination strategy depends on what's configured for the particular record: See [Record pagination](#record-pagination)
 
 ### Record pagination
 
@@ -1330,7 +1330,7 @@ Sequentially:
 ##### limit_key
 
 `limit_key` sets the key used to indicate how many items you want to retrieve per page e.g. `size`, `limit`, etc.
-In case the `limit_key` parameter differs for how it needs to be requested from how it's provided in the reponse, use `body` and `parameter` subkeys.
+In case the `limit_key` parameter differs for how it needs to be requested from how it's provided in the response, use `body` and `parameter` subkeys.
 
 ```ruby
 # app/models/record.rb
@@ -1359,7 +1359,7 @@ GET https://service.example.com/records?color=blue&max=100
 ##### pagination_key
 
 `pagination_key` defines which key to use to paginate a page (e.g. `offset`, `page`, `startAt` etc.).
-In case the `limit_key` parameter differs for how it needs to be requested from how it's provided in the reponse, use `body` and `parameter` subkeys.
+In case the `limit_key` parameter differs for how it needs to be requested from how it's provided in the response, use `body` and `parameter` subkeys.
 
 ```ruby
 # app/models/record.rb
@@ -1584,7 +1584,7 @@ POST https://service.example.com/records { body: "{ 'name' : 'Starbucks' }" }
 
 ##### save
 
-`save` persist the whole object in it's current state. 
+`save` persist the whole object in its current state. 
 
 `save` will return `false` if persisting fails. `save!` instead will raise an exception.
 
@@ -2023,7 +2023,7 @@ DELETE https://service.example.com/records?name='Steve'
 
 ### Record getters and setters
 
-Sometimes it is neccessary to implement custom getters and setters and convert data to a processable (endpoint) format behind the scenes.
+Sometimes it is necessary to implement custom getters and setters and convert data to a processable (endpoint) format behind the scenes.
 
 #### Record setters
 
@@ -2201,7 +2201,7 @@ customer.contracts.first.products.first.name # Local Business Card
 
 #### Include various levels of linked data
 
-The method syntax of `includes` allows you include hyperlinks stored in deep nested data strutures:
+The method syntax of `includes` allows you to include hyperlinks stored in deep nested data structures:
 
 Some examples:
 
@@ -2283,7 +2283,7 @@ In parallel:
   GET https://service.example.com/places/4 { headers: { 'Authentication': 'Bearer 123' } }
 ```
 
-Here is another example, if you want to ignore errors, that occure while you fetch included resources:
+Here is another example, if you want to ignore errors, that occur while you fetch included resources:
 
 ```ruby
 # app/controllers/some_controller.rb

data/lib/lhs/concerns/record/request.rb

@@ -123,7 +123,15 @@ class LHS::Record
           options = extend_with_reference(options, reference)
           addition = load_existing_includes(options, data, sub_includes, reference)
           data.extend!(addition, included)
-          expand_addition!(data, included, reference) unless expanded_data?(addition)
+          unless expanded_data?(addition)
+            if data.collection?
+              data.each do |item|
+                expand_addition!(item, included, reference)
+              end
+            else
+              expand_addition!(data, included, reference)
+            end
+          end
         end
       end
 

data/lib/lhs/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module LHS
-  VERSION = '26.1.0'
+  VERSION = '26.2.0'
 end

data/spec/record/includes_after_expansion_spec.rb

@@ -69,4 +69,51 @@ describe LHS::Record do
       ).to eq 'OPL'
     end
   end
+
+  context 'with collections' do
+    before do
+      class User < LHS::Record
+        endpoint 'http://users'
+        endpoint 'http://users/{id}'
+      end
+
+      class Places < LHS::Record
+        endpoint 'http://users/{id}/places'
+        endpoint 'http://places/{id}'
+      end
+
+      stub_request(:get, 'http://users?email=user@example.com')
+        .to_return(
+          body: {
+            href: 'http://users?email=user@example.com',
+            items: [
+              {
+                places: {
+                  href: 'http://users/1/places'
+                }
+              }
+            ]
+          }.to_json
+        )
+
+      stub_request(:get, 'http://users/1/places?limit=100')
+        .to_return(
+          body: {
+            items: [
+              {
+                title: 'Place'
+              }
+            ],
+            total: 0,
+            offset: 0,
+            limit: 10
+          }.to_json
+        )
+    end
+
+    it 'includes resources after expanding plain links' do
+      user = User.includes(:places).find(email: 'user@example.com')
+      expect(user.places.first.title).to eq 'Place'
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lhs
 version: !ruby/object:Gem::Version
-  version: 26.1.0
+  version: 26.2.0
 platform: ruby
 authors:
 - https://github.com/local-ch/lhs/graphs/contributors
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-05-02 00:00:00.000000000 Z
+date: 2022-05-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel