lhs 21.2.3 → 21.2.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 90588d8b49ea001a59c76710d97dc5b2b55ba77917ded5012c35e6924b9f2208
-  data.tar.gz: 880b24d7a80d32eeccde0e7818fd36a31b59cfb8699cb880746a28c60e7ec983
+  metadata.gz: d29a70798d8ce33c3fbd253465123d32fe2fd4a97e213a9f3cdce1350e45bd85
+  data.tar.gz: 50d2cd571874e523de51ed9652d4faec1406087e69940ee87f4941f5d416e9b4
 SHA512:
-  metadata.gz: 9294294bb7c1c21881bccea2a70e756da27a54edc59385361f2179d3d2069b2a00469a74957bd145b3d54c94eff18d08813db054a87ffa6526388de2473f8649
-  data.tar.gz: 6bdbfaab6df958c88cb791b7202b9ed713c460e2297bbb3fc9da160bb55c9fc97b6051978f451d074da08e073d647d3653cd94090f2235c4b00fee707d861824
+  metadata.gz: a6fcfc2a0507d730e88045b0489d0f463bcff6235fe5a10cafdbd6c3560ae0e561479f3f2ae766ef7495be8c8e6d0efbce2636f468ae98a488d413ece8d6ca75
+  data.tar.gz: c7c48a2130f9cf32de2fdc657f0ba3b50b71e10b062a297797b383b0c5f2fd9cbdf1a9023237dcf1ca44c9f822ec3dd25ef3180a9915c166850477592c623b48

data/lib/lhs/concerns/record/request.rb

@@ -246,7 +246,9 @@ class LHS::Record
       def skip_loading_includes?(data, included)
         if data.collection?
           data.to_a.none? { |item| item[included].present? }
-        elsif data[included].present? && data[included].item? && data[included].href.blank?
+        elsif data.dig(included).blank?
+          true
+        elsif data[included].item? && data[included][:href].blank?
           true
         else
           !data._raw.key?(included)

data/lib/lhs/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module LHS
-  VERSION = '21.2.3'
+  VERSION = '21.2.4'
 end

data/spec/record/includes_spec.rb

@@ -705,4 +705,23 @@ describe LHS::Record do
       }).not_to raise_exception
     end
   end
+
+  context 'include partially empty structures' do
+    before do
+      class Place < LHS::Record
+        endpoint 'https://places/{id}'
+      end
+      stub_request(:get, "https://places/1")
+        .to_return(body: {
+          id: '123',
+          customer: {}
+        }.to_json)
+    end
+
+    it 'skips includes when there is nothing and also does not raise an exception' do
+      expect(-> {
+        Place.includes(customer: :salesforce).find(1)
+      }).not_to raise_exception
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lhs
 version: !ruby/object:Gem::Version
-  version: 21.2.3
+  version: 21.2.4
 platform: ruby
 authors:
 - https://github.com/local-ch/lhs/graphs/contributors
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-03-24 00:00:00.000000000 Z
+date: 2020-04-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel