lhs 2.1.0 → 2.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: df827d2008392c40865a0c82e9a515b4bc541ee2
-  data.tar.gz: 5b589ba038ded4cb9407c24091ed7c0b08f96a63
+  metadata.gz: 0136ac0223418ddf3f141de5fb9a469a7fe24374
+  data.tar.gz: 448e6a48140f37728dfe40083edb15638649de74
 SHA512:
-  metadata.gz: 3648b5f1e76c703a6f56cfc78b9b8d4bc2a983947f42dfd819e087aca2d5100b8846ca3a8c4059a86b54cf033a18e648f9881d8cf5a40fbfe337268d3d53472f
-  data.tar.gz: 8f797d35de13f0e3f1e8171c15730137834029a95aae831a2d174e78e377779b5fd3d0227e578bb00469bbfc17528388279147c2f2944ef0758d0e1d14960fd4
+  metadata.gz: b4833493e3121a9177210180f96b1b5df0b496b9c8f6945c7e73c00ea8117bb6dd65cb3bc63fef3f60e1a357b3ccfcf1d958c86177e67d5490f705edbcbfd65e
+  data.tar.gz: 5724f5743af929cc146863a897161d2625748ef6fff40ae36e8b48446c8772d7c88138ebae10ca256862504c047d6129a7afcb31f9334d4b477edc9438dc8875

data/lib/lhs/concerns/item/validation.rb

@@ -9,7 +9,8 @@ class LHS::Item < LHS::Proxy
       self.errors = nil
       fail 'No validation endpoint found!' unless validation_endpoint
       service = LHS::Service.for_url(validation_endpoint.url)
-      params = validation_endpoint.options.fetch(:params, {}).merge(persist: false)
+      validation_params = validation_endpoint.options[:validates] == true ? { persist: false } : { validation_endpoint.options[:validates] => false }
+      params = validation_endpoint.options.fetch(:params, {}).merge(validation_params)
       begin
         service.request(
           url: validation_endpoint.url,

data/lib/lhs/version.rb

@@ -1,3 +1,3 @@
 module LHS
-  VERSION = "2.1.0"
+  VERSION = "2.1.1"
 end

data/spec/item/validation_spec.rb

@@ -4,84 +4,112 @@ describe LHS::Item do
 
   let(:datastore) { 'http://local.ch' }
 
-  before(:each) do
-    LHC.config.placeholder('datastore', datastore)
-    class User < LHS::Service
-      endpoint ':datastore/v2/users', validates: true
-    end
-    mock_validation
-  end
+  let(:validation_parameter) { 'persist' }
 
   let(:mock_validation) do
       successful_validation
     end
 
   let(:successful_validation) do
-    stub_request(:post, "#{datastore}/v2/users?persist=false").to_return(body: '{}')
+    stub_request(:post, "#{datastore}/v2/users?#{validation_parameter}=false").to_return(body: '{}')
   end
 
-  let(:failing_validation) do
-    stub_request(:post, "#{datastore}/v2/users?persist=false")
-      .to_return(status: 400,
-        body: {
-          field_errors: [{code: "UNSUPPORTED_PROPERTY_VALUE", "path" => [ "email" ]}] 
-        }.to_json
-      )
+  before(:each) do
+    mock_validation
   end
 
-  context 'valid data' do
+  context 'custom validation parameter' do
+
+    let(:validation_parameter) { 'publish' }
+
     let(:user) do
       User.build(email: 'steve@local.ch')
     end
 
-    it 'validates' do
-      expect(user.valid?).to eq true
+    before(:each) do
+      LHC.config.placeholder('datastore', datastore)
+      class User < LHS::Service
+        endpoint ':datastore/v2/users', validates: 'publish'
+      end
     end
 
-    it 'turns to be invalid if validating on changed, invalid data' do
+    it 'validates' do
       expect(user.valid?).to eq true
-      user.email = 'not a valid email'
-      failing_validation
-      expect(user.valid?).to eq false
-      expect(user.errors[:email]).to be
     end
+
   end
 
-  context 'invalid data' do
+  context 'default parameter' do
 
-    let(:user) do
-      User.build(email: 'im not an email address')
+    before(:each) do
+      LHC.config.placeholder('datastore', datastore)
+      class User < LHS::Service
+        endpoint ':datastore/v2/users', validates: true
+      end
     end
 
-    let(:mock_validation) do
-      failing_validation
+    let(:failing_validation) do
+      stub_request(:post, "#{datastore}/v2/users?persist=false")
+        .to_return(status: 400,
+                   body: {
+                     field_errors: [{ code: "UNSUPPORTED_PROPERTY_VALUE", "path" => ["email"] }]
+                   }.to_json
+                  )
     end
 
-    it 'does not validate and provides error messages' do
-      expect(user.valid?).to eq false
-      expect(user.errors[:email]).to be
-    end
+    context 'valid data' do
+      let(:user) do
+        User.build(email: 'steve@local.ch')
+      end
 
-    it 'resets errors when revalidating' do
-      expect(user.valid?).to eq false
-      user.email = 'steve@local.ch'
-      successful_validation
-      expect(user.valid?).to eq true
-      expect(user.errors).to be_nil
+      it 'validates' do
+        expect(user.valid?).to eq true
+      end
+
+      it 'turns to be invalid if validating on changed, invalid data' do
+        expect(user.valid?).to eq true
+        user.email = 'not a valid email'
+        failing_validation
+        expect(user.valid?).to eq false
+        expect(user.errors[:email]).to be
+      end
     end
-  end
 
-  context 'endpoint does not support validations' do
-    before(:each) do
-      class Favorite < LHS::Service
-        endpoint ':datastore/v2/favorites'
+    context 'invalid data' do
+      let(:user) do
+        User.build(email: 'im not an email address')
+      end
+
+      let(:mock_validation) do
+        failing_validation
+      end
+
+      it 'does not validate and provides error messages' do
+        expect(user.valid?).to eq false
+        expect(user.errors[:email]).to be
+      end
+
+      it 'resets errors when revalidating' do
+        expect(user.valid?).to eq false
+        user.email = 'steve@local.ch'
+        successful_validation
+        expect(user.valid?).to eq true
+        expect(user.errors).to be_nil
       end
     end
 
-    it 'fails when trying to use an endpoint for validations that does not support it' do
-      expect(->{
-        Favorite.build.valid?
-      }).to raise_error('Endpoint does not support validations!')
+    context 'endpoint does not support validations' do
+      before(:each) do
+        class Favorite < LHS::Service
+          endpoint ':datastore/v2/favorites'
+        end
+      end
+
+      it 'fails when trying to use an endpoint for validations that does not support it' do
+        expect(lambda {
+          Favorite.build.valid?
+        }).to raise_error('Endpoint does not support validations!')
+      end
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lhs
 version: !ruby/object:Gem::Version
-  version: 2.1.0
+  version: 2.1.1
 platform: ruby
 authors:
 - local.ch
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-12-30 00:00:00.000000000 Z
+date: 2016-02-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lhc