lhs 19.9.0 → 19.10.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5ae06289222aa01014699262ca1538093d7388f5e6a4fa689c3351d2fd6cf1d7
-  data.tar.gz: f0308f117f2f2dc44d0e0ada944c74ed0819b91198756fcedfeecebf472b0da9
+  metadata.gz: 57094afc8763a8fe1aab390ad385ac4ddee8c2abd59dd8b8651cd83c07826fef
+  data.tar.gz: 2b06402e0aceb84e5d21aefeb15321610a6b13ada2959b6286434d8725578b13
 SHA512:
-  metadata.gz: 4778c1456b9f0aea0308f7a505d27641aa6a0bb1dc18170724c80542d182df8f5198f2e1a5de6db749722e22a59d1c1ea701934f8f89f365c05a4cc00af061c3
-  data.tar.gz: c64c7dece11ba95192669df9ea91d33a40262156eeac930efdfd8e432a4bfc51add6350746c937203309d67012499d15880c5b5b694ac66740556b9798dd8be6
+  metadata.gz: ae00456701d8fa85fdf0e3f8d3d14eb58d87f1c87719b5ac2916959ebd449853f7a061a239fda5debc45faa0d34bb265f3cf429b584eba63cf2969a38b3c3ebe
+  data.tar.gz: 0b142fc761ccda98c5524bd0810ca0147fd9a5d4ec923b4986cdc3698bce8f1881b240c8c3113d9f09d1c57ca92925848d29690d0da5fde0a099a7757b3e81a0

data/README.md

@@ -119,6 +119,7 @@ record.review # "Lunch was great
             * [Record setters](#record-setters)
             * [Record getters](#record-getters)
          * [Include linked resources (hyperlinks and hypermedia)](#include-linked-resources-hyperlinks-and-hypermedia)
+            * [Generate links from parameters](#generate-links-from-parameters)
             * [Ensure the whole linked collection is included: includes_all](#ensure-the-whole-linked-collection-is-included-includes_all)
             * [Include the first linked page or single item is included: include](#include-the-first-linked-page-or-single-item-is-included-include)
             * [Include various levels of linked data](#include-various-levels-of-linked-data)
@@ -136,6 +137,7 @@ record.review # "Lunch was great
          * [Disable request cycle cache](#disable-request-cycle-cache)
       * [Option Blocks](#option-blocks)
       * [Request tracing](#request-tracing)
+      * [Extended Rollbar Logging](#extended-rollbar-logging)
       * [Testing with LHS](#testing-with-lhs)
          * [Test helper for request cycle cache](#test-helper-for-request-cycle-cache)
          * [Test query chains](#test-query-chains)
@@ -2443,6 +2445,26 @@ code.places
 }
 ```
 
+## Extended Rollbar Logging
+
+In order to log all requests/responses prior to an exception reported by Rollbar in addition to the exception itself, use the `LHS::ExtendedRollbar` interceptor in combination with the rollbar processor/handler:
+
+```ruby
+# config/initializers/lhc.rb
+
+LHC.configure do |config|
+  config.interceptors = [LHS::ExtendedRollbar]
+end
+```
+
+```ruby
+# config/initializers/rollbar.rb
+
+Rollbar.configure do |config|
+  config.before_process << LHS::Interceptors::ExtendedRollbar::Handler.init
+end
+```
+
 ## Testing with LHS
 
 **Best practice in regards of testing applications using LHS, is to let LHS fetch your records, actually perform HTTP requests and [WebMock](https://github.com/bblimke/webmock) to stub/mock those http requests/responses.**

data/lhs.gemspec

@@ -31,6 +31,7 @@ Gem::Specification.new do |s|
   s.add_development_dependency 'pry'
   s.add_development_dependency 'pry-byebug'
   s.add_development_dependency 'rails', '>= 4.2.11'
+  s.add_development_dependency 'rollbar'
   s.add_development_dependency 'rspec-rails', '>= 3.7.0'
   s.add_development_dependency 'rubocop', '~> 0.57.1'
   s.add_development_dependency 'rubocop-rspec', '~> 1.26.0'

data/lib/lhs.rb

@@ -15,10 +15,28 @@ module LHS
     'lhs/config'
   autoload :Data,
     'lhs/data'
+  autoload :ExtendedRollbar,
+    'lhs/interceptors/extended_rollbar/interceptor'
   autoload :Endpoint,
     'lhs/endpoint'
   autoload :Inspect,
     'lhs/concerns/inspect'
+  module Interceptors
+    module RequestCycleCache
+      autoload :ThreadRegistry,
+        'lhs/interceptors/request_cycle_cache/thread_registry'
+      autoload :Interceptor,
+        'lhs/interceptors/request_cycle_cache/interceptor'
+    end
+    module ExtendedRollbar
+      autoload :ThreadRegistry,
+        'lhs/interceptors/extended_rollbar/thread_registry'
+      autoload :Interceptor,
+        'lhs/interceptors/extended_rollbar/interceptor'
+      autoload :Handler,
+        'lhs/interceptors/extended_rollbar/handler'
+    end
+  end
   autoload :IsHref,
     'lhs/concerns/is_href'
   autoload :Item,

data/lib/lhs/concerns/option_blocks.rb

@@ -8,7 +8,7 @@ module LHS
 
     class CurrentOptionBlock
       # Using ActiveSupports PerThreadRegistry to be able to support Active Support v4.
-      # Will switch to thread_mattr_accessor (which comes with Activesupport) when we dropping support for Active Support v5.
+      # Will switch to thread_mattr_accessor (which comes with Activesupport) when we dropping support for Active Support v4.
       extend ActiveSupport::PerThreadRegistry
       attr_accessor :options
     end

data/lib/lhs/concerns/record/request.rb

@@ -509,16 +509,16 @@ class LHS::Record
         options
       end
 
-      # Injects options into request, that enable the LHS::Record::RequestCycleCache::Interceptor
+      # Injects options into request, that enable the request cycle cache interceptor
       def inject_request_cycle_cache!(options)
         return unless LHS.config.request_cycle_cache_enabled
         interceptors = options[:interceptors] || LHC.config.interceptors
         if interceptors.include?(LHC::Caching)
-          # Ensure LHS::RequestCycleCache interceptor is prepend
-          interceptors = interceptors.unshift(LHS::Record::RequestCycleCache::Interceptor)
+          # Ensure interceptor is prepend
+          interceptors = interceptors.unshift(LHS::Interceptors::RequestCycleCache::Interceptor)
           options[:interceptors] = interceptors
         else
-          warn("[WARNING] Can't enable LHS::RequestCycleCache as LHC::Caching interceptor is not enabled/configured (see https://github.com/local-ch/lhc/blob/master/docs/interceptors/caching.md#caching-interceptor)!")
+          warn("[WARNING] Can't enable request cycle cache as LHC::Caching interceptor is not enabled/configured (see https://github.com/local-ch/lhc/blob/master/docs/interceptors/caching.md#caching-interceptor)!")
         end
       end
 

data/lib/lhs/interceptors/extended_rollbar/handler.rb

@@ -0,0 +1,40 @@
+# frozen_string_literal: true
+
+module LHS
+  module Interceptors
+    module ExtendedRollbar
+      class Handler
+
+        def self.init
+          proc do |options|
+            # as handlers cant influence what actually is reported to rollbar
+            # this just makes sure that Rollbar is already loaded when this class is loaded,
+            # so that we can extend rollbar loging
+          end
+        end
+
+        module ExtendedLogging
+          def log(level, *args)
+            args[2] = {} if args[2].nil?
+            args[2][:lhs] = LHS::Interceptors::ExtendedRollbar::ThreadRegistry.log.map do |entry|
+              {
+                request: entry[:request].options,
+                response: {
+                  code: entry[:response].code,
+                  body: entry[:response].body
+                }
+              }
+            end.to_json
+            super
+          end
+        end
+
+        module ::Rollbar
+          class Notifier
+            prepend LHS::Interceptors::ExtendedRollbar::Handler::ExtendedLogging
+          end
+        end
+      end
+    end
+  end
+end

data/lib/lhs/interceptors/extended_rollbar/interceptor.rb

@@ -0,0 +1,20 @@
+# frozen_string_literal: true
+
+require 'active_support'
+
+module LHS
+  module Interceptors
+    module ExtendedRollbar
+      extend ActiveSupport::Concern
+
+      class Interceptor < LHC::Interceptor
+        def after_response
+          return unless LHS::Interceptors::ExtendedRollbar::ThreadRegistry.log
+          LHS::Interceptors::ExtendedRollbar::ThreadRegistry.log.push(request: request, response: response)
+        end
+      end
+    end
+  end
+
+  const_set('ExtendedRollbar', LHS::Interceptors::ExtendedRollbar::Interceptor)
+end

data/lib/lhs/interceptors/extended_rollbar/thread_registry.rb

@@ -0,0 +1,18 @@
+# frozen_string_literal: true
+
+require 'active_support'
+
+module LHS
+  module Interceptors
+    module ExtendedRollbar
+      extend ActiveSupport::Concern
+
+      class ThreadRegistry
+        # Using ActiveSupports PerThreadRegistry to be able to support Active Support v4.
+        # Will switch to thread_mattr_accessor (which comes with Activesupport) when we dropping support for Active Support v4.
+        extend ActiveSupport::PerThreadRegistry
+        attr_accessor :log
+      end
+    end
+  end
+end

data/lib/lhs/interceptors/request_cycle_cache/interceptor.rb

@@ -0,0 +1,41 @@
+# frozen_string_literal: true
+
+require 'active_support'
+
+module LHS
+  module Interceptors
+    module RequestCycleCache
+      extend ActiveSupport::Concern
+
+      class Interceptor < LHC::Interceptor
+
+        VERSION = 1
+        CACHED_METHODS = [:get].freeze
+
+        def before_request
+          request.options = {
+            cache: {
+              expires_in: 5.minutes,
+              race_condition_ttl: 5.seconds,
+              key: cache_key_for(request),
+              methods: CACHED_METHODS,
+              use: LHS.config.request_cycle_cache
+            }
+          }.merge(request.options)
+        end
+
+        private
+
+        def cache_key_for(request)
+          [
+            "LHS_REQUEST_CYCLE_CACHE(v#{VERSION})",
+            request.method.upcase,
+            [request.url, request.params.presence].compact.join('?'),
+            "REQUEST=#{LHS::Interceptors::RequestCycleCache::ThreadRegistry.request_id}",
+            "HEADERS=#{request.headers.hash}"
+          ].join(' ')
+        end
+      end
+    end
+  end
+end

data/lib/lhs/interceptors/request_cycle_cache/thread_registry.rb

@@ -0,0 +1,17 @@
+# frozen_string_literal: true
+
+require 'active_support'
+
+module LHS
+  module Interceptors
+    module RequestCycleCache
+      extend ActiveSupport::Concern
+      class ThreadRegistry
+        # Using ActiveSupports PerThreadRegistry to be able to support Active Support v4.
+        # Will switch to thread_mattr_accessor (which comes with Activesupport) when we dropping support for Active Support v4.
+        extend ActiveSupport::PerThreadRegistry
+        attr_accessor :request_id
+      end
+    end
+  end
+end

data/lib/lhs/railtie.rb

@@ -8,6 +8,7 @@ module LHS
         def initialize
           prepare_lhs_request_cycle_cache
           reset_option_blocks
+          reset_extended_rollbar_request_logs
           super
         end
 
@@ -15,12 +16,18 @@ module LHS
 
         def prepare_lhs_request_cycle_cache
           return unless LHS.config.request_cycle_cache_enabled
-          LHS::Record::RequestCycleCache::RequestCycleThreadRegistry.request_id = [Time.now.to_f, request.object_id].join('#')
+          LHS::Interceptors::RequestCycleCache::ThreadRegistry.request_id = [Time.now.to_f, request.object_id].join('#')
         end
 
         def reset_option_blocks
           LHS::OptionBlocks::CurrentOptionBlock.options = nil
         end
+
+        def reset_extended_rollbar_request_logs
+          return unless defined?(::Rollbar)
+          return unless LHC.config.interceptors.include?(LHS::Interceptors::ExtendedRollbar::Interceptor)
+          LHS::Interceptors::ExtendedRollbar::ThreadRegistry.log = []
+        end
       end
     end
   end

data/lib/lhs/record.rb

@@ -48,13 +48,6 @@ class LHS::Record
   autoload :AttributeAssignment,
     'lhs/concerns/record/attribute_assignment'
 
-  module RequestCycleCache
-    autoload :RequestCycleThreadRegistry,
-      'lhs/concerns/record/request_cycle_cache/request_cycle_thread_registry'
-    autoload :Interceptor,
-      'lhs/concerns/record/request_cycle_cache/interceptor'
-  end
-
   include Batch
   include Chainable
   include Configuration
@@ -77,7 +70,6 @@ class LHS::Record
   include Provider
   include Request
   include Relations
-  include RequestCycleCache
   include Scope
   include Tracing
   include AttributeAssignment

data/lib/lhs/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module LHS
-  VERSION = '19.9.0'
+  VERSION = '19.10.0'
 end

data/spec/dummy/app/controllers/extended_rollbar_controller.rb

@@ -0,0 +1,10 @@
+# frozen_string_literal: true
+
+class ExtendedRollbarController < ApplicationController
+
+  def extended_rollbar
+    Record.where(color: 'blue').fetch
+    Record.where(color: 'red').fetch
+    raise "Let's see if rollbar logs information about what kind of requests where made around here!"
+  end
+end

data/spec/dummy/config/initializers/rollbar.rb

@@ -0,0 +1,9 @@
+# frozen_string_literal: true
+
+if defined?(Rollbar)
+  Rollbar.configure do |config|
+    config.access_token = '12345'
+    config.enabled = true
+    config.before_process << LHS::Interceptors::ExtendedRollbar::Handler.init
+  end
+end

data/spec/dummy/config/routes.rb

@@ -16,4 +16,7 @@ Rails.application.routes.draw do
   # Option Blocks
   get 'option_blocks/first' => 'option_blocks#first'
   get 'option_blocks/second' => 'option_blocks#second'
+
+  # Extended Rollbar
+  get 'extended_rollbar' => 'extended_rollbar#extended_rollbar'
 end

data/spec/extended_rollbar_spec.rb

@@ -0,0 +1,67 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+
+describe 'Extended Rollbar', type: :request do
+  let!(:records_request_1) do
+    stub_request(:get, "http://datastore/v2/records?color=blue").to_return(body: ['blue'].to_json)
+  end
+
+  let!(:records_request_2) do
+    stub_request(:get, "http://datastore/v2/records?color=red").to_return(body: ['red'].to_json)
+  end
+
+  let!(:rollbar_request) do
+    stub_request(:post, "https://api.rollbar.com/api/1/item/")
+      .with do |request|
+        json = JSON.parse request.body
+        message = "Let's see if rollbar logs information about what kind of requests where made around here!"
+        extra = {
+          lhs: [
+            {
+              request: {
+                params: { color: 'blue' },
+                url: 'http://datastore/v2/records',
+                headers: {
+                  'Content-Type' => 'application/json; charset=utf-8',
+                  'Accept' => 'application/json,application/vnd.api+json',
+                  'Accept-Charset' => 'utf-8'
+                }
+              },
+              response: { code: 200, body: '["blue"]' }
+            }, {
+              request: {
+                params: { color: 'red' },
+                url: 'http://datastore/v2/records',
+                headers: {
+                  'Content-Type' => 'application/json; charset=utf-8',
+                  'Accept' => 'application/json,application/vnd.api+json',
+                  'Accept-Charset' => 'utf-8'
+                }
+              },
+              response: { code: 200, body: '["red"]' }
+            }
+          ].to_json
+        }
+        json['access_token'] == '12345' &&
+          json['data']['level'] == 'error' &&
+          json['data']['body']['trace']['exception']['message'] == message &&
+          json['data']['body']['trace']['extra'].to_json == extra.to_json
+      end
+      .to_return(status: 200)
+  end
+
+  before do
+    LHC.configure do |config|
+      config.interceptors = [LHS::ExtendedRollbar]
+    end
+  end
+
+  it 'extends default rollbar logging by adding information about the requests made during a request/response cycle',
+  dummy_models: true, extended_rollbar: true do
+    get '/extended_rollbar'
+    expect(records_request_1).to have_been_requested
+    expect(records_request_2).to have_been_requested
+    expect(rollbar_request).to have_been_requested
+  end
+end

data/spec/rails_helper.rb

@@ -1,7 +1,9 @@
 # frozen_string_literal: true
 
 ENV["RAILS_ENV"] ||= 'test'
+ENV['DUMMYAPP_PATH'] = "spec/dummy"
 
+require 'rails/rollbar_runner'
 require 'spec_helper'
 require File.expand_path("../dummy/config/environment", __FILE__)
 require 'rspec/rails'

data/spec/request_cycle_cache_spec.rb

@@ -37,7 +37,7 @@ describe 'Request Cycle Cache', type: :request do
     expect(lambda do
       get '/request_cycle_cache/no_caching_interceptor'
     end).to output(
-      %r{\[WARNING\] Can't enable LHS::RequestCycleCache as LHC::Caching interceptor is not enabled/configured \(see https://github.com/local-ch/lhc/blob/master/docs/interceptors/caching.md#caching-interceptor\)!}
+      %r{\[WARNING\] Can't enable request cycle cache as LHC::Caching interceptor is not enabled/configured \(see https://github.com/local-ch/lhc/blob/master/docs/interceptors/caching.md#caching-interceptor\)!}
     ).to_stderr
     expect(request).to have_been_made.times(2)
   end
@@ -52,11 +52,11 @@ describe 'Request Cycle Cache', type: :request do
   it 'sets different uniq request ids as base for request cycle caching for different requests',
   dummy_models: true, request_cycle_cache: true do
     get '/request_cycle_cache/simple'
-    first_request_id = LHS::Record::RequestCycleCache::RequestCycleThreadRegistry.request_id
+    first_request_id = LHS::Interceptors::RequestCycleCache::ThreadRegistry.request_id
     second_request_id = nil
     thread = Thread.new do
       get '/request_cycle_cache/simple'
-      second_request_id = LHS::Record::RequestCycleCache::RequestCycleThreadRegistry.request_id
+      second_request_id = LHS::Interceptors::RequestCycleCache::ThreadRegistry.request_id
     end
     thread.join
     expect(first_request_id).not_to be_nil
@@ -70,7 +70,7 @@ describe 'Request Cycle Cache', type: :request do
       expect(lambda do
         get '/request_cycle_cache/no_caching_interceptor'
       end).not_to output(
-        %r{\[WARNING\] Can't enable LHS::RequestCycleCache as LHC::Caching interceptor is not enabled/configured \(see https://github.com/local-ch/lhc/blob/master/docs/interceptors/caching.md#caching-interceptor\)!}
+        %r{\[WARNING\] Can't enable request cycle cache as LHC::Caching interceptor is not enabled/configured \(see https://github.com/local-ch/lhc/blob/master/docs/interceptors/caching.md#caching-interceptor\)!}
       ).to_stderr
       expect(request).to have_been_made.times(2)
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lhs
 version: !ruby/object:Gem::Version
-  version: 19.9.0
+  version: 19.10.0
 platform: ruby
 authors:
 - https://github.com/local-ch/lhs/graphs/contributors
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-08-05 00:00:00.000000000 Z
+date: 2019-08-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -122,6 +122,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 4.2.11
+- !ruby/object:Gem::Dependency
+  name: rollbar
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec-rails
   requirement: !ruby/object:Gem::Requirement
@@ -261,13 +275,16 @@ files:
 - lib/lhs/concerns/record/provider.rb
 - lib/lhs/concerns/record/relations.rb
 - lib/lhs/concerns/record/request.rb
-- lib/lhs/concerns/record/request_cycle_cache/interceptor.rb
-- lib/lhs/concerns/record/request_cycle_cache/request_cycle_thread_registry.rb
 - lib/lhs/concerns/record/scope.rb
 - lib/lhs/concerns/record/tracing.rb
 - lib/lhs/config.rb
 - lib/lhs/data.rb
 - lib/lhs/endpoint.rb
+- lib/lhs/interceptors/extended_rollbar/handler.rb
+- lib/lhs/interceptors/extended_rollbar/interceptor.rb
+- lib/lhs/interceptors/extended_rollbar/thread_registry.rb
+- lib/lhs/interceptors/request_cycle_cache/interceptor.rb
+- lib/lhs/interceptors/request_cycle_cache/thread_registry.rb
 - lib/lhs/item.rb
 - lib/lhs/pagination/base.rb
 - lib/lhs/pagination/link.rb
@@ -322,6 +339,7 @@ files:
 - spec/dummy/app/controllers/application_controller.rb
 - spec/dummy/app/controllers/concerns/.keep
 - spec/dummy/app/controllers/error_handling_with_chains_controller.rb
+- spec/dummy/app/controllers/extended_rollbar_controller.rb
 - spec/dummy/app/controllers/option_blocks_controller.rb
 - spec/dummy/app/controllers/request_cycle_cache_controller.rb
 - spec/dummy/app/helpers/application_helper.rb
@@ -350,6 +368,7 @@ files:
 - spec/dummy/config/initializers/filter_parameter_logging.rb
 - spec/dummy/config/initializers/inflections.rb
 - spec/dummy/config/initializers/mime_types.rb
+- spec/dummy/config/initializers/rollbar.rb
 - spec/dummy/config/initializers/session_store.rb
 - spec/dummy/config/initializers/wrap_parameters.rb
 - spec/dummy/config/locales/en.yml
@@ -362,6 +381,7 @@ files:
 - spec/dummy/public/500.html
 - spec/dummy/public/favicon.ico
 - spec/endpoint/for_url_spec.rb
+- spec/extended_rollbar_spec.rb
 - spec/item/access_errors_spec.rb
 - spec/item/accessors_spec.rb
 - spec/item/add_error_spec.rb
@@ -535,6 +555,7 @@ test_files:
 - spec/dummy/app/controllers/application_controller.rb
 - spec/dummy/app/controllers/concerns/.keep
 - spec/dummy/app/controllers/error_handling_with_chains_controller.rb
+- spec/dummy/app/controllers/extended_rollbar_controller.rb
 - spec/dummy/app/controllers/option_blocks_controller.rb
 - spec/dummy/app/controllers/request_cycle_cache_controller.rb
 - spec/dummy/app/helpers/application_helper.rb
@@ -563,6 +584,7 @@ test_files:
 - spec/dummy/config/initializers/filter_parameter_logging.rb
 - spec/dummy/config/initializers/inflections.rb
 - spec/dummy/config/initializers/mime_types.rb
+- spec/dummy/config/initializers/rollbar.rb
 - spec/dummy/config/initializers/session_store.rb
 - spec/dummy/config/initializers/wrap_parameters.rb
 - spec/dummy/config/locales/en.yml
@@ -575,6 +597,7 @@ test_files:
 - spec/dummy/public/500.html
 - spec/dummy/public/favicon.ico
 - spec/endpoint/for_url_spec.rb
+- spec/extended_rollbar_spec.rb
 - spec/item/access_errors_spec.rb
 - spec/item/accessors_spec.rb
 - spec/item/add_error_spec.rb

data/lib/lhs/concerns/record/request_cycle_cache/interceptor.rb

@@ -1,40 +0,0 @@
-# frozen_string_literal: true
-
-require 'active_support'
-
-class LHS::Record
-
-  module RequestCycleCache
-    extend ActiveSupport::Concern
-
-    class Interceptor < LHC::Interceptor
-
-      VERSION = 1
-      CACHED_METHODS = [:get].freeze
-
-      def before_request
-        request.options = request.options.merge({
-          cache: {
-            expires_in: 5.minutes,
-            race_condition_ttl: 5.seconds,
-            key: cache_key_for(request),
-            methods: CACHED_METHODS,
-            use: LHS.config.request_cycle_cache
-          }
-        }.merge(request.options))
-      end
-
-      private
-
-      def cache_key_for(request)
-        [
-          "LHS_REQUEST_CYCLE_CACHE(v#{VERSION})",
-          request.method.upcase,
-          [request.url, request.params.presence].compact.join('?'),
-          "REQUEST=#{LHS::Record::RequestCycleCache::RequestCycleThreadRegistry.request_id}",
-          "HEADERS=#{request.headers.hash}"
-        ].join(' ')
-      end
-    end
-  end
-end

data/lib/lhs/concerns/record/request_cycle_cache/request_cycle_thread_registry.rb

@@ -1,15 +0,0 @@
-# frozen_string_literal: true
-
-require 'active_support'
-
-class LHS::Record
-
-  module RequestCycleCache
-    class RequestCycleThreadRegistry
-      # Using ActiveSupports PerThreadRegistry to be able to support Active Support v4.
-      # Will switch to thread_mattr_accessor (which comes with Activesupport) when we dropping support for Active Support v5.
-      extend ActiveSupport::PerThreadRegistry
-      attr_accessor :request_id
-    end
-  end
-end