lhs 16.1.4 → 16.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e4d0c9693012ec5fe38601976c89443114654f6a59de9a875c5a713ae2e01b0c
-  data.tar.gz: c23ed566bdfc10840fc0dfd7e0be0b8475a558669424f44e081da7ed3c38fbc6
+  metadata.gz: 4a37f6839d542b64f7985aa457544f300c36802a812d5b313a33ae3d35f9fd99
+  data.tar.gz: 4c00a48d6d2810e18237f36d80aedafb57af16fe04ab5204a6025b747e32bdf0
 SHA512:
-  metadata.gz: d67775a51aac4da7cd8024932b7f03b521277f6128bab375673ff464bbd300a294d06c9fc6ef8b6f599f519f2aab92552aefa4bf58497ef22462df3778800d09
-  data.tar.gz: b4f7cc36403f8fcfbdb93864f231a40949b74946e1a26a0632fba8d1ccce3a25265093d81ea2ba02840b5ac87d9f15e12376921232ddd2c44d9b33bc28744d8a
+  metadata.gz: d31442efdfaf1e8d9be0134346baf24c3a5d9808dc965a21c9ef76ba63da572df53069c04277330a9b35013fc0ba876ad3c15337327ac19ee8e54422d4cab93a
+  data.tar.gz: 0ea81e97b307717fee4200e8fbe521dc6df685f4c1f31c9aab9b5a07d1861f364d760044a7f2eb2b8a37670e3ef09e1bb53a9d66a86c435b6d27dff07b92d243

data/README.md

@@ -1709,6 +1709,9 @@ lhs.errors.attributes.<attribute_name>.<error_code>
 e.g. lhs.errors.attributes.name.unsupported_property_value
 
 lhs.errors.fallback_message
+
+lhs.errors.records.<record_name>.attributes.<collection>.<attribute_name>.<error_code>
+e.g. lhs.errors.records.appointment_proposal.attributes.appointments.date_time.date_property_not_in_future
 ```
 
 ##### Validation error types: errors vs. warnings

data/cider-ci/bin/bundle

@@ -8,6 +8,10 @@ if [ ! -f ~/.rubies/$RUBY/bin/bundle ]; then
   gem install bundler
 fi
 
+# install bundler v. 1.17.3 in order to be able to run the tests with
+# ACTIVESUPPORT=4 because rails (= 4.2.0) depends on bundler (< 2.0, >= 1.3.0)
+gem install bundler:1.17.3
+
 sed "s/^source 'https:\/\/rubygems\.intra\.local\.ch'*/source 'http\:\/\/52.29.7.59:9292'/g" Gemfile > Gemfile.tmp
 mv Gemfile.tmp Gemfile
 
@@ -29,9 +33,14 @@ CACHE_SIGNATURE_FILE="/tmp/bundle_cache_signature_${DIGEST}"
 
 if [ ! -f  $CACHE_SIGNATURE_FILE ] ; then
   if [ ! -z ${ACTIVESUPPORT:-} ]; then
-    echo "BUNDLE_GEMFILE=Gemfile.activesupport$ACTIVESUPPORT bundle install"
-    BUNDLE_GEMFILE=Gemfile.activesupport$ACTIVESUPPORT bundle install
-  else 
+    if [ ! -z ${BUNDLER:-} ]; then
+      echo "BUNDLE_GEMFILE=Gemfile.activesupport$ACTIVESUPPORT bundle $BUNDLER install"
+      BUNDLE_GEMFILE=Gemfile.activesupport$ACTIVESUPPORT bundle $BUNDLER install
+    else
+      echo "BUNDLE_GEMFILE=Gemfile.activesupport$ACTIVESUPPORT bundle install"
+      BUNDLE_GEMFILE=Gemfile.activesupport$ACTIVESUPPORT bundle install
+    fi
+  else
     echo "bundle install"
     bundle install
   fi

data/cider-ci/jobs/rspec-activesupport-4.yml

@@ -14,6 +14,7 @@ rspec-active-support-v4:
     task_defaults:
       environment_variables:
         ACTIVESUPPORT: '4'
+        BUNDLER: '_1.17.3_'
       max_trials: 2
       dispatch_storm_delay_duration: 1 Seconds
       include:

data/lib/lhs/problems/base.rb

@@ -86,7 +86,7 @@ module LHS::Problems
     end
 
     def find_translated_message(attribute, message, problem_type)
-      normalized_attribute = attribute.to_s.underscore
+      normalized_attribute = attribute.to_s.underscore.gsub(/\.[\d+\.]/, '')
       normalized_message = message.to_s.underscore
       messages = []
       messages = messages_for_record(normalized_attribute, normalized_message, problem_type) if record

data/lib/lhs/version.rb

@@ -1,3 +1,3 @@
 module LHS
-  VERSION = '16.1.4'
+  VERSION = '16.1.5'
 end

data/spec/item/translate_errors_spec.rb

@@ -194,4 +194,62 @@ describe LHS::Item do
       expect(errors[:name]).to eq ['UNSUPPORTED_PROPERTY_VALUE']
     end
   end
+
+  context 'error translation for nested record' do
+    before do
+      class AppointmentProposal < LHS::Record
+        endpoint 'http://dataste/appointment_proposals'
+        endpoint 'http://dataste/appointment_proposals/{id}'
+
+        has_many :appointments
+      end
+
+      class Appointment < LHS::Record
+      end
+
+      stub_request(:get, 'http://dataste/appointment_proposals/1')
+        .to_return(body: {
+          appointments: [
+            { 'date_time' => '13.12.2018' },
+            { 'date_time' => '18.10.2028' }
+          ]
+        }.to_json)
+
+      stub_request(:post, 'http://dataste/appointment_proposals')
+        .to_return(
+          status: 400,
+          body: {
+            field_errors: [{
+              'code' => 'DATE_PROPERTY_NOT_IN_FUTURE',
+              'path' => ['appointments', 0, 'date_time']
+            }]
+          }.to_json
+        )
+    end
+
+    let(:translation) do
+      %q{
+        lhs:
+          errors:
+            records:
+              appointment_proposal:
+                attributes:
+                  appointments:
+                    date_time:
+                      date_property_not_in_future: 'You cannot select a date in the past.'
+      }
+    end
+
+    it 'translates errors automatically when they are around' do
+      appointment_proposal = AppointmentProposal.find(1)
+      appointment_proposal.update(
+        'appointments_attributes' => {
+          '0' => { 'date_time' => '13.12.2018' },
+          '1' => { 'date_time' => '18.10.2028' }
+        }
+      )
+      expect(appointment_proposal.appointments[0].errors[:date_time]).to eql(['You cannot select a date in the past.'])
+      expect(appointment_proposal.appointments[1].errors[:date_time]).to eql([])
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lhs
 version: !ruby/object:Gem::Version
-  version: 16.1.4
+  version: 16.1.5
 platform: ruby
 authors:
 - https://github.com/local-ch/lhs/graphs/contributors
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-01-09 00:00:00.000000000 Z
+date: 2019-01-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel