lhs 16.1.3 → 16.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 270b2595ca6b508ac80989ba29b598e538b5bed03e2908a815ffb4fc30f3ff00
-  data.tar.gz: 45ed03b869ec52ff26ec336be5812984cd0707ad0d16d56d77192a9e792fba28
+  metadata.gz: e4d0c9693012ec5fe38601976c89443114654f6a59de9a875c5a713ae2e01b0c
+  data.tar.gz: c23ed566bdfc10840fc0dfd7e0be0b8475a558669424f44e081da7ed3c38fbc6
 SHA512:
-  metadata.gz: f0124060a7c1cf3b67f0bd96eedc8acd5e0098cf4d32474da9affc86c374f8c2a0b6a61b8e3d217a9da066ccd9c4f2fd52edce10d27309f43341c8d86272c526
-  data.tar.gz: 41247150b9e353a654235e509c32a1e8ae763f4e101754c9cb0fc37aeffa4b030a7541d769d384c96a2293238f2d57be0d47915baaf68781d2e9d200d1420498
+  metadata.gz: d67775a51aac4da7cd8024932b7f03b521277f6128bab375673ff464bbd300a294d06c9fc6ef8b6f599f519f2aab92552aefa4bf58497ef22462df3778800d09
+  data.tar.gz: b4f7cc36403f8fcfbdb93864f231a40949b74946e1a26a0632fba8d1ccce3a25265093d81ea2ba02840b5ac87d9f15e12376921232ddd2c44d9b33bc28744d8a

data/lib/lhs/concerns/data/becomes.rb

@@ -5,9 +5,12 @@ class LHS::Data
   module Becomes
     extend ActiveSupport::Concern
 
-    def becomes(klass)
+    def becomes(klass, options = {})
       return self if self.class == klass && !is_a?(LHS::Data)
-      klass.new(LHS::Data.new(_raw, _parent, klass))
+      data = LHS::Data.new(_raw, _parent, klass)
+      data.errors = options[:errors] if options[:errors]
+      data.warnings = options[:warnings] if options[:warnings]
+      klass.new(data)
     end
   end
 end

data/lib/lhs/concerns/proxy/accessors.rb

@@ -79,9 +79,11 @@ class LHS::Proxy
       data.warnings = LHS::Problems::Nested::Warnings.new(warnings, name) if warnings.any?
       if _record && _record._relations[name]
         klass = _record._relations[name][:record_class_name].constantize
-        return cache.compute_if_absent(klass) { data.becomes(klass) }
+        return cache.compute_if_absent(klass) do
+          data.becomes(klass, errors: data.errors, warnings: data.warnings)
+        end
       elsif record && !value.is_a?(LHS::Record)
-        return data.becomes(record)
+        return data.becomes(record, errors: data.errors, warnings: data.warnings)
       end
       data
     end

data/lib/lhs/version.rb

@@ -1,3 +1,3 @@
 module LHS
-  VERSION = '16.1.3'
+  VERSION = '16.1.4'
 end

data/spec/item/errors_spec.rb

@@ -273,4 +273,50 @@ describe LHS::Item do
       end
     end
   end
+
+  context 'forwards errors to nested data when associations are defined' do
+    before do
+      class AppointmentProposal < LHS::Record
+        endpoint 'http://dataste/appointment_proposals'
+        endpoint 'http://dataste/appointment_proposals/{id}'
+
+        has_many :appointments
+      end
+
+      class Appointment < LHS::Record
+      end
+
+      stub_request(:get, 'http://dataste/appointment_proposals/1')
+        .to_return(body: {
+          appointments: [
+            { 'date_time' => '13.12.2018' },
+            { 'date_time' => '18.10.2028' }
+          ]
+        }.to_json)
+
+      stub_request(:post, 'http://dataste/appointment_proposals')
+        .to_return(
+          status: 400,
+          body: {
+            field_errors: [{
+              'code' => 'DATE_PROPERTY_NOT_IN_FUTURE',
+              'path' => ['appointments', 0, 'date_time']
+            }]
+          }.to_json
+        )
+    end
+
+    it 'translates errors automatically when they are around' do
+      appointment_proposal = AppointmentProposal.find(1)
+      appointment_proposal.update(
+        'appointments_attributes' => {
+          '0' => { 'date_time' => '13.12.2018' },
+          '1' => { 'date_time' => '18.10.2028' }
+        }
+      )
+      appointment_proposal.appointments
+      appointment = appointment_proposal.appointments[0]
+      expect(appointment.errors[:date_time]).to eq ['DATE_PROPERTY_NOT_IN_FUTURE']
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lhs
 version: !ruby/object:Gem::Version
-  version: 16.1.3
+  version: 16.1.4
 platform: ruby
 authors:
 - https://github.com/local-ch/lhs/graphs/contributors
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-01-04 00:00:00.000000000 Z
+date: 2019-01-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel