lhs 15.6.1 → 15.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9511ca1ef684cea377c435b2eb41c8c85063c41705583c16020f6b51e8ac7a20
-  data.tar.gz: e746bf7da546c199bb559ef9f2b9eee449083958a60cb0f8138290916580b148
+  metadata.gz: 83b054afd85f87629645a1ba8755eced33f871132a594120f5128444d66bb091
+  data.tar.gz: a448d72f632fe3375f7987ec73105b650ed76ffa5369c3f2ead984714888bcac
 SHA512:
-  metadata.gz: 641c4079a479490d5af2c4b9ebbb552f1f8d6ba4509c1d5d09ef1ee2c7d41d39470779f83ec0e55739a81f05edd0ad1e86705bd1d65318b6faf36995a308362c
-  data.tar.gz: e1371c23a194e4100d3f3c72ea1d7617d19c9bc6a645695ea752fce37c861b052a55c262b6640617d60a7cb7bdea4fee75617f247a3d260dd5a8e6663004667e
+  metadata.gz: 342399e3bde742b37688f20ca329a19f81c692d08770f579f51d750b47169e38059dde880879e2ca24280bde5a62cb15aae3e944a24dc9c39685ab407277fff3
+  data.tar.gz: 561c772fea5c40562a0838f1cfa440ea67f733f88f915885733553379525acffcbcdb9cce510d9bddf9a0fc69c2b59a0b0f31b62c5eed852ef18c8a50a87af7a

data/lib/lhs/concerns/item/update.rb

@@ -25,9 +25,9 @@ class LHS::Item < LHS::Proxy
 
     def update!(params, options = {}, partial_update = false)
       options ||= {}
-      partial_data = LHS::Data.new(params, _data.parent, record)
-      _data.merge_raw!(partial_data)
-      data_sent = partial_update ? partial_data : _data
+      partial_record = _record.new(LHS::Data.new(params, _data.parent, _record))
+      _data.merge_raw!(partial_record._data)
+      data_sent = partial_update ? partial_record._data : _data
       url = href || record.find_endpoint(id: id).compile(id: id)
       response_data = record.request(
         options.merge(

data/lib/lhs/concerns/record/custom_setters.rb

@@ -0,0 +1,20 @@
+require 'active_support'
+
+class LHS::Record
+
+  module CustomSetters
+    extend ActiveSupport::Concern
+
+    private
+
+    def apply_custom_setters!
+      return if !_data.item? || !_data._raw.respond_to?(:keys)
+      raw = _data._raw
+      custom_setters = raw.keys.find_all { |key| public_methods.include?("#{key}=".to_sym) }
+      custom_setters.each do |setter|
+        value = raw.delete(setter)
+        send("#{setter}=", value)
+      end
+    end
+  end
+end

data/lib/lhs/record.rb

@@ -7,6 +7,8 @@ class LHS::Record
     'lhs/concerns/record/configuration'
   autoload :Create,
     'lhs/concerns/record/create'
+  autoload :CustomSetters,
+    'lhs/concerns/record/custom_setters'
   autoload :Destroy,
     'lhs/concerns/record/destroy'
   autoload :Endpoints,
@@ -45,6 +47,7 @@ class LHS::Record
   include Chainable
   include Configuration
   include Create
+  include CustomSetters
   include Destroy
   include Endpoints
   include Equality
@@ -87,16 +90,4 @@ class LHS::Record
   def respond_to_missing?(name, include_all = false)
     _data.respond_to_missing?(name, include_all)
   end
-
-  private
-
-  def apply_custom_setters!
-    return if !_data.item? || !_data._raw.respond_to?(:keys)
-    raw = _data._raw
-    custom_setters = raw.keys.find_all { |key| public_methods.include?("#{key}=".to_sym) }
-    custom_setters.each do |setter|
-      value = raw.delete(setter)
-      send("#{setter}=", value)
-    end
-  end
 end

data/lib/lhs/version.rb

@@ -1,3 +1,3 @@
 module LHS
-  VERSION = '15.6.1'
+  VERSION = '15.7.0'
 end

data/spec/item/update_spec.rb

@@ -48,6 +48,64 @@ describe LHS::Item do
       expect(item.name).to eq 'Andrea'
       expect(item.likes).not_to eq 'Banana'
     end
+
+    context 'with custom setters' do
+      before do
+        class Booking < LHS::Record
+          endpoint 'http://bookings/bookings'
+
+          def appointments=(appointments)
+            super(
+              appointments.map { |appointment| appointment[:id] }
+            )
+          end
+        end
+      end
+
+      let(:item) do
+        Booking.new(id: 'abc')
+      end
+
+      it 'updates data using custom setters before send to backend' do
+        stub_request(:post, "http://bookings/bookings")
+          .with(body: {
+            id: 'abc',
+            appointments: [1, 2, 3]
+          }.to_json)
+          .to_return(status: 200)
+        item.update(appointments: [{ id: 1 }, { id: 2 }, { id: 3 }])
+        expect(item.appointments.to_a).to eq([1, 2, 3])
+      end
+
+      context 'with nested items' do
+        before do
+          class Booking < LHS::Record
+            endpoint 'http://bookings/bookings'
+            has_one :appointment_proposal
+          end
+
+          class AppointmentProposal < LHS::Record
+            def appointments_attributes=(attributes)
+              self.appointments = attributes.map { |attribute| { 'date_time': attribute[:date] } }
+            end
+          end
+        end
+
+        let(:item) do
+          Booking.new(id: 'abc', appointment_proposal: { appointments: [] })
+        end
+
+        it 'updates data using custom setters before send to backend' do
+          stub_request(:post, "http://bookings/bookings")
+            .with(body: {
+              appointments: [{ date_time: '2018-01-18' }]
+            }.to_json)
+            .to_return(status: 200)
+          item.appointment_proposal.update(appointments_attributes: [{ date: '2018-01-18' }])
+          expect(item.appointment_proposal.appointments.as_json).to eq([{ 'date_time' => '2018-01-18' }])
+        end
+      end
+    end
   end
 
   context 'update!' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lhs
 version: !ruby/object:Gem::Version
-  version: 15.6.1
+  version: 15.7.0
 platform: ruby
 authors:
 - https://github.com/local-ch/lhs/graphs/contributors
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-08-20 00:00:00.000000000 Z
+date: 2018-09-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -238,6 +238,7 @@ files:
 - lib/lhs/concerns/record/chainable.rb
 - lib/lhs/concerns/record/configuration.rb
 - lib/lhs/concerns/record/create.rb
+- lib/lhs/concerns/record/custom_setters.rb
 - lib/lhs/concerns/record/destroy.rb
 - lib/lhs/concerns/record/endpoints.rb
 - lib/lhs/concerns/record/equality.rb
@@ -468,7 +469,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements:
 - Ruby >= 2.3.0
 rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 2.7.7
 signing_key: 
 specification_version: 4
 summary: 'REST services accelerator: Rails gem providing an easy, active-record-like