lhs 14.3.0 → 14.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a6435e1ce72c8bd918fc9a4b1f5fde544c47ba90
-  data.tar.gz: f12a4d30361c30793c3a79b182be4acf9bd213f2
+  metadata.gz: 592b02ea75646240c5b91bedd2c780898ed87a4b
+  data.tar.gz: b91803f278dbdc05c0b1c5405a75d7daa3191116
 SHA512:
-  metadata.gz: c40a3b2b6d1f0942837fae1e2e0ee44794708b51a4927e4b52c8d0771f05f442ebf8313d0658053cb8ee7114f23ffaf8c6f0cb780d44da1e5e6bea271c7b46cb
-  data.tar.gz: ab234e491cf9e16141610dc9f3d8bda6423757b96daf2ba992b68f91e972d053409adcf3cb15b90a15a41b6f7cfe8ea0eb0149b9f2cb4fad25b6ecc138ef9720
+  metadata.gz: 61c954708c2abf0147112c0d34ec044ef0f9dd4e53f75b26db3a26f430b138ff203127e1dc49a45066fe02c1cce9806a6b0dab7338fc207fc8b87547890aa29a
+  data.tar.gz: 088c03a54f417a2844bc6a85e318e42ea0d2a12540cc3745a2c1c20940448848c2760413eb180a5b8c0154b829a737eb76a04ab4296036c45a1cabad487039ce

data/README.md

@@ -760,7 +760,7 @@ or with parameters:
 
 In order to validate LHS::Records before persisting them, you can use the `valid?` (`validate` alias) method.
 
-The specific endpoint has to support validations without peristance. An endpoint has to be enabled (opt-in) for validations in the service configuration.
+The specific endpoint has to support validations without persistance. An endpoint has to be enabled (opt-in) for validations in the service configuration.
 
 ```ruby
 class User < LHS::Record
@@ -861,6 +861,33 @@ lhs.errors.fallback_message
 ### Know issue with `ActiveModel::Validations`
 If you are using `ActiveModel::Validations` and add errors to the LHS::Record instance - as described above - then those errors will be overwritten by the errors from `ActiveModel::Validations` when using `save`  or `valid?`. [Open issue](https://github.com/local-ch/lhs/issues/159)
 
+### Blocking errors, original "errors"
+
+The fact that records could have errors is not coupled to any response status code.
+
+LHS makes errors accessible, if they are present:
+
+```
+  {
+    company_name: 'localsearch',
+    field_errors: [{
+      code: 'REQUIRED_PROPERTY_VALUE',
+      path: ['place', 'opening_hours']
+    }
+  }
+```
+
+LHS makes those errors available when accessing `.errors`:
+
+```ruby
+  presence = Presence.create(
+    place: { href: 'http://storage/places/1' }
+  )
+
+  presence.errors.any? # true
+  presence.place.errors.messages[:opening_hours] # ['REQUIRED_PROPERTY_VALUE']
+```
+
 ### Non blocking validation errors, so called warnings
 
 In some cases, you need non blocking meta information about potential problems with the created record, so called warnings.

data/lib/lhs/concerns/proxy/problems.rb

@@ -14,7 +14,8 @@ class LHS::Proxy
     end
 
     def errors
-      @errors ||= LHS::Problems::Errors.new(nil, record)
+      response = _raw.present? && _raw.is_a?(Hash) && _raw[:field_errors] ? OpenStruct.new(body: _raw.to_json) : nil
+      @errors ||= LHS::Problems::Errors.new(response, record)
     end
 
     def warnings

data/lib/lhs/version.rb

@@ -1,3 +1,3 @@
 module LHS
-  VERSION = '14.3.0'
+  VERSION = '14.3.1'
 end

data/spec/item/access_errors_spec.rb

@@ -0,0 +1,31 @@
+require 'rails_helper'
+
+describe LHS::Item do
+
+  context 'make errors available' do
+
+    before(:each) do
+      class Presence < LHS::Record
+        endpoint 'http://opm/presences'
+      end
+    end
+
+    let(:place_href) { 'http://datastore/places/1' }
+
+    it 'makes errors available no matter the response code' do
+      stub_request(:post, "http://opm/presences")
+        .to_return(
+          status: 200,
+          body: {
+            place: { href: place_href },
+            field_errors: [{
+              code: 'REQUIRED_PROPERTY_VALUE',
+              path: ['place', 'opening_hours']
+            }]
+          }.to_json
+        )
+      presence = Presence.create(place: { href: place_href })
+      expect(presence.errors.any?).to be true
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lhs
 version: !ruby/object:Gem::Version
-  version: 14.3.0
+  version: 14.3.1
 platform: ruby
 authors:
 - https://github.com/local-ch/lhs/graphs/contributors
@@ -321,6 +321,7 @@ files:
 - spec/dummy/public/500.html
 - spec/dummy/public/favicon.ico
 - spec/endpoint/for_url_spec.rb
+- spec/item/access_errors_spec.rb
 - spec/item/accessors_spec.rb
 - spec/item/add_error_spec.rb
 - spec/item/becomes_spec.rb
@@ -499,6 +500,7 @@ test_files:
 - spec/dummy/public/500.html
 - spec/dummy/public/favicon.ico
 - spec/endpoint/for_url_spec.rb
+- spec/item/access_errors_spec.rb
 - spec/item/accessors_spec.rb
 - spec/item/add_error_spec.rb
 - spec/item/becomes_spec.rb