lhs 14.1.0 → 14.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 504f8883ad45f75b004de4cbf3dbf5aa1e9e12bc
-  data.tar.gz: 1076be76ce857bc401a2222e7c1459cf9f300901
+  metadata.gz: 410e4fb105669f81e2f5d2597bfce8e70067ce22
+  data.tar.gz: 242bab7a1495a4b232b1ef25f99eef6f307c657d
 SHA512:
-  metadata.gz: 41286eb7d5bcf95c24c39d67ac6c5d35460d66514ead66bebcbcda7256c8322ab7706058c1920ffceb00e1fd9e887baa05285d8eb43fd40e03c438b4b8f2f648
-  data.tar.gz: b1401bde9eb82be62b2d90750adfbaae6b23349054e088b9142db8b8ddfabdde92841c7a61701a24a53bb183d49e2b3b5f9301b4cdefd4c6bcdf1a8ef39b13ee
+  metadata.gz: b36a19677807863f4dafee0c9bc939b89ba922f76b1493610746b0c54a06dc8aa29e3fbed82c4992e1c72591e605c36fc9640680e316294cb733a2b578940ab6
+  data.tar.gz: 410dbbf82a0172b9604dc2c5ca91a5352a8b095f715a8c9347aff46e51a5699d761d316c0e4c89887924d1d27ef6ad820593b16ca095b780ed4ad8eae66a5efc

data/lib/lhs.rb

@@ -40,6 +40,9 @@ module LHS
   autoload :Record,
     'lhs/record'
 
+  autoload :Unprocessable,
+    'lhs/unprocessable'
+
   include Configuration
   include AutoloadRecords if defined?(Rails)
 

data/lib/lhs/concerns/record/find.rb

@@ -9,8 +9,9 @@ class LHS::Record
       # Find a single uniqe record
       def find(*args)
         args, options = process_args(args)
+        raise(LHS::Unprocessable.new, 'Cannot find Record without an ID') if args.blank? && !args.is_a?(Array)
         data =
-          if args.is_a? Array
+          if args.present? && args.is_a?(Array)
             find_in_parallel(args, options)
           elsif args.is_a? Hash
             find_with_parameters(args, options)
@@ -65,8 +66,10 @@ class LHS::Record
           options.merge(params: args)
         elsif href?(args)
           options.merge(url: args)
-        else
+        elsif args.present?
           options.merge(params: { id: args })
+        else
+          options
         end
       end
 

data/lib/lhs/concerns/record/find_by.rb

@@ -21,6 +21,7 @@ class LHS::Record
       private
 
       def _find_by(params, options = {})
+        raise(LHS::Unprocessable.new, 'Cannot find Record without an ID') if params.any? && params.all? { |_, value| value.blank? }
         options ||= {}
         params = params.dup.merge(limit: 1).merge(options.fetch(:params, {}))
         data = request(options.merge(params: params))

data/lib/lhs/unprocessable.rb

@@ -0,0 +1,4 @@
+module LHS
+  class Unprocessable < StandardError
+  end
+end

data/lib/lhs/version.rb

@@ -1,3 +1,3 @@
 module LHS
-  VERSION = '14.1.0'
+  VERSION = '14.1.1'
 end

data/spec/record/find_by_spec.rb

@@ -38,6 +38,10 @@ describe LHS::Record do
         Record.find_by(has_reviews: true).id
       ).to eq json['items'].first['id']
     end
+
+    it 'returns nil if empty id' do
+      expect { Record.find_by(id: '') }.to raise_error LHS::Unprocessable
+    end
   end
 
   context 'find_by!' do

data/spec/record/find_spec.rb

@@ -33,50 +33,70 @@ describe LHS::Record do
       end
     end
 
-    it 'raises if nothing was found' do
-      stub_request(:get, "#{datastore}/feedbacks/not-existing")
-        .to_return(status: 404)
-      expect { Record.find('not-existing') }.to raise_error LHC::NotFound
-    end
+    context 'endpoint without identifier' do
+      before :each do
+        class LatestAGB < LHS::Record
+          endpoint 'agbs/latest'
+        end
+      end
 
-    it 'finds unique item by providing parameters' do
-      stub_request(:get, "#{datastore}/content-ads/123/feedbacks/123")
-        .to_return(body: "{}")
-      data = Record.find(campaign_id: '123', id: '123')
-      expect(data._proxy).to be_kind_of LHS::Item
-    end
+      it 'finds a single unique record' do
+        stub_request(:get, 'http://agbs/latest')
+          .to_return(body: { pdf: 'http://local.ch/1.pdf' }.to_json)
 
-    it 'returns item in case of backend returning collection' do
-      data = JSON.parse(load_json(:feedbacks))
-      data['items'] = [data['items'].first]
-      stub_request(:get, "#{datastore}/content-ads/123/feedbacks/123")
-        .to_return(body: data.to_json)
-      data = Record.find(campaign_id: '123', id: '123')
-      expect(data._proxy).to be_kind_of LHS::Item
+        expect(LatestAGB.find.pdf).to eq 'http://local.ch/1.pdf'
+      end
     end
 
-    it 'fails when multiple items where found by parameters' do
-      stub_request(:get, "#{datastore}/content-ads/123/feedbacks/123")
-        .to_return(body: load_json(:feedbacks))
-      expect(lambda {
-        Record.find(campaign_id: '123', id: '123')
-      }).to raise_error LHC::NotFound
-    end
+  end
 
-    it 'fails when no item as found by parameters' do
-      data = JSON.parse(load_json(:feedbacks))
-      data['items'] = []
-      stub_request(:get, "#{datastore}/content-ads/123/feedbacks/123")
-        .to_return(body: data.to_json)
-      expect(lambda {
-        Record.find(campaign_id: '123', id: '123')
-      }).to raise_error LHC::NotFound
-    end
+  it 'raises if empty id' do
+    expect { Record.find('') }.to raise_error LHS::Unprocessable
+  end
 
-    it 'raises if nothing was found with parameters' do
-      stub_request(:get, "#{datastore}/content-ads/123/feedbacks/123")
-        .to_return(status: 404)
-      expect { Record.find(campaign_id: '123', id: '123') }.to raise_error LHC::NotFound
-    end
+  it 'raises if nothing was found' do
+    stub_request(:get, "#{datastore}/feedbacks/not-existing")
+      .to_return(status: 404)
+    expect { Record.find('not-existing') }.to raise_error LHC::NotFound
+  end
+
+  it 'finds unique item by providing parameters' do
+    stub_request(:get, "#{datastore}/content-ads/123/feedbacks/123")
+      .to_return(body: "{}")
+    data = Record.find(campaign_id: '123', id: '123')
+    expect(data._proxy).to be_kind_of LHS::Item
+  end
+
+  it 'returns item in case of backend returning collection' do
+    data = JSON.parse(load_json(:feedbacks))
+    data['items'] = [data['items'].first]
+    stub_request(:get, "#{datastore}/content-ads/123/feedbacks/123")
+      .to_return(body: data.to_json)
+    data = Record.find(campaign_id: '123', id: '123')
+    expect(data._proxy).to be_kind_of LHS::Item
+  end
+
+  it 'fails when multiple items where found by parameters' do
+    stub_request(:get, "#{datastore}/content-ads/123/feedbacks/123")
+      .to_return(body: load_json(:feedbacks))
+    expect(lambda {
+      Record.find(campaign_id: '123', id: '123')
+    }).to raise_error LHC::NotFound
+  end
+
+  it 'fails when no item as found by parameters' do
+    data = JSON.parse(load_json(:feedbacks))
+    data['items'] = []
+    stub_request(:get, "#{datastore}/content-ads/123/feedbacks/123")
+      .to_return(body: data.to_json)
+    expect(lambda {
+      Record.find(campaign_id: '123', id: '123')
+    }).to raise_error LHC::NotFound
+  end
+
+  it 'raises if nothing was found with parameters' do
+    stub_request(:get, "#{datastore}/content-ads/123/feedbacks/123")
+      .to_return(status: 404)
+    expect { Record.find(campaign_id: '123', id: '123') }.to raise_error LHC::NotFound
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lhs
 version: !ruby/object:Gem::Version
-  version: 14.1.0
+  version: 14.1.1
 platform: ruby
 authors:
 - https://github.com/local-ch/lhs/graphs/contributors
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-09-19 00:00:00.000000000 Z
+date: 2017-09-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lhc
@@ -245,6 +245,7 @@ files:
 - lib/lhs/railtie.rb
 - lib/lhs/record.rb
 - lib/lhs/test/request_cycle_cache_helper.rb
+- lib/lhs/unprocessable.rb
 - lib/lhs/version.rb
 - script/ci/build.sh
 - spec/.DS_Store
@@ -419,7 +420,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements:
 - Ruby >= 2.3.0
 rubyforge_project: 
-rubygems_version: 2.6.8
+rubygems_version: 2.6.13
 signing_key: 
 specification_version: 4
 summary: Rails gem providing an easy, active-record-like interface for http json services