lhs 13.2.2 → 13.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 817ac42fa13f753a81ae3cdb118c1603c69e621b
-  data.tar.gz: 9c25357f8dd19e34c89060cd8937e267b3d72d08
+  metadata.gz: 2bda2ff4ae84ce367ee21ad8922b46e600b288c5
+  data.tar.gz: c8fc0746ffca39f2b7e5ad370ba71cc884535ec9
 SHA512:
-  metadata.gz: d2d61991d9f8c997258796996c74221658f4c6d6e49fd99138794add22d60587ae54b4ef38fe0067fd9779d8b5f7c62a0cc76f907b029c428e18bb5881f21b8c
-  data.tar.gz: c50e17144b9e7dc502537524659fcdc2f52053697e9c031edb4e560b8fb2f80f3c7683b6b06b3c018a69ad768d82d90031a69cd7725753b08cc2701fe46936bd
+  metadata.gz: e298a06e35a61cdbaddbceffc23e7e982e4387b9d21c7753165202e309bc0e463339b511039abf20c3038c389460e4676ef2ce933a285b83cb53b6543ffb180b
+  data.tar.gz: d2020691e22febd3f22256c2f689d093e65fd92fb0bb5519ff5413905f54f6a946fe5ce8cbb83ba9b2681322033f7f93ec26f50c4eba56b19e92cb580b267c1c

data/lib/lhs/pagination/base.rb

@@ -11,15 +11,13 @@ module LHS::Pagination
       self.data = data
     end
 
-    # as standard in Rails' ActiveRecord count is not summing up, but using the number provided from data source
-    def count
-      total
-    end
-
     def total
-      data._raw.dig(*_record.total_key)
+      data._raw.dig(*_record.total_key) || 0
     end
 
+    # as standard in Rails' ActiveRecord count is not summing up, but using the number provided from data source
+    alias count total
+
     def limit
       data._raw.dig(*_record.limit_key) || DEFAULT_LIMIT
     end

data/lib/lhs/version.rb

@@ -1,3 +1,3 @@
 module LHS
-  VERSION = "13.2.2"
+  VERSION = "13.2.3"
 end

data/spec/data/collection_spec.rb

@@ -15,6 +15,21 @@ describe LHS::Data do
     end
   end
 
+  context 'empty collection' do
+    let(:collection) do
+      LHS::Data.new({ items: [] }, nil, Record)
+    end
+
+    it 'provides correct count and length' do
+      expect(collection.count).to eq 0
+      expect(collection.length).to eq 0
+    end
+
+    it 'returns an empty array or map' do
+      expect(collection.map { |x| }).to eq []
+    end
+  end
+
   context 'collections' do
     it 'forwards calls to the collection' do
       expect(data.count).to be_kind_of Integer

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lhs
 version: !ruby/object:Gem::Version
-  version: 13.2.2
+  version: 13.2.3
 platform: ruby
 authors:
 - https://github.com/local-ch/lhs/graphs/contributors
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-08-22 00:00:00.000000000 Z
+date: 2017-08-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lhc
@@ -417,7 +417,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements:
 - Ruby >= 2.3.0
 rubyforge_project: 
-rubygems_version: 2.6.12
+rubygems_version: 2.6.8
 signing_key: 
 specification_version: 4
 summary: Rails gem providing an easy, active-record-like interface for http json services