lhs 13.1.0 → 13.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 619fa442b169b251cb6501e59940d0c587010de6
-  data.tar.gz: e0fdac02b30115bab5c2e98eb8e1f0847d042921
+  metadata.gz: d47809d2cae46a30a0e8e5fb00efc3f739b81d42
+  data.tar.gz: 8c8aa4ec034214fc41b036de60adefcdb5b50d8b
 SHA512:
-  metadata.gz: ab7fcafa5689e4796f82a7c2da65600c60068dbb2325763775f8d5db833d1814730d91b1819e97f7e29aa51001cc5225e983b2fb58a52ae106fcc269a3f27dd7
-  data.tar.gz: 6f73e3433aa5e955c336da8b2dddc8aebd9b557b8256efd2bf4adc6503376fb75951055d0cddc759f8b3f6efa4509a64c280bf052be8791d0cad00edb4b3bda6
+  metadata.gz: e5d28cf68e8ee0a2946d2bfe9e21381e7e2c8616484eb09877725af9f066483b4554fd55fcdb467a273210fc208dc2638973a56a3810fa7d7ca1176ed6298c94
+  data.tar.gz: 50c2a89618fef4370369b85a18aa485de740d17f270954786d8adf83b9044ca7f9ead3ace0262cf0d4612da5b6f3406ed04df7e7de372ad3bddb8cfdd8fefc6c

data/README.md

@@ -183,7 +183,7 @@ record = Record.where(color: 'blue')
 
 If an error handler returns `nil` an empty LHS::Record is returned, not `nil`!
 
-In case you want to ignore errores and continue working with `nil` in those cases,
+In case you want to ignore errors and continue working with `nil` in those cases,
 please use `ignore`:
 
 ```ruby

data/lib/lhs/concerns/record/chainable.rb

@@ -45,8 +45,12 @@ class LHS::Record
         Chain.new(self, ErrorHandling.new(error_class => handler))
       end
 
-      def ignore(error_class)
-        Chain.new(self, IgnoredError.new(error_class))
+      def ignore(*error_classes)
+        chain = Chain.new(self, IgnoredError.new(error_classes.shift))
+        error_classes.each do |error_class|
+          chain._links.push(IgnoredError.new(error_class))
+        end
+        chain
       end
 
       def includes(*args)
@@ -201,8 +205,12 @@ class LHS::Record
         push(Option.new(hash))
       end
 
-      def ignore(error_class)
-        push(IgnoredError.new(error_class))
+      def ignore(*error_classes)
+        chain = push(IgnoredError.new(error_classes.shift))
+        error_classes.each do |error_class|
+          chain._links.push(IgnoredError.new(error_class))
+        end
+        chain
       end
 
       def page(page)
@@ -381,7 +389,7 @@ class LHS::Record
       end
 
       def chain_pagination
-        @chain_pagination ||= resolve_pagination _links.select { |link| link.is_a? Pagination }
+        @chain_pagination ||= resolve_pagination(_links.select { |link| link.is_a? Pagination })
       end
 
       def chain_includes

data/lib/lhs/concerns/record/request.rb

@@ -22,7 +22,7 @@ class LHS::Record
       private
 
       def filter_empty_request_options(options)
-        options.each_with_index.map do |option|
+        options.map do |option|
           option if !option || !option.key?(:url) || !option[:url].nil?
         end
       end

data/lib/lhs/version.rb

@@ -1,3 +1,3 @@
 module LHS
-  VERSION = "13.1.0"
+  VERSION = "13.2.0"
 end

data/spec/record/ignore_errors_spec.rb

@@ -11,11 +11,8 @@ describe LHS::Record do
   end
 
   context 'ignore errors' do
-    before(:each) do
-      stub_request(:get, "http://local.ch/v2/records?color=blue").to_return(status: 404)
-    end
-
     it 'allows to ignore errors' do
+      stub_request(:get, "http://local.ch/v2/records?color=blue").to_return(status: 404)
       record = Record
         .where(color: 'blue')
         .ignore(LHC::NotFound)
@@ -54,4 +51,31 @@ describe LHS::Record do
       .fetch
     expect(record).to eq nil
   end
+
+  it 'can ignore multiple error with one ignore call' do
+    stub_request(:get, "http://local.ch/v2/records?color=blue").to_return(status: 401)
+    record = Record
+      .ignore(LHC::Unauthorized, LHC::NotFound)
+      .where(color: 'blue')
+      .fetch
+    expect(record).to eq nil
+  end
+
+  it 'can ignore multiple error with one ignore call, on chain start' do
+    stub_request(:get, "http://local.ch/v2/records?color=blue").to_return(status: 401)
+    record = Record
+      .ignore(LHC::Unauthorized, LHC::NotFound)
+      .where(color: 'blue')
+      .fetch
+    expect(record).to eq nil
+  end
+
+  it 'can ignore multiple error with one ignore call, also within the chain' do
+    stub_request(:get, "http://local.ch/v2/records?color=blue").to_return(status: 401)
+    record = Record
+      .where(color: 'blue')
+      .ignore(LHC::Unauthorized, LHC::NotFound)
+      .fetch
+    expect(record).to eq nil
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lhs
 version: !ruby/object:Gem::Version
-  version: 13.1.0
+  version: 13.2.0
 platform: ruby
 authors:
 - https://github.com/local-ch/lhs/graphs/contributors