lhs 11.3.2 → 11.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5bbf841e955ed23fe6c7efbf8f8fe7b05fc35538
-  data.tar.gz: d331ac41f574be37f783b10ff7c53fe43c592a8f
+  metadata.gz: b17c90e65dafbd6cc36a2e8ebfead0e7abee819c
+  data.tar.gz: 8ad952d7bebb07cfdb417dd5db4519cac2a80dbc
 SHA512:
-  metadata.gz: 3c0a3fee58998e8c51a25c16702a17b20cec97498979863040b2120d51a776e6333733c807e1940105f24e15b987d2d84e50a50c7fbf4846e1aff472b1e840d2
-  data.tar.gz: 6cb8b54105e3579b76e3ff9d9a26c3d738a85e73eb4ded2a93343a176b3231a99fc88bb7f39cc956faf3375bbc7bf46edd8b51088632ad7eb6cacb3aab8926d1
+  metadata.gz: 40d3b01be43d424b9e2b19d7ad029b5e985988bcebcfa324e932836f8d608993f195eb93ee10ed2f77ea95bcab1c15fec3a3bfba7bbd3e8fdc180bd7dff7e16a
+  data.tar.gz: b8207ba3f7623a428faa2904c70514b3cc37afbc40a131be76e2c07018cb65f9ed4d364b229db7351fb16ecc899fe8f4df6aef32eb41085bffa1937a3041f1a5

data/lib/lhs/collection.rb

@@ -7,7 +7,7 @@ class LHS::Collection < LHS::Proxy
   include InternalCollection
   include Create
 
-  METHOD_NAMES_EXLCUDED_FROM_WRAPPING = %w(to_a map).freeze
+  METHOD_NAMES_EXLCUDED_FROM_WRAPPING = %w(to_a to_ary map).freeze
 
   delegate :select, :length, :size, to: :_collection
   delegate :_record, :_raw, to: :_data

data/lib/lhs/concerns/collection/internal_collection.rb

@@ -21,6 +21,10 @@ class LHS::Collection < LHS::Proxy
         @record = record
       end
 
+      def to_ary
+        map { |item| item }
+      end
+
       def each(&_block)
         raw.each do |item|
           if item.is_a? Hash

data/lib/lhs/errors/base.rb

@@ -8,11 +8,11 @@ module LHS::Errors
     def initialize(response = nil, record = nil)
       @raw = response.body if response
       @record = record
-      @messages = messages_from_response(response)
+      @messages = messages_from_response(response).with_indifferent_access
       @message = message_from_response(response)
       @status_code = response.code if response
     rescue JSON::ParserError
-      @messages = messages || {}
+      @messages = (messages || {}).with_indifferent_access
       @message = 'parse error'
       add_error(@messages, 'body', 'parse error')
     end

data/lib/lhs/version.rb

@@ -1,3 +1,3 @@
 module LHS
-  VERSION = "11.3.2"
+  VERSION = "11.3.3"
 end

data/spec/collection/to_ary_spec.rb

@@ -0,0 +1,34 @@
+require 'rails_helper'
+
+describe LHS::Collection do
+  let(:items) { [{ name: 'Steve' }] }
+  let(:extra) { 'extra' }
+  let(:collection) { Record.where }
+
+  context 'to_ary' do
+    before(:each) do
+      class Record < LHS::Record
+        endpoint 'http://datastore/records`'
+      end
+      stub_request(:get, %r{http://datastore/records})
+        .to_return(body: response_data.to_json)
+    end
+
+    let(:response_data) do
+      {
+        items: items,
+        extra: extra,
+        total: 1
+      }
+    end
+
+    let(:subject) { collection.to_ary }
+
+    it 'returns an array' do
+      expect(subject).to be
+      expect(subject).to be_kind_of Array
+      expect(subject[0]).to be_kind_of Record
+      expect(subject[0].name).to eq 'Steve'
+    end
+  end
+end

data/spec/item/add_error_spec.rb

@@ -13,7 +13,7 @@ describe LHS::Item do
       subject.errors.add(:name, 'This date is invalid')
       expect(
         subject.errors.first
-      ).to eq [:name, 'This date is invalid']
+      ).to eq ['name', 'This date is invalid']
     end
   end
 end

data/spec/item/errors_spec.rb

@@ -75,6 +75,14 @@ describe LHS::Item do
       expect(record.errors[:recommended]).to eq ['REQUIRED_PROPERTY_VALUE']
     end
 
+    it 'allows accessing error messages as a hash with indifferent access' do
+      stub_request(:post, "#{datastore}/feedbacks")
+        .to_return(status: 400, body: error_format_fields.to_json)
+      record.save
+      expect(record.errors.messages[:ratings]).to be
+      expect(record.errors.messages['ratings']).to be
+    end
+
     it 'parses field errors correctly when creation failed' do
       stub_request(:post, "#{datastore}/feedbacks")
         .to_return(status: 400, body: error_format_field_errors.to_json)

data/spec/record/creation_failed_spec.rb

@@ -40,7 +40,7 @@ describe LHS::Record do
       expect(record.errors.include?(:ratings)).to eq true
       expect(record.errors.include?(:recommended)).to eq true
       expect(record.errors[:ratings]).to eq ['REQUIRED_PROPERTY_VALUE']
-      expect(record.errors.messages).to eq(ratings: ["REQUIRED_PROPERTY_VALUE"], recommended: ["REQUIRED_PROPERTY_VALUE"])
+      expect(record.errors.messages).to eq('ratings' => ["REQUIRED_PROPERTY_VALUE"], 'recommended' => ["REQUIRED_PROPERTY_VALUE"])
       expect(record.errors.message).to eq error_message
     end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lhs
 version: !ruby/object:Gem::Version
-  version: 11.3.2
+  version: 11.3.3
 platform: ruby
 authors:
 - https://github.com/local-ch/lhs/graphs/contributors
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-06-22 00:00:00.000000000 Z
+date: 2017-06-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lhc
@@ -240,6 +240,7 @@ files:
 - spec/collection/meta_data_spec.rb
 - spec/collection/respond_to_spec.rb
 - spec/collection/to_a_spec.rb
+- spec/collection/to_ary_spec.rb
 - spec/collection/without_object_items_spec.rb
 - spec/complex/reduce_spec.rb
 - spec/concerns/record/request_spec.rb
@@ -405,6 +406,7 @@ test_files:
 - spec/collection/meta_data_spec.rb
 - spec/collection/respond_to_spec.rb
 - spec/collection/to_a_spec.rb
+- spec/collection/to_ary_spec.rb
 - spec/collection/without_object_items_spec.rb
 - spec/complex/reduce_spec.rb
 - spec/concerns/record/request_spec.rb