lhs 11.3.0 → 11.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8307d10c28c26b8729eda6306f597fdb1b133e56
-  data.tar.gz: 778c8d4b05f16cbbae4947d8088f58a021b36219
+  metadata.gz: e5038abb8bd075bd7aba160cdcf81b0e3de7cda4
+  data.tar.gz: 297b1925f5aedc7973493511a1ae318e39064a01
 SHA512:
-  metadata.gz: 7afd36265f9a8d867107b0085bc17b5daaa8b97cb203a2ca9ffc58d6bdcbda8b4ec82e15628a4cda447c23a192ed45f2ce12fc09cd14918a1f114e5885918250
-  data.tar.gz: dfba64d011e51cd084d0de36ac99e90f2f2696e8f2eb22faf2f356b5cb7fdb2122bb6409793df17b7a3b24c6205287b19ce6ef82dbdbc214ca34285f08366e80
+  metadata.gz: a252ae3732d5dc6e93e5ea5a625d8ec01d2f1e857b0e1f2e22146f1ec6d4a0057d2ef1f8ae0f42b4fce5ca0bf22ceadac3e6656b2c03f3ecbeadcf97383224ae
+  data.tar.gz: cbd5a929459c15e3bc02cd3094228215e63d3f987f851729a174045c0522f21c8e16a82ec55a7568b210bfc29856d0330a5660f1c0ceb4b007c88183c10a2ff2

data/lib/lhs/errors/base.rb

@@ -32,23 +32,24 @@ module LHS::Errors
       messages[key]
     end
 
-    def set(key, value)
-      messages[key] = generate_message(key, value)
+    def set(key, message)
+      return if message.blank?
+      messages[key] = [generate_message(key, message)]
     end
 
     delegate :delete, to: :messages
 
     def [](attribute)
-      get(attribute.to_sym) || set(attribute.to_sym, [])
+      get(attribute.to_sym) || messages[attribute] = []
     end
 
-    def []=(attribute, error)
-      self[attribute] << generate_message(attribute, error)
+    def []=(attribute, message)
+      self[attribute] << generate_message(attribute, message)
     end
 
     def each
       messages.each_key do |attribute|
-        self[attribute].each { |error| yield attribute, error }
+        self[attribute].each { |message| yield attribute, message }
       end
     end
 

data/lib/lhs/version.rb

@@ -1,3 +1,3 @@
 module LHS
-  VERSION = "11.3.0"
+  VERSION = "11.3.1"
 end

data/spec/item/errors_spec.rb

@@ -197,7 +197,7 @@ describe LHS::Item do
 
     let(:record) do
       Record.build(
-        reviews: [{ name: 123 }],
+        reviews: [{ name: 123, suggested: false }],
         address: {
           additional_line1: '',
           street: {
@@ -241,5 +241,26 @@ describe LHS::Item do
       record.save
       expect(record.errors.status_code).to eq 400
     end
+
+    context 'with general error fallback message configured' do
+      before(:each) do
+        I18n.reload!
+        I18n.backend.store_translations(:en, YAML.safe_load(translation)) if translation.present?
+      end
+
+      let(:translation) do
+        %q{
+          lhs:
+            errors:
+              fallback_message: 'This value is wrong'
+        }
+      end
+
+      it 'is capable to access errors/attributes that dont have any validation errors' do
+        record.save
+        expect(record.reviews.first.errors[:suggested]).to be_kind_of Array
+        expect(record.reviews.first.errors[:suggested]).to be_empty
+      end
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lhs
 version: !ruby/object:Gem::Version
-  version: 11.3.0
+  version: 11.3.1
 platform: ruby
 authors:
 - https://github.com/local-ch/lhs/graphs/contributors