lhs 11.2.0 → 11.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ec9e7eae2816a09a270575802d332cf27a0a4ae5
-  data.tar.gz: fee348a432bdace92a25a94a48efc319d0ed848d
+  metadata.gz: 03ef3cf453e687b887eecf083b9db24027367077
+  data.tar.gz: 813cf6662e7e1b84fc88f7bbea58e9ede0bd78f9
 SHA512:
-  metadata.gz: e7e1fd9491380f0bf1cf439d4e895e515160922bcf10df80c92b542b50b0eed85e6d78a5f3a78459db26ab098a252aad52f7f8e3f7b1a4c6d78e6bb66c1ab982
-  data.tar.gz: 75201af82683c6d58d8f7270f8b309ada0a6d81ea4c37bd9ebaebd445614813dcf82e9cbfa8f279291aa1bc64ad7f90eca9f61506163b223a6ef545cd87b176e
+  metadata.gz: bbab32a774d4fc31d35cec8a4a58d4ab9727f8605073ff4887b01fe6714248d77140987767e2d7c58a086869784d322114daebe637387440feb0286a26935163
+  data.tar.gz: e8e4c55d6c74e2286d0adc4cb77295d95df5bf902a8984e552ee5e719eee7db55222c604356e79a63296f0b94c9dcea91c343bc78931744433d478e1b5cb13c6

data/lib/lhs/errors/base.rb

@@ -85,21 +85,28 @@ module LHS::Errors
     end
 
     def find_translated_error_message(attribute, message)
-      record_name = record.model_name.name.underscore
       normalized_attribute = attribute.to_s.underscore
       normalized_message = message.to_s.underscore
-      [
-        ['lhs', 'errors', 'records', record_name, 'attributes', normalized_attribute, normalized_message],
-        ['lhs', 'errors', 'records', record_name, normalized_message],
+      messages = []
+      messages = messages_for_record(normalized_attribute, normalized_message) if record
+      messages.concat([
         ['lhs', 'errors', 'messages', normalized_message],
         ['lhs', 'errors', 'attributes', normalized_attribute, normalized_message],
         ['lhs', 'errors', 'fallback_message']
-      ].detect do |path|
+      ]).detect do |path|
         key = path.join('.')
         return I18n.translate(key) if I18n.exists?(key)
       end
     end
 
+    def messages_for_record(normalized_attribute, normalized_message)
+      record_name = record.model_name.name.underscore
+      [
+        ['lhs', 'errors', 'records', record_name, 'attributes', normalized_attribute, normalized_message],
+        ['lhs', 'errors', 'records', record_name, normalized_message]
+      ]
+    end
+
     def parse_messages(json)
       messages = {}
       fields_to_errors(json, messages) if json['fields']

data/lib/lhs/version.rb

@@ -1,3 +1,3 @@
 module LHS
-  VERSION = "11.2.0"
+  VERSION = "11.2.1"
 end

data/spec/item/errors_spec.rb

@@ -228,5 +228,13 @@ describe LHS::Item do
       expect(record.reviews.last.errors).to be
       expect(record.reviews.last.errors[:name]).to include 'UNSUPPORTED_PROPERTY_VALUE'
     end
+
+    context 'accessing no model' do
+      it 'does not raise an error when trying to find error record model name' do
+        expect(lambda do
+          record.reviews.first.errors[:name]
+        end).not_to raise_error(NoMethodError)
+      end
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lhs
 version: !ruby/object:Gem::Version
-  version: 11.2.0
+  version: 11.2.1
 platform: ruby
 authors:
 - https://github.com/local-ch/lhs/graphs/contributors
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-06-02 00:00:00.000000000 Z
+date: 2017-06-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lhc