lhs 10.1.1 → 11.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d731571239e67a0d0debebd692bce21a6082df6f
-  data.tar.gz: 43fb5ba6cf39fd0bec77356b882f345003edd7e5
+  metadata.gz: 47b77a705ee21920e7c48515fdf200b60bb2be61
+  data.tar.gz: d85c7e29b814b6ddda3c0729c1adfb405cc6e873
 SHA512:
-  metadata.gz: 9bc0b8b031eb8dd7da567ff0df100467bb9bef7ce48260a88d1814e8552aab1f2f52767abb037ccd04ebde3e5de8949123b423b8d3e06a908b949c9d1291f51a
-  data.tar.gz: 7a35a18d6a5776cb5186f4119f3b97c897aa590b022c6278f5b96a0d09f2d6c742ede1dfa94903382d8a285085cbb55db2f9770ca08d8e48e0bcedcbfd8dc2ae
+  metadata.gz: 6351281d1b7f3d3c5cc08fe91ac35f6a747d6ffa543a41b9a6737e2634bc714fe1a340453ab887030af652063afdd3305c4da811ef1bafaab8acb89ba0cd12bf
+  data.tar.gz: 8aef3ee080ad5d7b6d0937138434ab2758b3941dfdfcc4fddbc38beb5a1dc16507b2929a4069dbc8ee5fbb09c4a59757a1adbfc3f1bab0cb23f8644fa43f0cf1

data/.gitignore

@@ -24,6 +24,7 @@ config/secrets.yml
 
 # these should all be checked in to normalise the environment:
 Gemfile.lock
+Gemfile.*.lock
 .ruby-gemset
 
 # unless supporting rvm < 1.11.0 or doing something fancy, ignore this:

data/Gemfile.activesupport4

@@ -0,0 +1,4 @@
+source 'https://rubygems.org/'
+
+gemspec
+gem 'activesupport', '~> 4.2.0'

data/Gemfile.activesupport5

@@ -0,0 +1,4 @@
+source 'https://rubygems.org/'
+
+gemspec
+gem 'activesupport', '~> 5.0.0'

data/README.md

@@ -3,6 +3,21 @@ LHS
 
 LHS uses [LHC](//github.com/local-ch/LHC) for http requests.
 
+## Quickstart
+
+```
+gem 'lhs'
+```
+
+LHS comes with Request Cycle Cache – enabled by default. It requires [LHC Caching Interceptor](https://github.com/local-ch/lhc/blob/master/docs/interceptors/caching.md) to be enabled:
+
+```ruby
+# intializers/lhc.rb 
+LHC.configure do |config|
+  config.interceptors = [LHC::Caching]
+end
+```
+
 ## Very Short Introduction
 
 Access data that is provided by an http json service with ease using a LHS::Record.
@@ -27,15 +42,13 @@ Please store all defined LHS::Records in `app/models` as they are not autoloaded
 
 You setup a LHS::Record by configuring one or multiple endpoints. You can also add request options for an endpoint (see following example).
 
-The following example uses the `LHC::Caching` interceptor from [lhc-core-interceptors](https://github.com/local-ch/lhc-core-interceptors#cache-interceptor).
-
 ```ruby
 class Record < LHS::Record
 
   endpoint ':service/v2/association/:association_id/records'
   endpoint ':service/v2/association/:association_id/records/:id'
-  endpoint ':service/v2/records', cache: true, cache_expires_in: 1.day
-  endpoint ':service/v2/records/:id', cache: true, cache_expires_in: 1.day
+  endpoint ':service/v2/records', auth: { basic: 'PASSWORD' }
+  endpoint ':service/v2/records/:id', auth: { basic: 'PASSWORD' }
 
 end
 ```
@@ -179,7 +192,7 @@ record = Record.where(color: 'blue')
 
 If no record is found an error is raised.
 
-`find` can also be used to find a single uniqe record with parameters:
+`find` can also be used to find a single unique record with parameters:
 
 ```ruby
   Record.find(association_id: 123, id: 456)
@@ -262,6 +275,22 @@ You can apply options to the request chain. Those options will be forwarded to t
   authenticated_record.update(name: 'Steve')
 ```
 
+## Request Cycle Cache
+
+By default, LHS does not perform the same http request during one request cycle multiple times. 
+
+It uses the [LHC Caching Interceptor](https://github.com/local-ch/lhc/blob/master/docs/interceptors/caching.md) as caching mechanism base and sets a unique request id for every request cycle with Railties to ensure data is just cached within one request cycle and not shared with other requests.
+
+Only GET requests are considered for caching by using LHC Caching Interceptor's `cache_methods` option internaly and considers request headers when caching requests, so requests with different headers are not served from cache.
+
+The LHS Request Cycle Cache is opt-out, so it's enabled by default and will require you to enable the [LHC Caching Interceptor](https://github.com/local-ch/lhc/blob/master/docs/interceptors/caching.md) in your project.
+
+If you want to disable the LHS Request Cycle Cache, simply disable it within configuration:
+
+```ruby
+LHS.config.request_cycle_cache_enabled = false
+```
+
 ## Batch processing
 
 **Be careful using methods for batch processing. They could result in a lot of HTTP requests!**

data/Rakefile

@@ -5,7 +5,6 @@ rescue LoadError
 end
 
 require 'rdoc/task'
-
 RDoc::Task.new(:rdoc) do |rdoc|
   rdoc.rdoc_dir = 'rdoc'
   rdoc.title    = 'LHS'
@@ -23,4 +22,4 @@ rescue LoadError
 end
 
 Bundler::GemHelper.install_tasks
- 
+ 

data/cider-ci.yml

@@ -1,4 +1,6 @@
 jobs:
   include:
-    - cider-ci/jobs/rspec.yml
+    - cider-ci/jobs/rspec-activesupport-4.yml
+    - cider-ci/jobs/rspec-activesupport-5.yml
+    - cider-ci/jobs/rspec-activesupport-latest.yml
     - cider-ci/jobs/rubocop.yml

data/cider-ci/bin/bundle

@@ -15,13 +15,23 @@ DIGEST=$(git ls-tree HEAD --\
   cider-ci.yml cider-ci Gemfile.lock \
   | openssl dgst -sha1 | cut -d ' ' -f 2)
 
+if [ ! -z ${ACTIVESUPPORT:-} ]; then
+  DIGEST=$(echo "$DIGEST $ACTIVESUPPORT")
+fi
+
 DIGEST=$(echo "$DIGEST $PATH" \
  | openssl dgst -sha1 | cut -d ' ' -f 2)
 
 CACHE_SIGNATURE_FILE="/tmp/bundle_cache_signature_${DIGEST}"
 
 if [ ! -f  $CACHE_SIGNATURE_FILE ] ; then
-  bundle install
+  if [ ! -z ${ACTIVESUPPORT:-} ]; then
+    echo "BUNDLE_GEMFILE=Gemfile.activesupport$ACTIVESUPPORT bundle install"
+    BUNDLE_GEMFILE=Gemfile.activesupport$ACTIVESUPPORT bundle install
+  else 
+    echo "bundle install"
+    bundle install
+  fi
   touch $CACHE_SIGNATURE_FILE
 fi
 

data/cider-ci/jobs/rspec-activesupport-4.yml

@@ -0,0 +1,26 @@
+rspec-active-support-v4:
+  name: 'rspec with ActiveSupport v4'
+
+  run_when:
+    'some HEAD has been updated':
+      type: branch
+      include_match: ^.*$
+
+  context:
+
+    script_defaults:
+      template_environment_variables: true
+
+    task_defaults:
+      environment_variables:
+        ACTIVESUPPORT: '4'
+      max_trials: 2
+      dispatch_storm_delay_duration: 1 Seconds
+      include:
+        - cider-ci/task_components/ruby.yml
+        - cider-ci/task_components/bundle.yml
+        - cider-ci/task_components/rspec.yml
+
+    tasks:
+      all-rspec:
+        name: All rspec tests, using ActiveSupport v4

data/cider-ci/jobs/rspec-activesupport-5.yml

@@ -0,0 +1,26 @@
+rspec-active-support-v5:
+  name: 'rspec with ActiveSupport v5'
+
+  run_when:
+    'some HEAD has been updated':
+      type: branch
+      include_match: ^.*$
+
+  context:
+
+    script_defaults:
+      template_environment_variables: true
+
+    task_defaults:
+      environment_variables:
+        ACTIVESUPPORT: '5'
+      max_trials: 2
+      dispatch_storm_delay_duration: 1 Seconds
+      include:
+        - cider-ci/task_components/ruby.yml
+        - cider-ci/task_components/bundle.yml
+        - cider-ci/task_components/rspec.yml
+
+    tasks:
+      all-rspec:
+        name: All rspec tests, using ActiveSupport v5

data/cider-ci/jobs/{rspec.yml → rspec-activesupport-latest.yml}

@@ -1,5 +1,5 @@
-rspec:
-  name: 'rspec'
+rspec-active-support-latest:
+  name: 'rspec with ActiveSupport latest'
 
   run_when:
     'some HEAD has been updated':
@@ -21,4 +21,4 @@ rspec:
 
     tasks:
       all-rspec:
-        name: All rspec tests
+        name: All rspec tests, using ActiveSupport latest

data/cider-ci/task_components/rspec.yml

@@ -17,13 +17,12 @@ scripts:
       set -eux
       mkdir -p tmp/cache
       export PATH=~/.rubies/$RUBY/bin:$PATH
-      bundle exec rspec
+      if [ ! -z ${ACTIVESUPPORT:-} ]; then BUNDLE_GEMFILE=Gemfile.activesupport$ACTIVESUPPORT bundle exec rspec; else bundle exec rspec; fi
     
     start_when:
       'bundled':
         script_key: bundle
 
-
 trial_attachments:
   logs:
     include_match: log\/.*\.log$

data/lhs.gemspec

@@ -20,9 +20,8 @@ Gem::Specification.new do |s|
   s.requirements << 'Ruby >= 2.0.0'
   s.required_ruby_version = '>= 2.0.0'
 
-  s.add_dependency 'lhc', '>= 3.6.0'
-  s.add_dependency 'lhc-core-interceptors', '>= 2.0.1'
-  s.add_dependency 'activesupport', '> 4'
+  s.add_dependency 'lhc', '>= 5.0.2'
+  s.add_dependency 'activesupport', '> 4.2'
 
   s.add_development_dependency 'rspec-rails', '>= 3.0.0'
   s.add_development_dependency 'rails', '>= 4.0.0'

data/lib/lhs.rb

@@ -1,6 +1,8 @@
 require 'lhc'
+Dir[File.dirname(__FILE__) + '/lhs/concerns/lhs/*.rb'].sort.each { |file| require file }
 
 module LHS
+  include Configuration
   class RequireLhsRecords
     def initialize(app)
       @app = app
@@ -19,7 +21,13 @@ module LHS
   end
 end
 
-Gem.find_files('lhs/**/*.rb').sort.each { |path| require path }
+Gem.find_files('lhs/**/*.rb')
+  .sort
+  .reject do |path|
+    (!defined?(Rails) && File.basename(path).include?('railtie.rb')) # don't require railtie if Rails is not around
+  end.each do |path|
+    require path
+  end
 
 # Preload all the LHS::Records that are defined in app/models
 class Engine < Rails::Engine

data/lib/lhs/concerns/lhs/configuration.rb

@@ -0,0 +1,18 @@
+require 'active_support'
+
+module LHS
+  module Configuration
+    extend ActiveSupport::Concern
+
+    module ClassMethods
+      def config
+        LHS::Config.instance
+      end
+
+      def configure
+        LHS::Config.instance.reset
+        yield config
+      end
+    end
+  end
+end

data/lib/lhs/concerns/record/request.rb

@@ -377,9 +377,23 @@ class LHS::Record
         options[:url] = compute_url!(options[:params]) unless options.key?(:url)
         merge_explicit_params!(options[:params])
         options.delete(:params) if options[:params] && options[:params].empty?
+        inject_request_cycle_cache!(options)
         options
       end
 
+      # Injects options into request, that enable the LHS::Record::RequestCycleCache::Interceptor
+      def inject_request_cycle_cache!(options)
+        return unless LHS.config.request_cycle_cache_enabled
+        interceptors = options[:interceptors] || LHC.config.interceptors
+        if interceptors.include?(LHC::Caching)
+          # Ensure LHS::RequestCycleCache interceptor is prepend
+          interceptors = interceptors.unshift(LHS::Record::RequestCycleCache::Interceptor)
+          options[:interceptors] = interceptors
+        else
+          warn(LHS::Record::REQUEST_CYCLE_CACHE_WARNING)
+        end
+      end
+
       # LHC supports only one error handler, merge all error handlers to one
       # and reraise
       def merge_error_handlers(handlers)

data/lib/lhs/concerns/record/request_cycle_cache/interceptor.rb

@@ -0,0 +1,38 @@
+require 'active_support'
+
+class LHS::Record
+
+  module RequestCycleCache
+    extend ActiveSupport::Concern
+
+    REQUEST_CYCLE_CACHE_WARNING = "[WARNING] Can't enable LHS::RequestCycleCache as LHC::Caching interceptor is not enabled/configured (see https://github.com/local-ch/lhc/blob/master/docs/interceptors/caching.md#caching-interceptor)!".freeze
+
+    class Interceptor < LHC::Interceptor
+
+      VERSION = 1
+      CACHED_METHODS = [:get].freeze
+
+      def before_request(request)
+        request.options = request.options.merge({
+          cache: true,
+          cache_expires_in: 5.minutes,
+          cache_race_condition_ttl: 5.seconds,
+          cache_key: cache_key_for(request),
+          cached_methods: CACHED_METHODS
+        }.merge(request.options))
+      end
+
+      private
+
+      def cache_key_for(request)
+        [
+          "LHS_REQUEST_CYCLE_CACHE(v#{VERSION})",
+          request.method.upcase,
+          [request.url, request.params.presence].compact.join('?'),
+          "REQUEST=#{LHS::Record::RequestCycleCache::RequestCycleThreadRegistry.request_id}",
+          "HEADERS=#{request.headers.hash}"
+        ].join(' ')
+      end
+    end
+  end
+end

data/lib/lhs/concerns/record/request_cycle_cache/request_cycle_thread_registry.rb

@@ -0,0 +1,13 @@
+require 'active_support'
+
+class LHS::Record
+
+  module RequestCycleCache
+    class RequestCycleThreadRegistry
+      # Using ActiveSupports PerThreadRegistry to be able to support Active Support v4.
+      # Will switch to thread_mattr_accessor (which comes with Activesupport) when we dropping support for Active Support v5.
+      extend ActiveSupport::PerThreadRegistry
+      attr_accessor :request_id
+    end
+  end
+end

data/lib/lhs/config.rb

@@ -0,0 +1,11 @@
+require 'singleton'
+
+class LHS::Config
+  include Singleton
+
+  attr_accessor :request_cycle_cache_enabled
+
+  def initialize
+    self.request_cycle_cache_enabled ||= true
+  end
+end

data/lib/lhs/railtie.rb

@@ -0,0 +1,20 @@
+module LHS
+  class Railtie < Rails::Railtie
+    initializer "lhs.hook_into_controller_initialization" do
+      class ActionController::Base
+
+        def initialize
+          prepare_lhs_request_cycle_cache
+          super
+        end
+
+        private
+
+        def prepare_lhs_request_cycle_cache
+          return unless LHS.config.request_cycle_cache_enabled
+          LHS::Record::RequestCycleCache::RequestCycleThreadRegistry.request_id = [Time.now.to_f, request.object_id].join('#')
+        end
+      end
+    end
+  end
+end

data/lib/lhs/record.rb

@@ -16,6 +16,7 @@ class LHS::Record
   include Model
   include Pagination
   include Request
+  include RequestCycleCache
   include Scope
 
   delegate :_proxy, :_endpoint, :merge_raw!, :select, to: :_data

data/lib/lhs/version.rb

@@ -1,3 +1,3 @@
 module LHS
-  VERSION = "10.1.1"
+  VERSION = "11.0.0"
 end

data/spec/autoloading_spec.rb

@@ -6,13 +6,13 @@ describe LHS, type: :request do
         because it's necessary for endpoint-to-record-class-discovery",
     cleanup_before: false do
       all_endpoints = LHS::Record::Endpoints.all
-      expect(all_endpoints[':datastore/v2/users']).to be
-      expect(all_endpoints[':datastore/v2/users/:id']).to be
+      expect(all_endpoints['http://datastore/v2/users']).to be
+      expect(all_endpoints['http://datastore/v2/users/:id']).to be
       expect(
-        User.endpoints.detect { |endpoint| endpoint.url == ':datastore/v2/users' }
+        User.endpoints.detect { |endpoint| endpoint.url == 'http://datastore/v2/users' }
       ).to be
       expect(
-        User.endpoints.detect { |endpoint| endpoint.url == ':datastore/v2/users/:id' }
+        User.endpoints.detect { |endpoint| endpoint.url == 'http://datastore/v2/users/:id' }
       ).to be
     end
   end

data/spec/dummy/app/controllers/request_cycle_cache_controller.rb

@@ -0,0 +1,25 @@
+class RequestCycleCacheController < ApplicationController
+  def simple
+    User.find(1) # first request
+    user = User.find(1) # second request that should be serverd from request cycle cache
+    render json: user.to_json
+  end
+
+  def no_caching_interceptor
+    User.options(interceptors: []).find(1) # first request
+    user = User.options(interceptors: []).find(1) # second request
+    render json: user.to_json
+  end
+
+  def parallel
+    User.find(1, 2) # first request
+    users = User.find(1, 2) # second request that should be serverd from request cycle cache
+    render json: users.to_json
+  end
+
+  def headers
+    User.find(1) # first request
+    user = User.options(headers: { 'Authentication' => 'Bearer 123' }).find(1) # second request that should NOT be serverd from request cycle cache as the headers are different
+    render json: user.to_json
+  end
+end

data/spec/dummy/app/models/user.rb

@@ -1,4 +1,4 @@
 class User < LHS::Record
-  endpoint ':datastore/v2/users'
-  endpoint ':datastore/v2/users/:id'
+  endpoint 'http://datastore/v2/users'
+  endpoint 'http://datastore/v2/users/:id'
 end

data/spec/dummy/config/environments/test.rb

@@ -12,10 +12,6 @@ Rails.application.configure do
   # preloads Rails for running tests, you may have to set it to true.
   config.eager_load = false
 
-  # Configure static asset server for tests with Cache-Control for performance.
-  config.public_file_server.enabled = true
-  config.public_file_server.headers = { 'Cache-Control' => 'public, max-age=3600' }
-
   # Show full error reports and disable caching.
   config.consider_all_requests_local       = true
   config.action_controller.perform_caching = false

data/spec/dummy/config/routes.rb

@@ -1,56 +1,7 @@
 Rails.application.routes.draw do
-  # The priority is based upon order of creation: first created -> highest priority.
-  # See how all your routes lay out with "rake routes".
-
-  # You can have the root of your site routed with "root"
   root 'application#root'
-
-  # Example of regular route:
-  #   get 'products/:id' => 'catalog#view'
-
-  # Example of named route that can be invoked with purchase_url(id: product.id)
-  #   get 'products/:id/purchase' => 'catalog#purchase', as: :purchase
-
-  # Example resource route (maps HTTP verbs to controller actions automatically):
-  #   resources :products
-
-  # Example resource route with options:
-  #   resources :products do
-  #     member do
-  #       get 'short'
-  #       post 'toggle'
-  #     end
-  #
-  #     collection do
-  #       get 'sold'
-  #     end
-  #   end
-
-  # Example resource route with sub-resources:
-  #   resources :products do
-  #     resources :comments, :sales
-  #     resource :seller
-  #   end
-
-  # Example resource route with more complex sub-resources:
-  #   resources :products do
-  #     resources :comments
-  #     resources :sales do
-  #       get 'recent', on: :collection
-  #     end
-  #   end
-
-  # Example resource route with concerns:
-  #   concern :toggleable do
-  #     post 'toggle'
-  #   end
-  #   resources :posts, concerns: :toggleable
-  #   resources :photos, concerns: :toggleable
-
-  # Example resource route within a namespace:
-  #   namespace :admin do
-  #     # Directs /admin/products/* to Admin::ProductsController
-  #     # (app/controllers/admin/products_controller.rb)
-  #     resources :products
-  #   end
+  get 'request_cycle_cache/simple' => 'request_cycle_cache#simple'
+  get 'request_cycle_cache/no_caching_interceptor' => 'request_cycle_cache#no_caching_interceptor'
+  get 'request_cycle_cache/parallel' => 'request_cycle_cache#parallel'
+  get 'request_cycle_cache/headers' => 'request_cycle_cache#headers'
 end

data/spec/record/includes_warning_spec.rb

@@ -37,7 +37,7 @@ describe LHS::Record do
       expect(lambda {
         Customer.includes(:contracts).find(1)
       }).to output(
-        "[WARNING] You included `http://datastore/customers/1/contracts`, but this endpoint is paginated. You might want to use `includes_all` instead of `includes` (https://github.com/local-ch/lhs#includes_all-for-paginated-endpoints).\n"
+        %r{\[WARNING\] You included `http://datastore/customers/1/contracts`, but this endpoint is paginated. You might want to use `includes_all` instead of `includes` \(https://github.com/local-ch/lhs#includes_all-for-paginated-endpoints\)\.}
       ).to_stderr
     end
   end

data/spec/record/request_spec.rb

@@ -13,8 +13,9 @@ describe LHS::Record do
     end
 
     it 'is using params as query params explicitly when provided in params namespace' do
-      stub_request(:get, "#{datastore}/content-ads/123/feedbacks?campaign_id=456").to_return(status: 200)
-      Record.where(campaign_id: 123, params: { campaign_id: '456' })
+      request = stub_request(:get, "#{datastore}/content-ads/123/feedbacks?campaign_id=456").to_return(status: 200)
+      Record.where(campaign_id: 123, params: { campaign_id: '456' }).to_a
+      assert_requested(request)
     end
   end
 end

data/spec/request_cycle_cache/main_spec.rb

@@ -0,0 +1,90 @@
+require 'rails_helper'
+require 'lhc/test/cache_helper.rb'
+
+describe 'Request Cycle Cache', type: :request do
+  let!(:request) do
+    stub_request(:get, "http://datastore/v2/users/1").to_return(body: { name: 'Steve' }.to_json)
+  end
+
+  let!(:second_request) do
+    stub_request(:get, "http://datastore/v2/users/2").to_return(body: { name: 'Peter' }.to_json)
+  end
+
+  before(:each) do
+    class User < LHS::Record
+      endpoint 'http://datastore/v2/users'
+      endpoint 'http://datastore/v2/users/:id'
+    end
+    LHC.configure do |config|
+      config.interceptors = [LHC::Caching]
+    end
+  end
+
+  it 'serves requests that are exactly the same during one request cycle from the cache',
+  cleanup_before: false, request_cycle_cache: true do
+    get '/request_cycle_cache/simple'
+    expect(request).to have_been_made.once
+
+    # Second Request, Second Cycle, requests again
+    get '/request_cycle_cache/simple'
+    expect(request).to have_been_made.times(2)
+  end
+
+  it 'does not serve from request cycle cache when cache interceptor is not hooked in, but logs a warning',
+  cleanup_before: false, request_cycle_cache: true do
+    expect(lambda do
+      get '/request_cycle_cache/no_caching_interceptor'
+    end).to output(
+      %r{\[WARNING\] Can't enable LHS::RequestCycleCache as LHC::Caching interceptor is not enabled/configured \(see https://github.com/local-ch/lhc/blob/master/docs/interceptors/caching.md#caching-interceptor\)!}
+    ).to_stderr
+    expect(request).to have_been_made.times(2)
+  end
+
+  it 'serves requests also from cache when LHS/LHC makes requests in parallel',
+  cleanup_before: false, request_cycle_cache: true do
+    get '/request_cycle_cache/parallel'
+    expect(request).to have_been_made.once
+    expect(second_request).to have_been_made.once
+  end
+
+  it 'sets different uniq request ids as base for request cycle caching for different requests',
+  cleanup_before: false, request_cycle_cache: true do
+    get '/request_cycle_cache/simple'
+    first_request_id = LHS::Record::RequestCycleCache::RequestCycleThreadRegistry.request_id
+    second_request_id = nil
+    thread = Thread.new do
+      get '/request_cycle_cache/simple'
+      second_request_id = LHS::Record::RequestCycleCache::RequestCycleThreadRegistry.request_id
+    end
+    thread.join
+    expect(first_request_id).not_to be_nil
+    expect(second_request_id).not_to be_nil
+    expect(first_request_id).not_to eq second_request_id
+  end
+
+  context 'disabled request cycle cache' do
+    it 'does not serve from request cycle cache when cache interceptor is not hooked in, and does not warn if request cycle cache is explicitly disabled',
+    cleanup_before: false do
+      expect(lambda do
+        get '/request_cycle_cache/no_caching_interceptor'
+      end).not_to output(
+        %r{\[WARNING\] Can't enable LHS::RequestCycleCache as LHC::Caching interceptor is not enabled/configured \(see https://github.com/local-ch/lhc/blob/master/docs/interceptors/caching.md#caching-interceptor\)!}
+      ).to_stderr
+      expect(request).to have_been_made.times(2)
+    end
+
+    it 'DOES NOT serve requests that are exactly the same during one request cycle from the cache, when request cycle cache is disabled',
+    cleanup_before: false do
+      get '/request_cycle_cache/simple'
+      expect(request).to have_been_made.times(2)
+    end
+  end
+
+  context 'headers' do
+    it 'considers the request headers when setting the cache key',
+    cleanup_before: false, request_cycle_cache: true do
+      get '/request_cycle_cache/headers'
+      expect(request).to have_been_made.times(2)
+    end
+  end
+end

data/spec/support/request_cycle_cache.rb

@@ -0,0 +1,7 @@
+RSpec.configure do |config|
+  config.before(:each) do |spec|
+    enabled = spec.metadata.key?(:request_cycle_cache) && spec.metadata[:request_cycle_cache] == true
+    enabled ||= false
+    LHS.config.request_cycle_cache_enabled = enabled
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lhs
 version: !ruby/object:Gem::Version
-  version: 10.1.1
+  version: 11.0.0
 platform: ruby
 authors:
 - https://github.com/local-ch/lhs/graphs/contributors
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-03-29 00:00:00.000000000 Z
+date: 2017-04-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lhc
@@ -16,42 +16,28 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.6.0
+        version: 5.0.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.6.0
-- !ruby/object:Gem::Dependency
-  name: lhc-core-interceptors
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 2.0.1
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 2.0.1
+        version: 5.0.2
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">"
       - !ruby/object:Gem::Version
-        version: '4'
+        version: '4.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">"
       - !ruby/object:Gem::Version
-        version: '4'
+        version: '4.2'
 - !ruby/object:Gem::Dependency
   name: rspec-rails
   requirement: !ruby/object:Gem::Requirement
@@ -177,13 +163,17 @@ files:
 - ".rubocop.yml"
 - ".ruby-version"
 - Gemfile
+- Gemfile.activesupport4
+- Gemfile.activesupport5
 - README.md
 - Rakefile
 - cider-ci.yml
 - cider-ci/bin/bundle
 - cider-ci/bin/ruby_install
 - cider-ci/bin/ruby_version
-- cider-ci/jobs/rspec.yml
+- cider-ci/jobs/rspec-activesupport-4.yml
+- cider-ci/jobs/rspec-activesupport-5.yml
+- cider-ci/jobs/rspec-activesupport-latest.yml
 - cider-ci/jobs/rubocop.yml
 - cider-ci/task_components/bundle.yml
 - cider-ci/task_components/rspec.yml
@@ -202,6 +192,7 @@ files:
 - lib/lhs/concerns/item/save.rb
 - lib/lhs/concerns/item/update.rb
 - lib/lhs/concerns/item/validation.rb
+- lib/lhs/concerns/lhs/configuration.rb
 - lib/lhs/concerns/proxy/accessors.rb
 - lib/lhs/concerns/proxy/create.rb
 - lib/lhs/concerns/proxy/link.rb
@@ -219,7 +210,10 @@ files:
 - lib/lhs/concerns/record/model.rb
 - lib/lhs/concerns/record/pagination.rb
 - lib/lhs/concerns/record/request.rb
+- lib/lhs/concerns/record/request_cycle_cache/interceptor.rb
+- lib/lhs/concerns/record/request_cycle_cache/request_cycle_thread_registry.rb
 - lib/lhs/concerns/record/scope.rb
+- lib/lhs/config.rb
 - lib/lhs/data.rb
 - lib/lhs/endpoint.rb
 - lib/lhs/errors.rb
@@ -229,6 +223,7 @@ files:
 - lib/lhs/pagination/page.rb
 - lib/lhs/pagination/start.rb
 - lib/lhs/proxy.rb
+- lib/lhs/railtie.rb
 - lib/lhs/record.rb
 - lib/lhs/version.rb
 - script/ci/build.sh
@@ -262,6 +257,7 @@ files:
 - spec/dummy/app/assets/stylesheets/application.css
 - spec/dummy/app/controllers/application_controller.rb
 - spec/dummy/app/controllers/concerns/.keep
+- spec/dummy/app/controllers/request_cycle_cache_controller.rb
 - spec/dummy/app/helpers/application_helper.rb
 - spec/dummy/app/mailers/.keep
 - spec/dummy/app/models/.keep
@@ -284,7 +280,6 @@ files:
 - spec/dummy/config/initializers/cookies_serializer.rb
 - spec/dummy/config/initializers/filter_parameter_logging.rb
 - spec/dummy/config/initializers/inflections.rb
-- spec/dummy/config/initializers/lhc.rb
 - spec/dummy/config/initializers/mime_types.rb
 - spec/dummy/config/initializers/session_store.rb
 - spec/dummy/config/initializers/wrap_parameters.rb
@@ -359,12 +354,14 @@ files:
 - spec/record/where_chains_spec.rb
 - spec/record/where_spec.rb
 - spec/record/where_values_hash_spec.rb
+- spec/request_cycle_cache/main_spec.rb
 - spec/spec_helper.rb
 - spec/support/cleanup.rb
 - spec/support/fixtures/json/feedback.json
 - spec/support/fixtures/json/feedbacks.json
 - spec/support/fixtures/json/localina_content_ad.json
 - spec/support/load_json.rb
+- spec/support/request_cycle_cache.rb
 - spec/views/form_for_spec.rb
 homepage: https://github.com/local-ch/lhs
 licenses:
@@ -387,7 +384,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements:
 - Ruby >= 2.0.0
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.6.8
 signing_key: 
 specification_version: 4
 summary: Rails gem providing an easy, active-record-like interface for http json services
@@ -421,6 +418,7 @@ test_files:
 - spec/dummy/app/assets/stylesheets/application.css
 - spec/dummy/app/controllers/application_controller.rb
 - spec/dummy/app/controllers/concerns/.keep
+- spec/dummy/app/controllers/request_cycle_cache_controller.rb
 - spec/dummy/app/helpers/application_helper.rb
 - spec/dummy/app/mailers/.keep
 - spec/dummy/app/models/.keep
@@ -443,7 +441,6 @@ test_files:
 - spec/dummy/config/initializers/cookies_serializer.rb
 - spec/dummy/config/initializers/filter_parameter_logging.rb
 - spec/dummy/config/initializers/inflections.rb
-- spec/dummy/config/initializers/lhc.rb
 - spec/dummy/config/initializers/mime_types.rb
 - spec/dummy/config/initializers/session_store.rb
 - spec/dummy/config/initializers/wrap_parameters.rb
@@ -518,10 +515,12 @@ test_files:
 - spec/record/where_chains_spec.rb
 - spec/record/where_spec.rb
 - spec/record/where_values_hash_spec.rb
+- spec/request_cycle_cache/main_spec.rb
 - spec/spec_helper.rb
 - spec/support/cleanup.rb
 - spec/support/fixtures/json/feedback.json
 - spec/support/fixtures/json/feedbacks.json
 - spec/support/fixtures/json/localina_content_ad.json
 - spec/support/load_json.rb
+- spec/support/request_cycle_cache.rb
 - spec/views/form_for_spec.rb

data/spec/dummy/config/initializers/lhc.rb

@@ -1,3 +0,0 @@
-LHC.configure do |config|
-  config.placeholder(:datastore, 'http://datastore')
-end