lhs 9.1.1 → 10.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 580d8981ba9059cb3e1e5a5d598313e167421279
-  data.tar.gz: 561ba57069262b2c87a825b935b933522daac02f
+  metadata.gz: 728cf6034afb426a4b3fb40dd3a8dcdbffd3d004
+  data.tar.gz: 18872dbdb2fe63ea9b4dc1db69fd370f1499fce3
 SHA512:
-  metadata.gz: 1aaad8a56559f5a27c4fd5b9a82d31732525c8eb11e20d6b5b30b3b3913749caf7bc674bc71fa837c6c7cb9bb032983358f4fe3017e6621b6b8ace5bd04b9b8a
-  data.tar.gz: 2b298c29b539f34559693c83489809919005f7879a63731c217aecd07df222e9fcfa5646949775b9d0f1f8ee8ed3475fac472bf345f3619b55a506b92efbace4
+  metadata.gz: 5d2733b6ee17ed421ab06af04d65c5bfd09f2cdee35f7fbd82bc04ea59152fb9977100b60a6143fa872a90039b589af19b187da48e2d80d5ccf20202278aa8ce
+  data.tar.gz: 11e83155ac46883623f321bf12da0357f709fddf3343feb225f2e1af1fadfb4847668f299f921c2a0900ac506c6c1040191f636269c261c3a76ef04acf49927a

data/README.md

@@ -309,15 +309,7 @@ end
   )
 ```
 
-When creation fails, the object contains errors. It provides them through the `errors` attribute:
-
-```ruby
-  record.errors #<LHS::Errors>
-  record.errors.include?(:ratings) # true
-  record.errors[:ratings] # ['REQUIRED_PROPERTY_VALUE']
-  record.errors.messages # {:ratings=>["REQUIRED_PROPERTY_VALUE"], :recommended=>["REQUIRED_PROPERTY_VALUE"]}
-  record.errors.message # ratings must be set when review or name or review_title is set | The property value is required; it cannot be null, empty, or blank."
-```
+See [Validation](#Validation) for handling validation errors when creating records.
 
 ## Create records through associations (nested resources)
 
@@ -680,6 +672,12 @@ user = User.build(email: 'im not an email address')
 unless user.valid?
   fail(user.errors[:email])
 end
+
+user.errors #<LHS::Errors>
+user.errors.include?(:email) # true
+user.errors[:email] # ['REQUIRED_PROPERTY_VALUE']
+user.errors.messages # {:email=>["REQUIRED_PROPERTY_VALUE"]}
+user.errors.message # email must be set when user is created."
 ```
 
 The parameters passed to the `validates` endpoint option are used to perform the validation:
@@ -691,7 +689,15 @@ The parameters passed to the `validates` endpoint option are used to perform the
   endpoint ':service/v2/users', validates: { path: 'validate' }            # will perform a validation via :service/v2/users/validate
 ```
 
-## Custom validation errors
+### Reset validation errors
+
+Clear the error messages. Compatible with [ActiveRecord](https://github.com/rails/rails/blob/6c8cf21584ced73ade45529d11463c74b5a0c58f/activemodel/lib/active_model/errors.rb#L85).
+
+```ruby
+record.errors.clear
+```
+
+### Custom validation errors
 
 In case you want to add custom validation errors to an instance of LHS::Record:
 

data/lib/lhs/concerns/item/validation.rb

@@ -7,7 +7,7 @@ class LHS::Item < LHS::Proxy
 
     def valid?(options = {})
       options ||= {}
-      self.errors = nil
+      errors.clear
       endpoint = validation_endpoint
       raise 'No endpoint found to perform validations! See here: https://github.com/local-ch/lhs#validation' unless endpoint
       record = LHS::Record.for_url(endpoint.url)

data/lib/lhs/errors.rb

@@ -53,6 +53,11 @@ class LHS::Errors
     values.flatten.size
   end
 
+  def clear
+    @raw = nil
+    @messages.clear
+  end
+
   delegate :values, to: :messages
 
   delegate :keys, to: :messages

data/lib/lhs/version.rb

@@ -1,3 +1,3 @@
 module LHS
-  VERSION = "9.1.1"
+  VERSION = "10.0.0"
 end

data/spec/item/errors_spec.rb

@@ -157,4 +157,20 @@ describe LHS::Item do
       expect(record.errors['body']).to eq ['parse error']
     end
   end
+
+  describe '#clear' do
+    let(:record) { Record.build(name: 'Steve') }
+
+    before(:each) do
+      stub_request(:post, "#{datastore}/feedbacks")
+        .to_return(status: 400, body: error_format_fields.to_json)
+    end
+
+    it 'resets all errors' do
+      record.save
+      expect(record.errors.any?).to eq true
+      record.errors.clear
+      expect(record.errors.any?).to eq false
+    end
+  end
 end

data/spec/item/validation_spec.rb

@@ -93,7 +93,7 @@ describe LHS::Item do
       user.email = 'steve@local.ch'
       successful_validation
       expect(user.valid?).to eq true
-      expect(user.errors).to be_nil
+      expect(user.errors.messages).to be_empty
     end
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lhs
 version: !ruby/object:Gem::Version
-  version: 9.1.1
+  version: 10.0.0
 platform: ruby
 authors:
 - https://github.com/local-ch/lhs/graphs/contributors
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-03-02 00:00:00.000000000 Z
+date: 2017-03-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lhc