lhs 1.4.0 → 1.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c4d9308df49f7152059f1d2c5b243073708b3f5c
-  data.tar.gz: c2cf09d5ff720426922a46f858cbfda21603c899
+  metadata.gz: 971b5b5be07447f22d6836f2b753b2cf1a0ed6fe
+  data.tar.gz: 758c110834c300f5bfaa83c522b0448c387219c0
 SHA512:
-  metadata.gz: 6c6e0edeadc0e459455d358c34fb9f3e66527d8529a868eaca3c630752837eb3f4dd3bc8f205c1b587240039173ea3459d7add01cb374ae7b9662c45f4990105
-  data.tar.gz: fbfeed8fe2eeb6ba43eec211a1653250a016ec7aa51af4ecd0ae723a399205a2700b37220c82dfc29cf3c807d2e2e3b2b4f8e8730bd3639a7182970b5704ef06
+  metadata.gz: 300c01350c020f53b49b775d762a7ad58a242f6a26548b3dedebd5bdde9f66a9e7b5dca28f78a77432aa7e0329be0cb561a45783fb94d0a101a221423768162f
+  data.tar.gz: 35a0b20be75b9f31e528a59be968849ed7588f4502c9b426ec44895aa4c4d674deea14dc2baba0f834a52ffdcabad208d0f96b4e8e07e180324f22005988af06

data/lib/lhs/errors.rb

@@ -2,11 +2,12 @@
 class LHS::Errors
   include Enumerable
 
-  attr_reader :messages, :message
+  attr_reader :messages, :message, :raw
 
   def initialize(response)
     @messages = messages_from_response(response)
     @message = message_from_response(response)
+    @raw = response.body
     rescue JSON::ParserError
   end
 

data/lib/lhs/version.rb

@@ -1,3 +1,3 @@
 module LHS
-  VERSION = "1.4.0"
+  VERSION = "1.5.0"
 end

data/spec/item/{save_errors_spec.rb → errors_spec.rb}

@@ -2,19 +2,9 @@ require 'rails_helper'
 
 describe LHS::Item do
 
-  context 'save failed' do
-
-    let(:datastore) { 'http://local.ch/v2' }
+  let(:datastore) { 'http://local.ch/v2' }
 
-    before(:each) do
-      LHC.config.placeholder(:datastore, datastore)
-      class SomeService < LHS::Service
-        endpoint ':datastore/:campaign_id/feedbacks'
-        endpoint ':datastore/feedbacks'
-      end
-    end
-
-    let(:error_format_fields) do
+  let(:error_format_fields) do
       {
         "status" => 400,
         "message" => "ratings must be set when review or name or review_title is set | The property value is required; it cannot be null, empty, or blank.",
@@ -30,29 +20,39 @@ describe LHS::Item do
       }
     end
 
-    let(:error_format_field_errors) do
-      {
-        "status" => 400,
-        "message" => "Some data in the request body failed validation. Inspect the field errors for details.",
-        "field_errors" => [ {
-          "code" => "UNSUPPORTED_PROPERTY_VALUE",
-          "path" => [ "gender" ],
-          "message" => "The property value is unsupported. Supported values are: FEMALE, MALE"
-        }, {
-          "code" => "INCOMPLETE_PROPERTY_VALUE",
-          "path" => [ "gender" ],
-          "message" => "The property value is incomplete. It misses some data"
-        }, {
-          "code" => "INCOMPLETE_PROPERTY_VALUE",
-          "path" => [ "contract", "entry_id" ],
-          "message" => "The property value is incomplete. It misses some data"
-        }  ]
-      }
-    end 
+  let(:error_format_field_errors) do
+    {
+      "status" => 400,
+      "message" => "Some data in the request body failed validation. Inspect the field errors for details.",
+      "field_errors" => [ {
+        "code" => "UNSUPPORTED_PROPERTY_VALUE",
+        "path" => [ "gender" ],
+        "message" => "The property value is unsupported. Supported values are: FEMALE, MALE"
+      }, {
+        "code" => "INCOMPLETE_PROPERTY_VALUE",
+        "path" => [ "gender" ],
+        "message" => "The property value is incomplete. It misses some data"
+      }, {
+        "code" => "INCOMPLETE_PROPERTY_VALUE",
+        "path" => [ "contract", "entry_id" ],
+        "message" => "The property value is incomplete. It misses some data"
+      }  ]
+    }
+  end 
+
+  before(:each) do
+    LHC.config.placeholder(:datastore, datastore)
+    class SomeService < LHS::Service
+      endpoint ':datastore/:campaign_id/feedbacks'
+      endpoint ':datastore/feedbacks'
+    end
+  end
+
+  context 'save failed' do
 
     it 'parses fields correctly when creation failed' do
       stub_request(:post, "#{datastore}/feedbacks")
-      .to_return(status: 400, body: error_format_fields.to_json)
+        .to_return(status: 400, body: error_format_fields.to_json)
       record = SomeService.build
       record.name = 'Steve'
       result = record.save
@@ -67,7 +67,7 @@ describe LHS::Item do
 
     it 'parses field errors correctly when creation failed' do
       stub_request(:post, "#{datastore}/feedbacks")
-      .to_return(status: 400, body: error_format_field_errors.to_json)
+        .to_return(status: 400, body: error_format_field_errors.to_json)
       record = SomeService.build
       record.name = 'Steve'
       result = record.save
@@ -79,4 +79,19 @@ describe LHS::Item do
       expect(record.errors[:"contract.entry_id"]).to eq ['INCOMPLETE_PROPERTY_VALUE']
     end
   end
+
+  context 'raw error data' do
+
+    it 'provides access to raw error data' do
+      stub_request(:post, "#{datastore}/feedbacks")
+        .to_return(status: 400, body: error_format_field_errors.to_json)
+      record = SomeService.build
+      record.save
+      expect(record.errors.raw).to be
+      json = JSON.parse(record.errors.raw)
+      expect(json['status']).to be
+      expect(json['message']).to be
+      expect(json['field_errors']).to be
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lhs
 version: !ruby/object:Gem::Version
-  version: 1.4.0
+  version: 1.5.0
 platform: ruby
 authors:
 - local.ch
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-11-27 00:00:00.000000000 Z
+date: 2015-12-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lhc
@@ -213,9 +213,9 @@ files:
 - spec/endpoint/for_url_spec.rb
 - spec/item/delegate_spec.rb
 - spec/item/destroy_spec.rb
+- spec/item/errors_spec.rb
 - spec/item/getter_spec.rb
 - spec/item/respond_to_spec.rb
-- spec/item/save_errors_spec.rb
 - spec/item/save_spec.rb
 - spec/item/setter_spec.rb
 - spec/item/update_spec.rb
@@ -325,9 +325,9 @@ test_files:
 - spec/endpoint/for_url_spec.rb
 - spec/item/delegate_spec.rb
 - spec/item/destroy_spec.rb
+- spec/item/errors_spec.rb
 - spec/item/getter_spec.rb
 - spec/item/respond_to_spec.rb
-- spec/item/save_errors_spec.rb
 - spec/item/save_spec.rb
 - spec/item/setter_spec.rb
 - spec/item/update_spec.rb