lhs 1.2.3 → 1.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8d19aca4a6fcb6ae3919253eb5dfc56dd15b9dee
-  data.tar.gz: 923b15da62737dd1dd0b1f1fa9b326eba4401da9
+  metadata.gz: 4d2fe9d241de70e1547f04ecc340becf4758a22e
+  data.tar.gz: 9203ee6326411236cf93485beb289862fd3ec060
 SHA512:
-  metadata.gz: 96cc284a37e9107fbb5eb86ca6baae8fa97cf23cef4db5dea91b78331d5ee145d03d2d27c8da555eb231ecb6b12595630bf9c10884b768f0c6a3a778db4818c2
-  data.tar.gz: e99b4c5f0d0f49b99e852e7439515b361c7d566d2bc8a1991d0f96d7fae3aeacd9c5883e180f57e12ad5ac6f6533c8827b56e11f59817502715a00e5debc4d0d
+  metadata.gz: 6d5169f5bc32a55a05e0ed1ffbe5e236e79f65714a7f7ae177516517c0dbd3d6f06082dfb5393e3188294db94b9fb958fe9bda6459ef1bfc3da77e13a8fc4c2f
+  data.tar.gz: 6d86b6cc756b977d07a991794b91665b82b0e426ff5d0321a1f4dcad0bfdbdfb1ea4bbdce65adf62015675c07d54e1ae25c7736c192da863f9ed7131c4b2e56d

data/lib/lhs/errors.rb

@@ -64,21 +64,34 @@ class LHS::Errors
 
   private
 
-  def messages_from_response(response)
+  def add_error(messages, key, value)
+    messages[key] ||= []
+    messages[key].push(value)
+  end
+
+  def parse_messages(json)
     messages = {}
-    return messages if !response.body.is_a?(String) || response.body.length.zero?
-    json = JSON.parse(response.body)
-    return messages unless json['fields']
-    json['fields'].each do |field|
-      name = field['name'].to_sym
-      messages[name] ||= []
-      field['details'].each do |detail|
-        messages[name].push(detail['code'])
+    if json['fields']
+      json['fields'].each do |field|
+        field['details'].each do |detail|
+          add_error(messages, field['name'].to_sym, detail['code'])
+        end
+      end
+    end
+    if json['field_errors']
+      json['field_errors'].each do |field_error|
+        add_error(messages, field_error['path'].join('.').to_sym, field_error['code'])
       end
     end
     messages
   end
 
+  def messages_from_response(response)
+    return {} if !response.body.is_a?(String) || response.body.length.zero?
+    json = JSON.parse(response.body)
+    parse_messages(json)
+  end
+
   def message_from_response(response)
     json = JSON.parse(response.body)
     json['message']

data/lib/lhs/version.rb

@@ -1,3 +1,3 @@
 module LHS
-  VERSION = "1.2.3"
+  VERSION = "1.3.0"
 end

data/spec/item/save_errors_spec.rb

@@ -14,14 +14,14 @@ describe LHS::Item do
       end
     end
 
-    let(:save_error) do
+    let(:error_format_fields) do
       {
         "status" => 400,
         "message" => "ratings must be set when review or name or review_title is set | The property value is required; it cannot be null, empty, or blank.",
         "fields" => [
           {
             "name" => "ratings",
-            "details" => [{ "code" => "REQUIRED_PROPERTY_VALUE" }]
+            "details" => [{ "code" => "REQUIRED_PROPERTY_VALUE" }, { "code" => "UNSUPPORTED_PROPERTY_VALUE" }]
           },{
             "name" => "recommended",
             "details" => [{"code" => "REQUIRED_PROPERTY_VALUE"}]
@@ -30,9 +30,29 @@ describe LHS::Item do
       }
     end
 
-    it 'provides errors when creation failed' do
+    let(:error_format_field_errors) do
+      {
+        "status" => 400,
+        "message" => "Some data in the request body failed validation. Inspect the field errors for details.",
+        "field_errors" => [ {
+          "code" => "UNSUPPORTED_PROPERTY_VALUE",
+          "path" => [ "gender" ],
+          "message" => "The property value is unsupported. Supported values are: FEMALE, MALE"
+        }, {
+          "code" => "INCOMPLETE_PROPERTY_VALUE",
+          "path" => [ "gender" ],
+          "message" => "The property value is incomplete. It misses some data"
+        }, {
+          "code" => "INCOMPLETE_PROPERTY_VALUE",
+          "path" => [ "contract", "entry_id" ],
+          "message" => "The property value is incomplete. It misses some data"
+        }  ]
+      }
+    end 
+
+    it 'parses fields correctly when creation failed' do
       stub_request(:post, "#{datastore}/feedbacks")
-      .to_return(status: 400, body: save_error.to_json)
+      .to_return(status: 400, body: error_format_fields.to_json)
       record = SomeService.build
       record.name = 'Steve'
       result = record.save
@@ -41,8 +61,22 @@ describe LHS::Item do
       expect(record.name).to eq 'Steve'
       expect(record.errors.include?(:ratings)).to eq true
       expect(record.errors.include?(:recommended)).to eq true
-      expect(record.errors[:ratings]).to eq ['REQUIRED_PROPERTY_VALUE']
+      expect(record.errors[:ratings]).to eq ['REQUIRED_PROPERTY_VALUE', 'UNSUPPORTED_PROPERTY_VALUE']
       expect(record.errors[:recommended]).to eq ['REQUIRED_PROPERTY_VALUE']
     end
+
+    it 'parses field errors correctly when creation failed' do
+      stub_request(:post, "#{datastore}/feedbacks")
+      .to_return(status: 400, body: error_format_field_errors.to_json)
+      record = SomeService.build
+      record.name = 'Steve'
+      result = record.save
+      expect(result).to eq false
+      expect(record.errors).to be
+      expect(record.errors.include?(:gender)).to eq true
+      expect(record.errors.include?(:"contract.entry_id")).to eq true
+      expect(record.errors[:gender]).to eq ['UNSUPPORTED_PROPERTY_VALUE', 'INCOMPLETE_PROPERTY_VALUE']
+      expect(record.errors[:"contract.entry_id"]).to eq ['INCOMPLETE_PROPERTY_VALUE']
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lhs
 version: !ruby/object:Gem::Version
-  version: 1.2.3
+  version: 1.3.0
 platform: ruby
 authors:
 - local.ch
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-10-26 00:00:00.000000000 Z
+date: 2015-11-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lhc