lhs 1.2.1 → 1.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 371888c99881b65fa1571b7ab9d0639b784a66de
-  data.tar.gz: 41bcc0e2446cf6ea11b8469d0bb8c78494bf3708
+  metadata.gz: 79706509847d5e009bdc036cd616b804d88c6dfa
+  data.tar.gz: 2530ee6f7e347584cba1ec46c51ff13291307950
 SHA512:
-  metadata.gz: 8bed4523267443a431e667ab516589d69c49da957cdcccf798e302cbc4775638b039f29eada8e1e8643435be196513005176e36119d4b468fac2b81ce22ee342
-  data.tar.gz: 22f46fdcab0190ec3f890b2f2191120d55eb9c7bf822bfcdf5be180d43561cdb33098a20cd354518364829399ffbb28c91173a77fd26cbd62f3060dc6e9374c9
+  metadata.gz: dbdb3f1be6fb3412a94f08f1bf55661b660ff7d0587a88b2f8704fce74ccdac57aaca9618d9bff8fd3cf8b34aec1b768b4fa25b6caa8ae30cc778b5912147b7b
+  data.tar.gz: 63ef7d714318e13a90507512bd7a8be1e2bc4122931e2acc3bfc262142d9fb0b5ea3d9ebdfa414f2c96788a7635e241754e48deb63049da3e9da4f3a0af3ff1e

data/lib/lhs/collection.rb

@@ -72,6 +72,7 @@ class LHS::Collection < LHS::Proxy
       end
     end
 
+    delegate :last, to: :raw
     delegate :sample, to: :raw
     delegate :[], to: :raw
   end

data/lib/lhs/concerns/service/all.rb

@@ -19,10 +19,12 @@ class LHS::Service
         all.concat(data._raw['items'])
         total_left = data._raw['total'] - data.count
         limit = data._raw['limit'] || data.count
-        requests = total_left / limit
-        requests.times do |i|
-          offset = limit * (i+1) + 1
-          all.concat instance.request(params: params.merge(limit: limit, offset: offset))._raw['items']
+        if limit > 0
+          requests = total_left / limit
+          requests.times do |i|
+            offset = limit * (i+1) + 1
+            all.concat instance.request(params: params.merge(limit: limit, offset: offset))._raw['items']
+          end
         end
         LHS::Data.new(all, nil, self)
       end

data/lib/lhs/version.rb

@@ -1,3 +1,3 @@
 module LHS
-  VERSION = "1.2.1"
+  VERSION = "1.2.2"
 end

data/spec/service/all_spec.rb

@@ -25,7 +25,7 @@ describe LHS::Collection do
       expect(all).to be_kind_of LHS::Data
       expect(all._proxy).to be_kind_of LHS::Collection
       expect(all.count).to eq 300
-      expect(all[299]).to eq 300
+      expect(all.last).to eq 300
     end
 
     it 'also fetches all when there is not meta information for limit' do
@@ -39,7 +39,16 @@ describe LHS::Collection do
       expect(all).to be_kind_of LHS::Data
       expect(all._proxy).to be_kind_of LHS::Collection
       expect(all.count).to eq 300
-      expect(all[299]).to eq 300
+      expect(all.last).to eq 300
+    end
+
+    it 'also works when there is no item in the first response' do
+      stub_request(:get, "#{datastore}/feedbacks?limit=100")
+        .to_return(status: 200, body: {items: [], total: 300, offset: 0}.to_json)
+      all = SomeService.all
+      expect(all).to be_kind_of LHS::Data
+      expect(all._proxy).to be_kind_of LHS::Collection
+      expect(all.count).to eq 0
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lhs
 version: !ruby/object:Gem::Version
-  version: 1.2.1
+  version: 1.2.2
 platform: ruby
 authors:
 - local.ch
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-10-09 00:00:00.000000000 Z
+date: 2015-10-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lhc