lhm 1.0.2 → 1.0.3

data/CHANGELOG.md

@@ -1,19 +1,23 @@
-# 1.0.2 (Febuary 17, 2012)
+# 1.0.3 (February 23, 2012)
+
+* Improve change_column
+
+# 1.0.2 (February 17, 2012)
 
 * closes https://github.com/soundcloud/large-hadron-migrator/issues/11
   this critical bug could cause data loss. table parser was replaced with
   an implementation that reads directly from information_schema.
 
-# 1.0.1 (Febuary 09, 2012)
+# 1.0.1 (February 09, 2012)
 
 * released to rubygems
 
-# 1.0.0 (Febuary 09, 2012)
+# 1.0.0 (February 09, 2012)
 
 * added change_column
 * final 1.0 release
 
-# 1.0.0.rc8 (Febuary 09, 2012)
+# 1.0.0.rc8 (February 09, 2012)
 
 * removed spec binaries from gem bins
 

data/lib/lhm/migrator.rb

@@ -66,8 +66,7 @@ module Lhm
     # @param [String] name Name of the column to change
     # @param [String] definition Valid SQL column definition
     def change_column(name, definition)
-      remove_column(name)
-      add_column(name, definition)
+      ddl("alter table `%s` modify column `%s` %s" % [@name, name, definition])
     end
 
     # Remove a column from a table

data/lib/lhm/version.rb

@@ -2,5 +2,5 @@
 # Schmidt
 
 module Lhm
-  VERSION = "1.0.2"
+  VERSION = "1.0.3"
 end

data/spec/fixtures/small_table.ddl

@@ -0,0 +1,4 @@
+CREATE TABLE `small_table` (
+  `id` INT(11),
+  PRIMARY KEY (`id`)
+) ENGINE=InnoDB DEFAULT CHARSET=utf8

data/spec/integration/lhm_spec.rb

@@ -119,6 +119,22 @@ describe Lhm do
       end
     end
 
+    it "should change the last column in a table" do
+      table_create(:small_table)
+
+      Lhm.change_table(:small_table) do |t|
+        t.change_column(:id, "int(5)")
+      end
+
+      slave do
+        table_read(:small_table).columns["id"].must_equal({
+          :type => "int(5)",
+          :is_nullable => "NO",
+          :column_default => "0"
+        })
+      end
+    end
+
     describe "parallel" do
       it "should perserve inserts during migration" do
         50.times { |n| execute("insert into users set reference = '#{ n }'") }

data/spec/unit/migrator_spec.rb

@@ -66,11 +66,10 @@ describe Lhm::Migrator do
     end
 
     it "should change a column" do
-      @creator.change_column("logins", "INT(255)")
+      @creator.change_column("logins", "INT(11)")
 
       @creator.statements.must_equal([
-        "alter table `lhmn_alt` drop `logins`",
-        "alter table `lhmn_alt` add column `logins` INT(255)"
+        "alter table `lhmn_alt` modify column `logins` INT(11)"
       ])
     end
   end

metadata

@@ -2,7 +2,7 @@
 name: lhm
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 1.0.2
+  version: 1.0.3
 platform: ruby
 authors: 
 - SoundCloud
@@ -13,7 +13,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2012-02-17 00:00:00 Z
+date: 2012-02-22 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: mysql
@@ -98,6 +98,7 @@ files:
 - spec/bootstrap.rb
 - spec/fixtures/destination.ddl
 - spec/fixtures/origin.ddl
+- spec/fixtures/small_table.ddl
 - spec/fixtures/users.ddl
 - spec/integration/chunker_spec.rb
 - spec/integration/entangler_spec.rb
@@ -146,6 +147,7 @@ test_files:
 - spec/bootstrap.rb
 - spec/fixtures/destination.ddl
 - spec/fixtures/origin.ddl
+- spec/fixtures/small_table.ddl
 - spec/fixtures/users.ddl
 - spec/integration/chunker_spec.rb
 - spec/integration/entangler_spec.rb