lhm-shopify 3.5.2 → 3.5.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1ad526041b49fe42d906fc27a697c3d0982332a7f256f40c179071e954a33d37
-  data.tar.gz: 35647043caa59111fd09770a38f160e959baa2022d73d82e1061777423fdc6bb
+  metadata.gz: ef039ab1af9028a875f5851d7b7bd21dc74f363906037cbbe3acc869b008221e
+  data.tar.gz: 03a9d41b63437471f2edaf2faacd1f4d543440aebc64ebe53e2445986b52eb2c
 SHA512:
-  metadata.gz: efce8e7d38b5f5e9769675e423e73d784837b8493d70f11e349041e9356a28078216784b670e246f4adffe8bd594a885ef86148a8da01c0356392219f8e94a40
-  data.tar.gz: 4bb36dd1c70a509dcbf3802c2ed2a9ad788253fdb7414e0c7bb3838fe8f68156a2782a3377f3ec1da472e50a463e6d6577330119f41b726c94499f8a7d2a40bf
+  metadata.gz: 768f2438270cd0f1cfe2d3e624068cb8c45bf083615cdd936e4598db8a5c831c112983f41918ba0e82ce4ee9ecdd3728e53926251512a18b43c94f04afb14a8a
+  data.tar.gz: 94e677823ae472e1db287f250481cf63e8ac0a2f8d85018efb2b07b6ca197d2e4c0f8f5ea7a539d222fbd7928187e61957cd26a95dfc0ad2f39f5e8e27d45a88

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    lhm-shopify (3.5.2)
+    lhm-shopify (3.5.3)
       retriable (>= 3.0.0)
 
 GEM

data/README.md

@@ -301,6 +301,15 @@ COV=1 bundle exec rake unit && bundle exec rake integration
 open coverage/index.html
 ```
 
+### Merging for a new version
+When creating a PR for a new version, make sure that th version has been bumped in `lib/lhm/version.rb`. Then run the following code snippet to ensure the everything is consistent, otherwise 
+the gem will not publish.
+```bash
+bundle install
+bundle update
+bundle exec appraisals install
+```
+
 ### Docker Compose
 The integration tests rely on a replication configuration for MySQL which is being proxied by an instance of ProxySQL.
 It is important that every container is running to execute the integration test suite.

data/gemfiles/activerecord_5.2.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ..
   specs:
-    lhm-shopify (3.5.2)
+    lhm-shopify (3.5.3)
       retriable (>= 3.0.0)
 
 GEM

data/gemfiles/activerecord_6.0.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ..
   specs:
-    lhm-shopify (3.5.2)
+    lhm-shopify (3.5.3)
       retriable (>= 3.0.0)
 
 GEM

data/gemfiles/activerecord_6.1.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ..
   specs:
-    lhm-shopify (3.5.2)
+    lhm-shopify (3.5.3)
       retriable (>= 3.0.0)
 
 GEM

data/gemfiles/activerecord_7.0.0.alpha2.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ..
   specs:
-    lhm-shopify (3.5.2)
+    lhm-shopify (3.5.3)
       retriable (>= 3.0.0)
 
 GEM

data/lib/lhm/proxysql_helper.rb

@@ -4,7 +4,7 @@ module Lhm
     ANNOTATION = "/*maintenance:lhm*/"
 
     def tagged(sql)
-      "#{ANNOTATION}#{sql}"
+      "#{sql} #{ANNOTATION}"
     end
   end
 end

data/lib/lhm/version.rb

@@ -2,5 +2,5 @@
 # Schmidt
 
 module Lhm
-  VERSION = '3.5.2'
+  VERSION = '3.5.3'
 end

data/spec/integration/proxysql_spec.rb

@@ -29,6 +29,6 @@ describe "ProxySQL integration" do
       port: "33005",
       )
 
-    assert_equal conn.query("/*maintenance:lhm*/SELECT @@global.hostname as host").each.first["host"], "mysql-1"
+    assert_equal conn.query("SELECT @@global.hostname as host #{Lhm::ProxySQLHelper::ANNOTATION}").each.first["host"], "mysql-1"
   end
 end

data/spec/unit/connection_spec.rb

@@ -73,7 +73,7 @@ describe Lhm::Connection do
 
   it "Queries should be tagged with ProxySQL tag if requested" do
     ar_connection = mock()
-    ar_connection.expects(:public_send).with(:select_value, "#{Lhm::ProxySQLHelper::ANNOTATION}SHOW TABLES").returns("dummy")
+    ar_connection.expects(:public_send).with(:select_value, "SHOW TABLES #{Lhm::ProxySQLHelper::ANNOTATION}").returns("dummy")
     ar_connection.stubs(:execute).times(4).returns([["dummy"]])
     ar_connection.stubs(:active?).returns(true)
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lhm-shopify
 version: !ruby/object:Gem::Version
-  version: 3.5.2
+  version: 3.5.3
 platform: ruby
 authors:
 - SoundCloud
@@ -12,7 +12,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-12-07 00:00:00.000000000 Z
+date: 2021-12-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: retriable