lhc 9.4.2 → 9.4.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: be1b987dd272ded2704dca72606d5a96ee394ec8e901cb5c72c164bfa4c116fe
-  data.tar.gz: 881da124498450bdd8e9b6d4c4ba8244f84f8dbe3918381af320be267069152e
+  metadata.gz: a020f77f047005cae5e2783018a8e845a619ae594d7c2567e2eb20cb6d71f965
+  data.tar.gz: 105f2df6c51e19750bf4c180382be1c4f2fe9865c7a82ff5708ead4362212858
 SHA512:
-  metadata.gz: 56a29c2ee5e170542d8ddba9bc4e212b4c29bd1a98b2d88b3484b31caadc8bfc034179d653fa289ff9de3864345ce399e65628f210be92d0f8a2f9bef772b991
-  data.tar.gz: 5b0cf0dc644a3f139b64ef50459be033ce9b0cd317782245ebbfc72ec0de57a4714596437819d197e282db85d4ccdb76fe8f0f23d1ead1098479207719649868
+  metadata.gz: f288a674f51be5c50be0b013b637af67c81138453af9f5d043b075898ce76ce2d4b1275a77e180bb53849eacc1c96b990f1c9ca8eb6e77c19ee79a35c15e3fe4
+  data.tar.gz: 2f9a0c9e3a7563759d069d861fc96337e27733c653c066a512f3d28e7a263decab10c707f20ba850230402a22e83412ccdfb447f0741985d02b0f8a1359127a5

data/README.md

@@ -400,7 +400,7 @@ Take care that you only use `LHC.configure` once, because it is actually resetin
 ```ruby
 
   LHC.configure do |c|
-    c.placeholder :datastore, 'http://datastore/v2'
+    c.placeholder :datastore, 'http://datastore'
     c.endpoint :feedbacks, '{+datastore}/feedbacks', params: { has_reviews: true }
     c.interceptors = [CachingInterceptor, MonitorInterceptor, TrackingIdInterceptor]
   end
@@ -433,7 +433,7 @@ You can configure global placeholders, that are used when generating urls from u
 
 ```ruby
   LHC.configure do |c|
-    c.placeholder(:datastore, 'http://datastore/v2')
+    c.placeholder(:datastore, 'http://datastore')
     c.endpoint(:feedbacks, '{+datastore}/feedbacks', { params: { has_reviews: true } })
   end
   

data/lib/lhc/formats/json.rb

@@ -19,7 +19,11 @@ module LHC::Formats
     end
 
     def to_body(input)
-      input.to_json
+      if input.is_a?(String)
+        input
+      else
+        input.to_json
+      end
     end
 
     def to_s

data/lib/lhc/request.rb

@@ -109,7 +109,7 @@ class LHC::Request
   def generate_url_from_template!
     endpoint = LHC::Endpoint.new(options[:url])
     params =
-      if format && options[:body]&.length
+      if format && options[:body]&.length && options[:body].is_a?(Hash)
         options[:body].merge(options[:params] || {}).deep_symbolize_keys
       else
         options[:params]

data/lib/lhc/version.rb

@@ -1,3 +1,3 @@
 module LHC
-  VERSION ||= '9.4.2'
+  VERSION ||= '9.4.3'
 end

data/spec/request/body_spec.rb

@@ -0,0 +1,37 @@
+require 'rails_helper'
+
+describe LHC::Request do
+  context 'encode body' do
+    let(:encoded_data) { data.to_json }
+
+    before do
+      stub_request(:post, "http://datastore/q")
+        .with(body: encoded_data)
+        .to_return(status: 200)
+    end
+
+    context 'hash' do
+      let(:data) { { name: 'Steve' } }
+
+      it 'encodes the request body to the given format' do
+        LHC.post('http://datastore/q', body: data)
+      end
+
+      it 'does not encode the request body if it is already a string' do
+        LHC.post('http://datastore/q', body: encoded_data)
+      end
+    end
+
+    context 'array' do
+      let(:data) { [{ name: 'Steve' }] }
+
+      it 'encodes the request body to the given format' do
+        LHC.post('http://datastore/q', body: data)
+      end
+
+      it 'does not encode the request body if it is already a string' do
+        LHC.post('http://datastore/q', body: encoded_data)
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lhc
 version: !ruby/object:Gem::Version
-  version: 9.4.2
+  version: 9.4.3
 platform: ruby
 authors:
 - https://github.com/local-ch/lhc/contributors
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-08-20 00:00:00.000000000 Z
+date: 2018-10-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -314,6 +314,7 @@ files:
 - spec/interceptors/rollbar/main_spec.rb
 - spec/interceptors/zipkin/distributed_tracing_spec.rb
 - spec/rails_helper.rb
+- spec/request/body_spec.rb
 - spec/request/encoding_spec.rb
 - spec/request/error_handling_spec.rb
 - spec/request/headers_spec.rb
@@ -362,7 +363,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements:
 - Ruby >= 2.0.0
 rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 2.7.7
 signing_key: 
 specification_version: 4
 summary: Advanced HTTP Client for Ruby, fueled with interceptors
@@ -454,6 +455,7 @@ test_files:
 - spec/interceptors/rollbar/main_spec.rb
 - spec/interceptors/zipkin/distributed_tracing_spec.rb
 - spec/rails_helper.rb
+- spec/request/body_spec.rb
 - spec/request/encoding_spec.rb
 - spec/request/error_handling_spec.rb
 - spec/request/headers_spec.rb