lhc 7.2.0 → 7.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7dd0e9ffa97a410938b008214a1169dd92baad1a
-  data.tar.gz: 0c3e70e1aed73f71ab15cc8956f268c95ee4961e
+  metadata.gz: c3be90fe7f5118c0d39672fc3bd3d8977c5c29ef
+  data.tar.gz: 1ebb19663db886f14fcae7e8ce5cf9c3fa895d85
 SHA512:
-  metadata.gz: b7ef93685b6321f92e3d211a15503b34f67acbaa6395ccf866f13b0ad1f03f14b42008a70e350950c124738ecd94e553f9aa0149026cac84b760287a18651be5
-  data.tar.gz: e348b6290e471eaec282c9cb883d129284029ea8644b4899fb5288f40c4c96ce24d03fb4c97ba30c1ded064df56945b2b77e96b212c2e24727b29ff606e395c4
+  metadata.gz: c7b6d90013ea2ff3eb3bcd23af36ee3a47d8b6e36ce8079a38dd9c8f86f1d777a8b293399a82fbb65383847b2b8c66b61d0eb71b5eb83590c48e8bc300231a27
+  data.tar.gz: 65d6c5d0a893662d7553f0589dfd5121c44d124eedddccc93ddc857618c3888b371af52801db4b31184bd61e6b5ce791d1c43c88dde14eccdd2da52a64f48261

data/README.md

@@ -112,6 +112,22 @@ DON'T
 LHC.get('http://local.ch?q=Restaurant')
 ```
 
+### Array Parameter Encoding
+
+LHC can encode array parameters in URLs in two ways. The default is `:rack` which generates URL parameters compatible with Rack and Rails.
+
+```ruby
+LHC.get('http://local.ch', params: { q: [1, 2] })
+# http://local.ch?q[]=1&q[]=2
+```
+
+Some Java-based apps expect their arrays in the `:multi` format:
+
+```ruby
+LHC.get('http://local.ch', params: { q: [1, 2] }, params_encoding: :multi)
+# http://local.ch?q=1&q=2
+```
+
 ## Encoding
 
 LHC, by default, encodes urls:

data/lhc.gemspec

@@ -20,7 +20,7 @@ Gem::Specification.new do |s|
   s.requirements << 'Ruby >= 2.0.0'
   s.required_ruby_version = '>= 2.0.0'
 
-  s.add_dependency 'typhoeus'
+  s.add_dependency 'typhoeus', '>= 0.11'
   s.add_dependency 'activesupport', '>= 4.2'
   s.add_dependency 'addressable'
 

data/lib/lhc/request.rb

@@ -6,7 +6,7 @@ require 'active_support/core_ext/object/deep_dup'
 # and it communicates with interceptors.
 class LHC::Request
 
-  TYPHOEUS_OPTIONS ||= [:params, :method, :body, :headers, :follow_location]
+  TYPHOEUS_OPTIONS ||= [:params, :method, :body, :headers, :follow_location, :params_encoding]
 
   attr_accessor :response, :options, :raw, :format, :error_handler, :errors_ignored
 

data/lib/lhc/version.rb

@@ -1,3 +1,3 @@
 module LHC
-  VERSION ||= '7.2.0'
+  VERSION ||= '7.3.0'
 end

data/spec/request/params_encoding_spec.rb

@@ -0,0 +1,24 @@
+require 'rails_helper'
+
+describe LHC::Request do
+  context 'without an encoding setting' do
+    it 'encodes array params in default rack format' do
+      stub_request(:get, 'http://datastore/q?a%5B%5D=1&a%5B%5D=2&a%5B%5D=3')
+      LHC.get('http://datastore/q', params: { a: [1, 2, 3] })
+    end
+  end
+
+  context 'with encoding set to :rack' do
+    it 'encodes array params in rack format' do
+      stub_request(:get, 'http://datastore/q?a%5B%5D=1&a%5B%5D=2&a%5B%5D=3')
+      LHC.get('http://datastore/q', params: { a: [1, 2, 3] }, params_encoding: :rack)
+    end
+  end
+
+  context 'with encoding set to :multi' do
+    it 'encodes array params in multi format' do
+      stub_request(:get, 'http://datastore/q?a=1&a=2&a=3')
+      LHC.get('http://datastore/q', params: { a: [1, 2, 3] }, params_encoding: :multi)
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lhc
 version: !ruby/object:Gem::Version
-  version: 7.2.0
+  version: 7.3.0
 platform: ruby
 authors:
 - https://github.com/local-ch/lhc/contributors
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.11'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.11'
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
@@ -322,6 +322,7 @@ files:
 - spec/request/ignore_errors_spec.rb
 - spec/request/option_dup_spec.rb
 - spec/request/parallel_requests_spec.rb
+- spec/request/params_encoding_spec.rb
 - spec/request/request_without_rails_spec.rb
 - spec/request/url_patterns_spec.rb
 - spec/response/body_spec.rb
@@ -454,6 +455,7 @@ test_files:
 - spec/request/ignore_errors_spec.rb
 - spec/request/option_dup_spec.rb
 - spec/request/parallel_requests_spec.rb
+- spec/request/params_encoding_spec.rb
 - spec/request/request_without_rails_spec.rb
 - spec/request/url_patterns_spec.rb
 - spec/response/body_spec.rb