lhc 6.3.0 → 6.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 503f2e88095de04d6f071fd2285459f106ff2f7d
-  data.tar.gz: 1e7c8bd5c1878d11ce293208c43f7886714891bf
+  metadata.gz: df32b734a941e2e400a2f41960b512146e90d5f4
+  data.tar.gz: cb8da5bda727e9559996c51d470efc5c3dcfb5b0
 SHA512:
-  metadata.gz: 0e8fbabecb039bfe29377cdd7ee30f52aea980d459918953f5df9b1e92b48c9e15ce15392122dc1dabb9934ca3fc8ac5fb44d2c6f64a1545996bebe24ca6d12e
-  data.tar.gz: a21700e4b7979715066c2659bc492fee013dee54a0471427f6c6dac414c3ff94855bb1b289f3c6900d36714e7200b105e52ec1f46067aeb16909d6a837458d05
+  metadata.gz: 852ce45fb78bfe61eac47f742fd64ba660297bb2d7b32e1d534dd7b23ea949a11b919e99d1b60d153878c01914f5079ea10b802cda504d1aa2d5407957cb38eb
+  data.tar.gz: eecf72175a37b139a8a4b74682196384898427d18a469a043341701b49cc70f4844c2746dae1493b1913e562036dfd20be2cb6fb578d95145395fe3733a88cf0

data/lib/lhc/request.rb

@@ -102,11 +102,17 @@ class LHC::Request
   end
 
   def handle_error(response)
-    return if errors_ignored.include?(error)
+    return if ignore_error?
     throw_error(response) unless error_handler
     response.body_replacement = error_handler.call(response)
   end
 
+  def ignore_error?
+    errors_ignored.detect do |ignored_error|
+      error <= ignored_error
+    end.present?
+  end
+
   def error
     @error ||= LHC::Error.find(response)
   end

data/lib/lhc/version.rb

@@ -1,3 +1,3 @@
 module LHC
-  VERSION ||= "6.3.0"
+  VERSION ||= "6.3.1"
 end

data/spec/request/ignore_errors_spec.rb

@@ -1,13 +1,41 @@
 require 'rails_helper'
 
 describe LHC::Request do
-  context 'ignore errors' do
-    it 'raises errors for anything but 2XX response codes' do
-      stub_request(:get, 'http://local.ch').to_return(status: 404)
-      response = LHC.get('http://local.ch', ignored_errors: [LHC::NotFound])
-      expect(response.body).to eq nil
-      expect(response.data).to eq nil
-      expect(response.success?).to eq false
+  context 'ignoring LHC::NotFound' do
+    subject { LHC.get('http://local.ch', ignored_errors: [LHC::NotFound]) }
+    before { stub_request(:get, 'http://local.ch').to_return(status: 404) }
+
+    it 'does not raise an error' do
+      expect { subject }.not_to raise_error
+    end
+
+    it 'body is nil' do
+      expect(subject.body).to eq nil
+    end
+
+    it 'data is nil' do
+      expect(subject.data).to eq nil
+    end
+
+    it 'does raise an error for 500' do
+      stub_request(:get, 'http://local.ch').to_return(status: 500)
+      expect { subject }.to raise_error LHC::InternalServerError
+    end
+  end
+
+  context 'inheritance when ignoring errors' do
+    before { stub_request(:get, 'http://local.ch').to_return(status: 404) }
+
+    it "does not raise an error when it's a subclass of the ignored error" do
+      expect {
+        LHC.get('http://local.ch', ignored_errors: [LHC::Error])
+      }.not_to raise_error
+    end
+
+    it "does raise an error if it's not a subclass of the ignored error" do
+      expect {
+        LHC.get('http://local.ch', ignored_errors: [ArgumentError])
+      }.to raise_error(LHC::NotFound)
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lhc
 version: !ruby/object:Gem::Version
-  version: 6.3.0
+  version: 6.3.1
 platform: ruby
 authors:
 - https://github.com/local-ch/lhc/contributors
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-08-15 00:00:00.000000000 Z
+date: 2017-08-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: typhoeus
@@ -321,7 +321,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements:
 - Ruby >= 2.0.0
 rubyforge_project: 
-rubygems_version: 2.6.12
+rubygems_version: 2.6.8
 signing_key: 
 specification_version: 4
 summary: LocalHttpClient