lhc 5.0.3 → 5.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b254c12c9236f595f73e159d35b7f13c9e501e3c
-  data.tar.gz: e8ccff4d8334e8e4b87bee5171f2c27ea44a8508
+  metadata.gz: 0a6996ab7562372bd3b44f71dd6fc84485804698
+  data.tar.gz: 1ca24023acb23ac975f44efdabf6ab44428a2b95
 SHA512:
-  metadata.gz: f7e34e0029c58dc0f766a949f21bb771cecc0cd92a5ae8a91e429342c45c7c03df42e3d3df2a164ff08a76321d679c865d25ed12f7eb203093539b7720d36364
-  data.tar.gz: b17640979f7bb7257b94bfc4dfe1b7f5e1f64356772f069d192420ed097c59c5e0b9d0e3bed54fc425dd66f587b8ebda134738f1b9bd94eeee5e46cad79f6945
+  metadata.gz: e75e7a6f8e4892f28f599e0906a92db5b87570804baec6f32aa7726faeecd371391ad21bda686a0b7814f15b279672ebdc4589cf735aa2b4e5372a109f7286bb
+  data.tar.gz: ec0046316b97ef9eb902bde1d2ec3c6dbe872ea9ff821801168bdbde71d4ba2f3559fdf7d349844276f1cf4166637e1341066927f35c0644e70343c7d8f17527

data/lib/lhc/error.rb

@@ -58,7 +58,8 @@ class LHC::Error < StandardError
     debug << [request.method, request.url].map { |str| fix_invalid_encoding(str) }.join(' ')
     debug << "Options: #{request.options}"
     debug << "Headers: #{request.headers}"
-    debug << "Response Code: #{response.code}"
+    debug << "Response Code: #{response.code} (#{response.options[:return_code]})"
+    debug << "Repsonse Options: #{response.options}"
     debug << response.body
     debug << _message
     debug.map { |str| fix_invalid_encoding(str) }.join("\n")

data/lib/lhc/response.rb

@@ -6,6 +6,8 @@ class LHC::Response
 
   attr_accessor :request, :body_replacement
 
+  delegate :effective_url, :code, :headers, :options, :mock, :success?, to: :raw
+
   # A response is initalized with the underlying raw response (typhoeus in our case)
   # and the associated request.
   def initialize(raw, request)
@@ -21,30 +23,10 @@ class LHC::Response
     data[key]
   end
 
-  def effective_url
-    raw.effective_url
-  end
-
   def body
     body_replacement || raw.body
   end
 
-  def code
-    raw.code
-  end
-
-  def headers
-    raw.headers
-  end
-
-  def options
-    raw.options
-  end
-
-  def mock
-    raw.mock
-  end
-
   # Provides response time in ms.
   def time
     (raw.time || 0) * 1000
@@ -54,10 +36,6 @@ class LHC::Response
     raw.timed_out?
   end
 
-  def success?
-    raw.success?
-  end
-
   def format
     return JsonFormat.new if request.nil?
     request.format

data/lib/lhc/version.rb

@@ -1,3 +1,3 @@
 module LHC
-  VERSION ||= "5.0.3"
+  VERSION ||= "5.1.0"
 end

data/spec/error/find_spec.rb

@@ -1,12 +1,13 @@
 require 'rails_helper'
 
 describe LHC::Error do
-  def response(code)
-    LHC::Response.new(OpenStruct.new(code: code), nil)
+  def response(code, timedout = false)
+    LHC::Response.new(OpenStruct.new(code: code, 'timed_out?' => timedout), nil)
   end
 
   context 'find' do
     it 'finds error class by status code' do
+      expect(LHC::Error.find(response('0', true))).to eq LHC::Timeout
       expect(LHC::Error.find(response('400'))).to eq LHC::BadRequest
       expect(LHC::Error.find(response('401'))).to eq LHC::Unauthorized
       expect(LHC::Error.find(response('402'))).to eq LHC::PaymentRequired

data/spec/error/to_s_spec.rb

@@ -40,5 +40,39 @@ describe LHC::Error do
     end
     # the other cases cannot be tested (for example what happens if the headers contain invalid data)
     # because the mocking framework triggers the encoding error already
+
+    context 'some mocked response' do
+      let(:request) do
+        double('request',
+               method: 'GET',
+               url: 'http://example.com/sessions',
+               headers: { 'Bearer Token' => "aaaaaaaa-bbbb-cccc-dddd-eeee"},
+               options: { followlocation: true,
+                          auth: { bearer: "aaaaaaaa-bbbb-cccc-dddd-eeee"},
+                          params: { limit: 20}, url: "http://example.com/sessions" })
+      end
+
+      let(:response) do
+        double('response',
+               request: request,
+               code: 500,
+               options: { return_code: :internal_error, response_headers: "" },
+               body: '{"status":500,"message":"undefined"}')
+      end
+
+      subject { LHC::Error.new('The error message', response) }
+
+      it 'produces correct debug output' do
+        expect(subject.to_s.split("\n")).to eq(<<-MSG.strip_heredoc.split("\n"))
+          GET http://example.com/sessions
+          Options: {:followlocation=>true, :auth=>{:bearer=>"aaaaaaaa-bbbb-cccc-dddd-eeee"}, :params=>{:limit=>20}, :url=>"http://example.com/sessions"}
+          Headers: {"Bearer Token"=>"aaaaaaaa-bbbb-cccc-dddd-eeee"}
+          Response Code: 500 (internal_error)
+          Repsonse Options: {:return_code=>:internal_error, :response_headers=>""}
+          {"status":500,"message":"undefined"}
+          The error message
+        MSG
+      end
+    end
   end
 end

data/spec/request/error_handling_spec.rb

@@ -14,6 +14,7 @@ describe LHC::Request do
     end
 
     it 'raises errors for anything but 2XX response codes' do
+      expect_status_code(0)   { to_fail_with(LHC::UnknownError) }
       expect_status_code(400) { to_fail_with(LHC::BadRequest) }
       expect_status_code(401) { to_fail_with(LHC::Unauthorized) }
       expect_status_code(402) { to_fail_with(LHC::PaymentRequired) }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lhc
 version: !ruby/object:Gem::Version
-  version: 5.0.3
+  version: 5.1.0
 platform: ruby
 authors:
 - https://github.com/local-ch/lhc/contributors
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-05-15 00:00:00.000000000 Z
+date: 2017-06-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: typhoeus
@@ -317,7 +317,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements:
 - Ruby >= 2.0.0
 rubyforge_project: 
-rubygems_version: 2.6.10
+rubygems_version: 2.5.2
 signing_key: 
 specification_version: 4
 summary: LocalHttpClient