lhc 1.2.0 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 433be6f02c1ccf13d4371eb4ce4f494459f95bda
-  data.tar.gz: 1d1f479f03152e50798da81183673c6adc0b15d8
+  metadata.gz: 82137985f03859481eb4bc258f9364d2b1dcde53
+  data.tar.gz: 6b3508329130153d2a84fbb09012c9c2caf3ff45
 SHA512:
-  metadata.gz: 334d1f083f02164608ea72a104c2b749510525eb405346b11923f7ca154250d8e9fba5f69b9bad8d2f184839c60a892bf071317d56696c4666d292ff96ccc3e4
-  data.tar.gz: 363288f5578543311ba1f00c886cc64cca9ea1fe170946946f9adca8bc394169d8e79055f6ee06a4d4585858ce0aba0d145efec8f3c5184b653203141f26f4d0
+  metadata.gz: f32f740fddfa2a5e125eccafc883c12e55e88998660a929a073941d2019cfa9aed93cb36eafbd9b679b77c2838d9958ff4d9c2cc95cfc43cb1e5de4d820f291a
+  data.tar.gz: 4c4460d6c257868887b22c13f4f53c3d37e6c9137007eeff2c8d668debcf00179cd576d218d8b7fa52bb0e2634901d821f4053073c7a368e012dc0d6026eb220

data/lib/lhc/request.rb

@@ -1,4 +1,5 @@
 require 'typhoeus'
+require 'uri'
 require 'active_support/core_ext/object/deep_dup'
 
 # The request is doing an http-request using typhoeus.
@@ -41,7 +42,7 @@ class LHC::Request
   attr_accessor :iprocessor
 
   def create_request
-    request = Typhoeus::Request.new(options[:url], typhoeusize(options))
+    request = Typhoeus::Request.new(encode_url(options[:url]), typhoeusize(options))
     request.on_headers do
       iprocessor.intercept(:after_request, self)
       iprocessor.intercept(:before_response, self)
@@ -50,6 +51,11 @@ class LHC::Request
     request
   end
 
+  def encode_url(url)
+    return url if url.nil?
+    URI.escape(url)
+  end
+
   def typhoeusize(options)
     options = options.deep_dup
     easy = Ethon::Easy.new

data/lib/lhc/version.rb

@@ -1,3 +1,3 @@
 module LHC
-  VERSION = "1.2.0"
+  VERSION = "2.0.0"
 end

data/spec/request/encoding_spec.rb

@@ -0,0 +1,24 @@
+require 'rails_helper'
+
+describe LHC::Request do
+
+  context 'encoding url' do
+
+    let(:url) { 'http://local.ch/something with spaces' }
+
+    it 'can request urls with spaces inside' do
+      stub_request(:get, URI::encode(url))
+      LHC.get(url)
+    end
+  end
+
+  context 'encoding params' do
+
+    let(:url) { 'http://local.ch/api/search?name=:name' }
+
+    it 'can do requests with params including spaces' do
+      stub_request(:get, 'http://local.ch/api/search?name=My%20name%20is%20rabbit')
+      LHC.get(url, params: { name: 'My name is rabbit' })
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lhc
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 2.0.0
 platform: ruby
 authors:
 - local.ch
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-10-01 00:00:00.000000000 Z
+date: 2015-10-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: typhoeus
@@ -204,6 +204,7 @@ files:
 - spec/interceptors/response_competition_spec.rb
 - spec/interceptors/return_response_spec.rb
 - spec/rails_helper.rb
+- spec/request/encoding_spec.rb
 - spec/request/error_handling_spec.rb
 - spec/request/headers_spec.rb
 - spec/request/option_dup_spec.rb
@@ -311,6 +312,7 @@ test_files:
 - spec/interceptors/response_competition_spec.rb
 - spec/interceptors/return_response_spec.rb
 - spec/rails_helper.rb
+- spec/request/encoding_spec.rb
 - spec/request/error_handling_spec.rb
 - spec/request/headers_spec.rb
 - spec/request/option_dup_spec.rb