lexorank 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 422a0db95be12bd9cffe35d7f549b1ebb71dd5de9751424a3794fd18dc2065c1
-  data.tar.gz: 8d00dd0cb9331d2a5152bb9f68c3ba7a29ac84de4732bc03bf5bc78a946c8a58
+  metadata.gz: 705faccc54d5d09c0ce7e8239d777b79ebe9b8857ea2956c6b7f9378f0b027d6
+  data.tar.gz: b61be364fc9dfffb76947d4ad8ae6462ac8d70490a33262bdb96ac8601e1eb7f
 SHA512:
-  metadata.gz: c49a7c38ed0853cdddc5fd1664d085ad08b8b2d91c00e8920da4a19078c6949dd29608bd92013eb31fabd2b1b46191c9ef589fb53629196f0582b53d132ca0f6
-  data.tar.gz: 6e303a53f9185913313d20ef37a9a549b1323c174c98cda5f3533e8bf16e1188ece014fa0fbbf8545b55e040b316f671aa960b99adae3b184ab05e00c6783026
+  metadata.gz: 188136b56717efec3aa8dedcdd9f977506a21677814dbe2d85488fa6f2154abe877f1412a4aaab03c1aae7b8f8badacd1982b2f77b12718893594133e10e10ef
+  data.tar.gz: afd223cb7e8a444cc0428cfab024e89044a9918cfe013972ea65d2c4250f4db70b6b5653d3d5ba989ad548f33f6fda34b6730f3a5053872e0f705f56187d7185

data/lib/lexorank/ranking.rb

@@ -3,13 +3,11 @@
 class Lexorank::Ranking
   include Lexorank
 
-  attr_reader :record_class, :original_field, :field, :original_group_by, :group_by, :advisory_lock_config
+  attr_reader :record_class, :field, :group_by, :advisory_lock_config
 
   def initialize(record_class:, field:, group_by:, advisory_lock:)
     @record_class = record_class
-    @original_field = field
-    @field = process_column_name(field)
-    @original_group_by = group_by
+    @field = field
     @group_by = process_group_by_column_name(group_by)
     @advisory_lock_config = { enabled: record_class.respond_to?(:with_advisory_lock) }.merge(advisory_lock)
   end
@@ -23,13 +21,11 @@ class Lexorank::Ranking
       )
     end
 
-    unless @field
-      # TODO: Make this raise an error. Supplying an invalid column should raise.
-      warn "The supplied ranking column \"#{@original_field}\" is not a column of the model!"
-    end
-
-    if original_group_by && !group_by
-      warn "The supplied grouping by \"#{original_group_by}\" is neither a column nor an association of the model!"
+    unless field
+      raise(
+        Lexorank::InvalidConfigError,
+        'The supplied ":field" option cannot be "nil"!'
+      )
     end
   end
 
@@ -110,23 +106,12 @@ class Lexorank::Ranking
 
   private
 
-  def process_column_name(name)
-    return unless name
-
-    # This requires an active connection... do we want this?
-    if record_class.columns.map(&:name).include?(name.to_s)
-      name
-    end
-  end
-
   def process_group_by_column_name(name)
-    processed_name = process_column_name(name)
-
     # This requires rank! to be after the specific association
-    if name && !processed_name && (association = record_class.reflect_on_association(name))
+    if name && (association = record_class.reflect_on_association(name))
       association.foreign_key.to_sym
     else
-      processed_name
+      name
     end
   end
 end

data/lib/lexorank/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Lexorank
-  VERSION = '0.2.0'
+  VERSION = '0.3.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lexorank
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Richard Böhme
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-08-16 00:00:00.000000000 Z
+date: 2024-08-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord