lex-health 0.1.7 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 58aebf740f7b4a79bf0c97cc5bae4cec886fe731bda53c681e9526f3c5d6ebc7
-  data.tar.gz: 71b495ec970cd3230614a9f6a812fdf9987bcb00c0a16784fe83cedfb23d9438
+  metadata.gz: 51bae536ed975da049ebfa332b71974b49d85886afed5f7c631de9c9d7c63265
+  data.tar.gz: 9e24916e2b2d9229121c89884c7487453dd569b24ae2fb4c277dce33a615d4d5
 SHA512:
-  metadata.gz: 0ebad0bf1c817a9bccba265b7c5b127c045b725ad8a25a966d141547f8ce535f0d5073155c41e0346b44f1d6b4409b15c0b8a72fc6d98a1357300889224356b9
-  data.tar.gz: de77a45ce02799fe3f9720054585ef6d332f7d852732035c0c8511f7c92f4fd7ec64444c2bd7b920ec6ddb219139b65ed3e37544733b77213d9bbfe14b907865
+  metadata.gz: a38f069ff4658cc951d1b4615e319daaf7e1576a285c37d4b8f3e40649caca8ce1e94e2d447a89be955d49e51238b26c3cab0b516d61caa43701eb61243c4a98
+  data.tar.gz: e31fd840329ca93fef39026b29dd786a3e12ebd980b8aad64332d6ad30c4bde8d9be66ead9f530416f39719a9de9150646bbc49922efce43d38b6a217a3e1ab2

data/.gitignore

@@ -7,5 +7,7 @@
 /spec/reports/
 /tmp/
 
+Gemfile.lock
+
 # rspec failure tracking
 .rspec_status

data/CHANGELOG.md

@@ -1,5 +1,24 @@
 # Changelog
 
+## [0.2.0] - 2026-03-18
+
+### Fixed
+- `active` column now uses boolean `true` instead of integer `1` (PostgreSQL compatibility)
+- Watchdog message routing key changed from `'health'` to `'node.health'` to match queue binding
+- Added `require 'time'` for `Time.parse`
+- Nil guard on `updated` timestamp in back-in-time comparison
+- TOCTOU race condition on concurrent heartbeat inserts (rescue UniqueConstraintViolation)
+- `delete` method nil guard for nonexistent nodes
+- `mark_workers_offline` now clears `health_node` on expired workers
+
+### Changed
+- Entry point `data_required?` is now `self.` (class method) matching framework expectation
+
+## [0.1.8] - 2026-03-17
+
+### Fixed
+- Watchdog `expire` guards against missing `Legion::Data::Model::Node` constant before use, returning an error hash when the model is unavailable
+
 ## [0.1.7] - 2026-03-16
 
 ### Fixed

data/CLAUDE.md

@@ -10,7 +10,7 @@ Legion Extension that reads heartbeat messages from cluster nodes and updates th
 
 **GitHub**: https://github.com/LegionIO/lex-health
 **License**: MIT
-**Version**: 0.1.7
+**Version**: 0.2.0
 
 ## Architecture
 

data/lib/legion/extensions/health/runners/health.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require 'time'
+
 module Legion
   module Extensions
     module Health
@@ -16,7 +18,7 @@ module Legion
               return { success: result, hostname: hostname, **opts }
             end
 
-            if opts.key?(:timestamp) && !item.values[:updated].nil? && item.values[:updated] > Time.parse(opts[:timestamp])
+            if opts.key?(:timestamp) && item.values[:updated] && item.values[:updated] > Time.parse(opts[:timestamp])
               return { success:    false,
                        reason:     'entry already updated',
                        hostname:   hostname,
@@ -24,7 +26,7 @@ module Legion
                        **opts }
             end
 
-            update_hash = { active: 1, status: opts[:status], name: hostname, updated: Sequel::CURRENT_TIMESTAMP }
+            update_hash = { active: true, status: opts[:status], name: hostname, updated: Sequel::CURRENT_TIMESTAMP }
             update_hash[:metrics] = Legion::JSON.dump(opts[:metrics]) if opts[:metrics]
             update_hash[:hosted_worker_ids] = Legion::JSON.dump(opts[:hosted_worker_ids]) if opts[:hosted_worker_ids]
             update_hash[:version] = opts[:version] if opts[:version]
@@ -36,19 +38,27 @@ module Legion
           end
 
           def insert(hostname:, status: 'unknown', **opts)
-            insert = { active: 1, status: status, name: hostname }
+            insert = { active: true, status: status, name: hostname }
             insert[:datacenter_id] = opts[:datacenter_id] if opts.key? :datacenter_id
             insert[:environment_id] = opts[:environment_id] if opts.key? :environment_id
-            insert[:active] = opts[:active] if opts.key? :active
             insert[:metrics] = Legion::JSON.dump(opts[:metrics]) if opts[:metrics]
             insert[:hosted_worker_ids] = Legion::JSON.dump(opts[:hosted_worker_ids]) if opts[:hosted_worker_ids]
             insert[:version] = opts[:version] if opts[:version]
 
-            { success: true, hostname: hostname, node_id: Legion::Data::Model::Node.insert(insert), **insert }
+            node_id = begin
+              Legion::Data::Model::Node.insert(insert)
+            rescue Sequel::UniqueConstraintViolation
+              item = Legion::Data::Model::Node[name: hostname]
+              item&.id
+            end
+            { success: true, hostname: hostname, node_id: node_id, **insert }
           end
 
           def delete(node_id:, **_opts)
-            Legion::Data::Model::Node[node_id].delete
+            node = Legion::Data::Model::Node[node_id]
+            return { success: false, error: 'node not found', node_id: node_id } if node.nil?
+
+            node.delete
             { success: true, node_id: node_id }
           end
 

data/lib/legion/extensions/health/runners/watchdog.rb

@@ -8,6 +8,8 @@ module Legion
           include Legion::Extensions::Helpers::Lex
 
           def expire(expire_time: 60, **_opts)
+            return { success: false, reason: 'Legion::Data::Model::Node not available' } unless defined?(Legion::Data::Model::Node)
+
             cutoff = Time.now - expire_time
             nodes = []
             Legion::Data::Model::Node
@@ -36,7 +38,7 @@ module Legion
             Legion::Data::Model::DigitalWorker
               .where(health_node: node_name, health_status: 'online')
               .each do |worker|
-                worker.update(health_status: 'offline')
+                worker.update(health_status: 'offline', health_node: nil)
               end
           rescue StandardError => e
             log.warn "worker offline marking failed: #{e.message}" if respond_to?(:log)

data/lib/legion/extensions/health/transport/messages/watchdog.rb

@@ -7,7 +7,7 @@ module Legion
         module Messages
           class Watchdog < Legion::Transport::Message
             def routing_key
-              'health'
+              'node.health'
             end
 
             def expiration

data/lib/legion/extensions/health/version.rb

@@ -3,7 +3,7 @@
 module Legion
   module Extensions
     module Health
-      VERSION = '0.1.7'
+      VERSION = '0.2.0'
     end
   end
 end

data/lib/legion/extensions/health.rb

@@ -10,10 +10,6 @@ module Legion
       def self.data_required?
         true
       end
-
-      def data_required?
-        true
-      end
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lex-health
 version: !ruby/object:Gem::Version
-  version: 0.1.7
+  version: 0.2.0
 platform: ruby
 authors:
 - Esity
@@ -100,7 +100,6 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".circleci/config.yml"
 - ".github/workflows/ci.yml"
 - ".gitignore"
 - ".rspec"
@@ -109,7 +108,6 @@ files:
 - CLAUDE.md
 - Dockerfile
 - Gemfile
-- Gemfile.lock
 - LICENSE.txt
 - README.md
 - Rakefile

data/.circleci/config.yml

@@ -1,61 +0,0 @@
-version: 2.1
-orbs:
-  ruby: circleci/ruby@0.2.1
-
-jobs:
-  "rubocop":
-    docker:
-      - image: circleci/ruby:2.5-node
-    steps:
-      - checkout
-      - ruby/load-cache
-      - ruby/install-deps
-      - run:
-          name: Run Rubocop
-          command: bundle exec rubocop
-      - ruby/save-cache
-  "ruby-two-five":
-    docker:
-      - image: circleci/ruby:2.5
-      - image: memcached:1.5-alpine
-    steps:
-      - checkout
-      - ruby/load-cache
-      - ruby/install-deps
-      - ruby/run-tests
-      - ruby/save-cache
-  "ruby-two-six":
-    docker:
-      - image: circleci/ruby:2.6
-      - image: memcached:1.5-alpine
-    steps:
-      - checkout
-      - ruby/load-cache
-      - ruby/install-deps
-      - ruby/run-tests
-      - ruby/save-cache
-  "ruby-two-seven":
-    docker:
-      - image: circleci/ruby:2.7
-      - image: memcached:1.5-alpine
-    steps:
-      - checkout
-      - ruby/load-cache
-      - ruby/install-deps
-      - ruby/run-tests
-      - ruby/save-cache
-
-workflows:
-  version: 2
-  rubocop-rspec:
-    jobs:
-      - rubocop
-      - ruby-two-five:
-          requires:
-            - rubocop
-      - ruby-two-six:
-          requires:
-            - ruby-two-five
-      - ruby-two-seven:
-          requires:
-            - ruby-two-five

data/Gemfile.lock

@@ -1,86 +0,0 @@
-PATH
-  remote: .
-  specs:
-    lex-health (0.1.7)
-
-GEM
-  remote: https://rubygems.org/
-  specs:
-    addressable (2.8.9)
-      public_suffix (>= 2.0.2, < 8.0)
-    ast (2.4.3)
-    bigdecimal (4.0.1)
-    diff-lcs (1.6.2)
-    json (2.19.1)
-    json-schema (6.2.0)
-      addressable (~> 2.8)
-      bigdecimal (>= 3.1, < 5)
-    language_server-protocol (3.17.0.5)
-    lint_roller (1.1.0)
-    mcp (0.8.0)
-      json-schema (>= 4.1)
-    parallel (1.27.0)
-    parser (3.3.10.2)
-      ast (~> 2.4.1)
-      racc
-    prism (1.9.0)
-    public_suffix (7.0.5)
-    racc (1.8.1)
-    rainbow (3.1.1)
-    rake (13.3.1)
-    regexp_parser (2.11.3)
-    rspec (3.13.2)
-      rspec-core (~> 3.13.0)
-      rspec-expectations (~> 3.13.0)
-      rspec-mocks (~> 3.13.0)
-    rspec-core (3.13.6)
-      rspec-support (~> 3.13.0)
-    rspec-expectations (3.13.5)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.13.0)
-    rspec-mocks (3.13.8)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.13.0)
-    rspec-support (3.13.7)
-    rubocop (1.85.1)
-      json (~> 2.3)
-      language_server-protocol (~> 3.17.0.2)
-      lint_roller (~> 1.1.0)
-      mcp (~> 0.6)
-      parallel (~> 1.10)
-      parser (>= 3.3.0.2)
-      rainbow (>= 2.2.2, < 4.0)
-      regexp_parser (>= 2.9.3, < 3.0)
-      rubocop-ast (>= 1.49.0, < 2.0)
-      ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 2.4.0, < 4.0)
-    rubocop-ast (1.49.1)
-      parser (>= 3.3.7.2)
-      prism (~> 1.7)
-    rubocop-rspec (3.9.0)
-      lint_roller (~> 1.1)
-      rubocop (~> 1.81)
-    ruby-progressbar (1.13.0)
-    sequel (5.102.0)
-      bigdecimal
-    sqlite3 (2.9.2-arm64-darwin)
-    sqlite3 (2.9.2-x86_64-linux-gnu)
-    unicode-display_width (3.2.0)
-      unicode-emoji (~> 4.1)
-    unicode-emoji (4.2.0)
-
-PLATFORMS
-  arm64-darwin-25
-  x86_64-linux
-
-DEPENDENCIES
-  lex-health!
-  rake
-  rspec
-  rubocop
-  rubocop-rspec
-  sequel
-  sqlite3
-
-BUNDLED WITH
-   2.6.9